Problems with data inserting..

[emme85]

No data is insert into my table.. is there anything wrong with my coding??

<?php 
$host= 'localhost';
$username= 'root';
$password= '';

$connect =mysql_connect($host, $username, $password) or
die ("could not connect to MySQL sever in localhost");
$db="care_pair";
mysql_select_db($db, $connect) or
die ("could not select database");

 ?>
<?php

$RNo=$_POST['Report_No'];
$NVessel=$_POST['Name_of_Vessel'];
$RTime=$_POST['Report_Time'];
$DAccident=$_POST['Date_of_Accident'];
$TAccident=$_POST['Time_of_Accident'];
$IPName=$_POST['IP_Name'];
$IPSname=$_POST['IP_Surname'];
$IPDOB=$_POST['IP_DOB'];
$IPNat=$_POST['IP_Nationality'];
$IPsex=$_POST['IP_Sex'];
$IPSAdd=$_POST['IP_Address'];
$IPPass=$_POST['IP_Passport'];

$query = "INSERT INTO Report VALUES ('$RNo','$NVessel','$RTime','$DAccident','$TAccident'','IPName','$IPSname','$IPDOB', 
          '$IPNat','$IPsex','$IPAdd', '$IPPass')";
mysql_query($query);



?>

[TobyRT]

Make this your last line and let us know what it says:

mysql_query($query) or die(mysql_error())

Basic error checking like that will save you a lot of headaches 🙂

[emme85]

Well.. the error says:
You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near '''','','','', '','','', '')' at line 1

i really dont know what is going on.. i use other code too, but still can't insert data..
the other code:

$query="INSERT INTO Report SET
Report_No = '$RNo', Name_of_Vessel= '$NVessel', Report_Time= '$RTime', Date_of_Accident= '$DAccident',
Time_of_Accident= '$TAccident', IP_Name= '$IPName', IP_Surname= '$IPSname', IP_DOB= '$IPDOB', IP_Nationality= '$IPNat',
IP_Sex= '$IPsex', IP_Address= '$IPAdd', IP_Passport= '$IPPass'";              

$result=mysql_query($query)
or die("There was an error: ".mysql_error());

[bubblenut]

I would guess that some of the variables you're using haven't been propery escaped but we can find out for sure by outputing the SQL on failure as well as the error message.

$query = "INSERT ...";
$result = mysql_query( $query )
  or die( "There was an error running '$query' " . mysql_error());

[emme85]

Hmmmm... theres no errors.. and yet no data was inserted..

[leatherback]

Sounds to me like you are having colum-count trouble?

use this structure:

insert into TABLE (colum2, colum5, colum9) values (value1, value2, value3)

[emme85]

i use this code:

<?php

$RNo=$_POST['Report_No'];
$NVessel=$_POST['Name_of_Vessel'];
$RTime=$_POST['Report_Time'];
$DAccident=$_POST['Date_of_Accident'];
$TAccident=$_POST['Time_of_Accident'];
$IPName=$_POST['IP_Name'];
$IPSname=$_POST['IP_Surname'];
$IPDOB=$_POST['IP_DOB'];
$IPNat=$_POST['IP_Nationality'];
$IPsex=$_POST['IP_Sex'];
$IPSAdd=$_POST['IP_Address'];
$IPPass=$_POST['IP_Passport'];

$query="INSERT INTO Report( 
Report_No, Name_of_Vessel, Report_Time, Date_of_Accident, Time_of_Accident, IP_Name, IP_Surname, IP_DOB, 
IP_Nationality, IP_Sex, IP_Address, IP_Passport) VALUES ('$RNo','$NVessel', '$RTime','$DAccident',
'$TAccident','$IPName', '$IPSname','$IPDOB', '$IPNat',
'$IPsex','$IPAdd','$IPPass')";              

$result=mysql_query($query)
or die( "There was an error running '$query' " . mysql_error());
?>

Finally..succeeded!!
Thanks to all of u..

[emme85]

Hey.. i used the code above n for a start.. it really succeeds in storing data, but it got the 'cardinality problems' (ive posted before..)..
and now im having the same problem(inserting data) but i changed the codes..
this is the code:

$host= 'localhost';
$username= 'root';
$password= '';

$connect =mysql_connect($host, $username, $password) or
die ("could not connect to MySQL sever in localhost");
$db="care_pair";
mysql_select_db($db, $connect) or
die ("could not select database");

function GetSQLValueString($theValue, $theType, $theDefinedValue = "", $theNotDefinedValue = "") 
{
  $theValue = (!get_magic_quotes_gpc()) ? addslashes($theValue) : $theValue;

  switch ($theType) {
    case "text":
      $theValue = ($theValue != "") ? "'" . $theValue . "'" : "NULL";
      break;    

    case "long":
    case "int":
      $theValue = ($theValue != "") ? intval($theValue) : "NULL";
      break;
    case "double":
      $theValue = ($theValue != "") ? "'" . doubleval($theValue) . "'" : "NULL";
      break;
    case "date":
      $theValue = ($theValue != "") ? "'" . $theValue . "'" : "NULL";
      break;
    case "defined":
      $theValue = ($theValue != "") ? $theDefinedValue : $theNotDefinedValue;
      break;
  }
  return $theValue;
}

$editFormAction = $HTTP_SERVER_VARS['PHP_SELF'];
if (isset($HTTP_SERVER_VARS['QUERY_STRING'])) 
{
  $editFormAction .= "?" . $HTTP_SERVER_VARS['QUERY_STRING'];
}

if ((isset($_POST["MM_insert"])) && ($_POST["MM_insert"] == "form1")) 
{
  $insertSQL = sprintf("INSERT INTO Report(Report_No, Name_of_Vessel, Report_Time,
                       Date_of_Accident, Time_of_Accident, IP_Name, IP_Surname, IP_DOB,
					   IP_Nationality, IP_Sex, IP_Address, IP_Passport) VALUES (%s,%s,%s,%s,%s,%s,%s,%s,%s,%s,%s,%s)",                     

                       GetSQLValueString($_POST['Report_No'], "text"),
                       GetSQLValueString($_POST['Name_of_Vessel'], "text"),
					   GetSQLValueString($_POST['Report_Time'], "text"),
					   GetSQLValueString($_POST['Date_of_Accident'], "text"),
					   GetSQLValueString($_POST['Time_of_Accident'], "text"),
					   GetSQLValueString($_POST['IP_Name'], "text"),
					   GetSQLValueString($_POST['IP_Surname'], "text"),
					   GetSQLValueString($_POST['IP_DOB'], "text"),
					   GetSQLValueString($_POST['IP_Nationality'], "text"),
					   GetSQLValueString($_POST['IP_Sex'], "text"),
					   GetSQLValueString($_POST['IP_Address'], "text"),
					   GetSQLValueString($_POST['IP_Passport'], "text"));

  $Result1 = mysql_query($insertSQL) or die( "There was an error running '$query' " . mysql_error());
}

but still, no data were inserted.

Surprisingly, i used the same code for other database, it worked!(the data were stored)

$host= 'localhost';
$username= 'root';
$password= '';

$connect =mysql_connect($host, $username, $password) or
die ("could not connect to MySQL sever in localhost");
$db="Idora_Laundry_System";
mysql_select_db($db, $connect) or
die ("could not select database");

function GetSQLValueString($theValue, $theType, $theDefinedValue = "", $theNotDefinedValue = "") 
{
  $theValue = (!get_magic_quotes_gpc()) ? addslashes($theValue) : $theValue;

  switch ($theType) {
    case "text":
      $theValue = ($theValue != "") ? "'" . $theValue . "'" : "NULL";
      break;    

    case "long":
    case "int":
      $theValue = ($theValue != "") ? intval($theValue) : "NULL";
      break;
    case "double":
      $theValue = ($theValue != "") ? "'" . doubleval($theValue) . "'" : "NULL";
      break;
    case "date":
      $theValue = ($theValue != "") ? "'" . $theValue . "'" : "NULL";
      break;
    case "defined":
      $theValue = ($theValue != "") ? $theDefinedValue : $theNotDefinedValue;
      break;
  }
  return $theValue;
}

$editFormAction = $HTTP_SERVER_VARS['PHP_SELF'];
if (isset($HTTP_SERVER_VARS['QUERY_STRING'])) {
  $editFormAction .= "?" . $HTTP_SERVER_VARS['QUERY_STRING'];
}

if ((isset($HTTP_POST_VARS["MM_insert"])) && ($HTTP_POST_VARS["MM_insert"] == "form2")) {
  $insertSQL = sprintf("INSERT INTO Supplier (Supp_Id, Supp_Name, Supp_Add, Supp_Phone) VALUES (%s, %s, %s, %s)",
                       GetSQLValueString($HTTP_POST_VARS['Supp_Id'], "text"),
                       GetSQLValueString($HTTP_POST_VARS['Supp_Name'], "text"),
                       GetSQLValueString($HTTP_POST_VARS['Supp_Add'], "text"),
                       GetSQLValueString($HTTP_POST_VARS['Supp_Phone'], "text"));



  $Result1 = mysql_query($insertSQL) or die(mysql_error());
}

What would be the problem with care_pair database?