Cardinality problems..

emme85

In my web form database, I have 4 tables (Report, position, const_acc, const_location). position, const_acc n const_location are tables with checkboxes.
Each of them including Report table had the same primary key (ID)--> auto increment.
Every time I inserted data, the cardinality of Report table increased itself.

For example, I filled in the form for 3 times. The cardinality of each table should be 3, instead of Report table which its cardinality became 6. Why is it??
my english is not fluent, so i dont know how to explain more.. but i include my attachment so that u guys can see.. i'm using wamp5 server..

leatherback

Could you please post the code used to update the tables. Use [php ] [/ php] (Without spaces) around the code, so it get's highlighted

emme85

Do you mean this??

<?php

$RNo=$_POST['Report_No'];
$NVessel=$_POST['Name_of_Vessel'];
$RTime=$_POST['Report_Time'];
$DAccident=$_POST['Date_of_Accident'];
$TAccident=$_POST['Time_of_Accident'];
$IPName=$_POST['IP_Name'];
$IPSname=$_POST['IP_Surname'];
$IPDOB=$_POST['IP_DOB'];
$IPNat=$_POST['IP_Nationality'];
$IPsex=$_POST['IP_Sex'];
$IPSAdd=$_POST['IP_Address'];
$IPPass=$_POST['IP_Passport'];
$DOEvent=$_POST['Desc_of_Event'];

$query="INSERT INTO Report( 
Report_No, Name_of_Vessel, Report_Time, Date_of_Accident, Time_of_Accident, IP_Name, IP_Surname, IP_DOB, 
IP_Nationality, IP_Sex, IP_Address, IP_Passport, Desc_of_Event) VALUES ('$RNo','$NVessel', '$RTime','$DAccident',
'$TAccident','$IPName', '$IPSname','$IPDOB', '$IPNat',
'$IPsex','$IPAdd','$IPPass', '$DOEvent')";              

$result=mysql_query($query)
or die( "There was an error running '$query' " . mysql_error());
?>

Plz tell me if it is not what you mean.. sory..

leatherback

Yes. But this in itself does not insert a code twise. I suppose I am looking for the logic of your code too. So basically from the point where you decide to do an instert, untill the point where all inserts are done.

emme85

leatherback wrote:
Yes. But this in itself does not insert a code twise. I suppose I am looking for the logic of your code too. So basically from the point where you decide to do an instert, untill the point where all inserts are done.

Erm.. im sory.. i dont get what u meant..
im doing my practical training in this company for my diploma. im a Comp. Science student, but i learnt only basic of php in my class, so i dont know much about php and mysql.. and now i had to make a web form for them. can u explain to me what do you want me to do?? at least i can learn something new.

i attached my whole codes (not fit in here to post).

leatherback

A few things are happening in your code:

1) You have little insert pieces throughout your code. There really is not need for this, and it makes debugging & understanding your scipts later on really hard. Better try to do all the manipulation stuff in one location, and create the output in another. I racked all the php together so i can post it here. You should do this in your code too, and remove all <?php ?> tags from the rest of your code.

2) For the first insert you do not test whether the form was actualy submitted. So both upon loading the form, as with inserting the form data gets inserted. That is what was bugging you. See code below.

3) For formatig the form you should not be using all the font, strong etc tags, but you should be using Cascading Style Sheets, or CSS. The way you code it now is very big and lumpy in download

// IF you have multiple files, you should place the login details in a separate file, and include it if you need database activity on a page

// Make sure you verify the submitted data, and do basic anti-sql inject stuff
// such as mysql_escape_real_string()
$RNo=$_POST['Report_No'];
$NVessel=$_POST['Name_of_Vessel'];
$RTime=$_POST['Report_Time'];
$DAccident=$_POST['Date_of_Accident'];
$TAccident=$_POST['Time_of_Accident'];
$IPName=$_POST['IP_Name'];
$IPSname=$_POST['IP_Surname'];
$IPDOB=$_POST['IP_DOB'];
$IPNat=$_POST['IP_Nationality'];
$IPsex=$_POST['IP_Sex'];
$IPSAdd=$_POST['IP_Address'];
$IPPass=$_POST['IP_Passport'];
$DOEvent=$_POST['Desc_of_Event'];

// HERE you should have tested whether dtaa was actualy posted.

$query="INSERT INTO Report( 
Report_No, Name_of_Vessel, Report_Time, Date_of_Accident, Time_of_Accident, IP_Name, IP_Surname, IP_DOB, 
IP_Nationality, IP_Sex, IP_Address, IP_Passport, Desc_of_Event) VALUES ('$RNo','$NVessel', '$RTime','$DAccident',
'$TAccident','$IPName', '$IPSname','$IPDOB', '$IPNat',
'$IPsex','$IPAdd','$IPPass', '$DOEvent')";              

$result=mysql_query($query)
  or die( "There was an error running '$query' " . mysql_error());

if(isset($_POST['Location']))
  {
    $values = implode(",", $_POST['Location']);
    $query = "INSERT INTO const_location (Location) VALUES('$values')";
    mysql_query($query) or die("Error inserting into const_location: ".mysql_error());
  }
mysql_close($connect);


if(isset($_POST['Type']))
  {
    $values = implode(",", $_POST['Type']);
    $query = "INSERT INTO const_acc (Type) VALUES('$values')";
    mysql_query($query) or die("Error inserting into const_acc: ".mysql_error());
  }

if(isset($_POST['Injured_person']))
  {
    $values = implode(",", $_POST['Injured_person']);
    $query = "INSERT INTO position (Injured_person) VALUES('$values')";
    mysql_query($query) or die("Error inserting into position: ".mysql_error());
  } 


 ?>