If - elseif Statement

[aspekt9]

Does anybody see anything wrong with these statements?

		if($ampm == 'PM'){
				$display .= '<option value="'. $ampm .'" selected>'. $ampm .'</option>';
				$display .= 'option value="AM">AM</option>';
		} elseif ($ampm == 'AM') {
				$display .= '<option value="'. $ampm .'" selected>'. $ampm .'</option>';
				$display .= '<option value="PM">PM</option>';
		} else {
		     echo 'BLAH';
		}

For some reason the select box is returning a blank box and of course I get the echoed value 'BLAH' I know the value of $ampm is being passed, I've even echoed it out to check. So that means theres something wrong with my if statements I just can't figure it out.

[NogDog]

If all you are getting is "BLAH", then either $ampm is not set at all, or its value is neither "AM" nor "PM". (Perhaps it's "am" or "pm"?) You might want to set [font=courier]error_reporting(E_ALL);[/font] to see if you're getting any notices about $ampm not being set.

In any case, I'd probably code that this way:

foreach(array('AM', 'PM') as $value)
{
   $selected = ($ampm == $value) ? ' selected="selected"' : '';
   $display .= "<option value='$value'$selected>$value</option>\n";
}

[aspekt9]

Your code seemed to have solved my proble, thanks. Also, is it normal to receive a lot of notices for undefined index for $POST data because everything I use in my class shows up as an undefined index ($POST['name'] for example shows it as undefined index for name in blahblah/blah)?

[NogDog]

The notices would be "normal" if either there is a logic error or if you are being "sloppy" in a sense in referring to $_POST elements when they may not necessarily be set. (Don't take the term "sloppy" personally, it's just the only adjective I could think of; and believe me, a lot of people do it.)

Suppose in the preceding example that $ampm comes from $POST['ampm'], but that depending on the logic flow and user actions, it may or may not be set yet. You then could do something like the following to deal with either situation:

$ampm = (isset($_POST['ampm'])) ? $_POST['ampm'] : '';
foreach(array('AM', 'PM') as $value)
{
   $selected = ($ampm == $value) ? ' selected="selected"' : '';
   $display .= "<option value='$value'$selected>$value</option>\n";
}