help with calendar

blckspder

hello
I just picked up this book called php hacks thought I would mess around with it.. I used a tutorial in it to build a calendar, but I am running into a problem getting the calendar to go back past march. and when I go forward to December it jumps to march 2008 and skips January and February. Can someone point out what I am missing?

<?php
class Day {
	function Day($inmonth, $month, $day, $year) {
		$this->{'month'} = $month;
		$this->{'day'} = $day;
		$this->{'year'} = $year;
		$this->{'inmonth'} = $inmonth;
		$this->{'number'} = $number;
		$this->{'text'} = "";
		}
	function get_day() { return $this->{'day'}; }
	function get_month() { return $this->{'month'}; }
	function get_year() { return $this->{'year'}; }
	function get_inmonth() { return $this->{'inmonth'}; }
	function get_number() { return $this->{'number'}; }
	function get_text() { return $this->{'text'}; }
	function set_text($text) { return $this->{'text'} = $text; }
	}

function setCalendarText($days, $m, $d, $y, $text) {
	foreach($days as $day) {
		if($day->get_day() == $d && $day->get_month() == $m && $day->get_year() == $y)
		$day->set_text($text);
		}
	}

function get_last_month($month, $year) {
	$lastmonth = $month - 1;
	$lastyear = $year;
	if($lastmonth < 0) {
		$lastmonth = 11; $lastyear -= 1;
		}
	return array($lastmonth, $lastyear);
	}

function get_next_month($month, $year) {
	$nextmonth = $month + 1;
	$nextyear = $year;
	if($nextmonth > 11) {
		$nextmonth = 0;
		$nextyear += 1;
		}
	return array($nextmonth, $nextyear);
	}

function makeCalendarDays($month, $year) {
	list($nextmonth, $nextyear) = get_next_month($month, $year);
	list($lastmonth, $lastyear) = get_last_month($month, $year);

$dimlm = cal_days_in_month(CAL_GREGORIAN, $lastmonth, $lastyear);

$jd = cal_to_jd(CAL_GREGORIAN, $month + 1, 1, $year);
$day = jddayofweek($jd);
$dim = cal_days_in_month(CAL_GREGORIAN, $month + 1, $year);

$days = array();

for($d = 0; $d < $day; $d++)
	$days []= new Day(0, $lastmonth + 1, $dimlm - ($day - $d), $lastyear);

for($d = 1; $d <= $dim; $d++)
	$days []= new Day(1, $month + 1, $d, $year);

$left = ((floor(($day + $dim) /7) +1) *7) - ($day + $dim);
for($d = 0; $d < $left; $d++)
	$days []= new Day(0, $nextmonth + 1, $d+1, $nextyear);
return $days;
}

$today = getdate();

$year = $today['year'];
$month = $today['mon'] - 1;

if($_GET['year']) $year = $_GET['year'];
if($_GET['month']) $month = $_GET['month'];

$days = makeCalendarDays($month, $year);

setCalendarText(&$days, $month + 1, 5, $year, "Meet<br />Jim");
setCalendarText(&$days, $month + 1, 10, $year, "Meet<br />Sue");

$months = array("January","February","March","April","May","June","July","August","September",
"October","November","December");

$day_names = array("Sun","Mon","Tue","Wed","Thu","Fri","Sat");
?>

<div style="width: 600px">
<table class="calendar" width="100%" cellspacing="0" cellpadding="1">
	<tr>
		<td colspan="7" class="calender-title" width="13%">
		<?php
		list($nextmonth, $nextyear) = get_next_month($month, $year);
		list($lastmonth, $lastyear) = get_last_month($month, $year);
		?>
		<a href="index.php?year=<?php echo($lastyear);?>&month=<?php echo($lastmonth); ?>">&lt;&lt;</a>
		<?php echo($months[$month]); ?> <?php echo($year); ?>
		<a href="index.php?year=<?php echo($nextyear); ?>&month=<?php echo($nextmonth);
		?>">&gt;&gt;</a>
		</td>
	</tr>
	<tr>
		<?php foreach($day_names as $day) {?>
		<td class="calendar-day-title"><?php echo($day); ?></td>
		<?php } ?>
	</tr>
	<?php
	$p = 0;
	foreach($days as $d) {
		if($p == 0) echo ("<tr>");
		$day_style = $d->get_inmonth() ? "calendar-day" : "calendar-outmonth-day";
	?>
	<td class="<?php echo($day_style); ?>" width="13%">
	<div class="calendar-day-number">
	<?php echo($d->get_day()); ?>
	</div>
	<div class="calendar-content">
	<?php echo($d->get_text()); ?>
	</div>
	</td>
	<?php
	$p += 1;
	if($p == 7) $p =0;
	}
	?>

Thanks for the help

blckspder

I have been trying to debug and I made a little progress. I changed the argument for the following function:

function get_last_month($month, $year) {
	$lastmonth = $month - 1;
	$lastyear = $year;
	if($lastmonth <= 0) {
		$lastmonth = 11; 
		$lastyear -= 1;
		}
	return array($lastmonth, $lastyear);
	}

Instead of just less than I added the = and now I can go to the previous year but it still skips the month of January.

I think there may be a problem with this function also:

function get_next_month($month, $year) {
	$nextmonth = $month + 1;
	$nextyear = $year;
	if($nextmonth > 11) {
		$nextmonth = 0;
		$nextyear += 1;
		}
	return array($nextmonth, $nextyear);
	}

When I go from December and try to hit january it skips january and feb and goes right to march. it works correctly from march until december though.

blckspder

I have tried some more things and havent been able to get any farther with the script if someone notices something please let me know. thanks for your help.

Bunkermaster

you should have a look at [man]mktime[/man]

blckspder

ok thanks Ill check that out

johnboy_inbboo

I don't know if you ever solved this. I'm not a php programmer but here's what I did. There are probably better solutions if someone knows this language better than I do.

The original problem with January not displaying stems from this line of code not working properly.

I change:
if ( $GET['month'] ) $month = $GET['month'];
to
if ( $GET['month'] ) $month = $GET['month']-1;

For some reason, if month=0 is passed in, the _GET does not get it. Not sure why, maybe php programmers would know. So instead of the stupid non-intuitive january=0, you now pass in 1.

You also have to mod this code to add 1 to the links for next/last month.

<a href="cal.php?year=<?php echo($lastyear); ?>&month=<?php echo( $lastmonth + 1); ?>"><<</a>
<?php echo( $months[$month] ); ?> <?php echo( $year ); ?>
<a href="cal.php?year=<?php echo($nextyear); ?>&month=<?php echo( $nextmonth + 1); ?>">>></a>

Hope this helps, if not the original poster, someone else who spent money on this book full of faulty code. There are more problems with this script involving the setCalendarText routine that I will post on a separate thread.

cheers and keep your stick on the ice!