[RESOLVED] unexpected '}'

[hanpedro]

I've met unexpected '}' in _escape.lib.php on line 91.
How can I solve this?

<?
function latest_club_iframe($skin_dir="", $gr_id, $rows=10, $subject_len=40, $category="", $orderby="")
{
global $config;
global $g4;

$today = getdate(); 
$gong = "0";
$a_year = $today['year']; 

$before_day =365;  
$before_time = date("Y-m-d H:i:s", $g4[server_time] - (86400 * $before_day)); 
$start_day = "$a_year-01-01 00:00:00";
$end_day = "$a_year-12-31 23:59:59";

$gr_id = $gr_id; 
$NotSelectTable="'club_qa','club_ad'";



$hit_ro_ha_ja='YES'; 


if ($hit_ro_ha_ja=='NO'): 

$top1 = $top2 = $rows;  
$list1 = array(); reset($list1); 
$list2 = array();reset($list2); 
$list3 = array(); reset($list3); 
$list4 = array();reset($list4); 

$sql = " select bo_table, bo_subject ,bo_notice from $g4[board_table] 
          where gr_id = '$gr_id'
		  and bo_table not in ($NotSelectTable)"; 
$result = sql_query($sql); 

while ($row = sql_fetch_array($result)) 
{ 
    $sql2 = " select * from $g4[write_prefix]$row[bo_table] 
                where ((wr_comment > -1 or wr_datetime) and (wr_datetime >= '$start_day' or wr_datetime <= '$end_day')) "; 
    $result2 = sql_query($sql2); 

  while ($row2 = sql_fetch_array($result2)) 
    { 
    	$key = $row2[wr_datetime]. '-' . $row2[wr_id]; 
      if($row2[wr_subject])
      { 
        $list1[$key][bo_subject] = conv_subject($row[bo_subject],40,'…' ); 
        $list1[$key][subject] = conv_subject($row2[wr_subject],$subject_len,'…'); 
        $list1[$key][ca_name] = $row2[ca_name]; 
     //   $list1[$key][href] = "../new/print_list2.php?bo_table=$row[bo_table]&wr_id=$row2[wr_id]&sca=$row2[ca_name]"; 
        $list1[$key][href] = "../club/club_main.php?botable=1&cb_id=$row[bo_table]&wr_id=$row2[wr_id]&sca=$row2[ca_name]"; 
        $list1[$key][bo_table] = $row[bo_table]; 
        $list1[$key][wr_id] = $row2[wr_id]; 
        $list1[$key][is_notice] = preg_match("/[^0-9]{0,1}{$row2[wr_id]}[\r]{0,1}/",$row[bo_notice]); 
        $list1[$key][wr_datetime] = $row2[wr_datetime]; 
        $list1[$key][datetime] = "($row2[wr_datetime])"; 
        $list1[$key][mb_id] = "$row2[mb_id]"; 
        $list1[$key][wr_name] = "$row2[wr_name]"; 

        //
        $key = substr('00000'.$row2[wr_hit],-5) . '-' . $row2[wr_id]; 

        $list2[$key][bo_subject] = conv_subject($row[bo_subject],40,'…' ); 
        $list2[$key][subject] = conv_subject($row2[wr_subject],30,'…'); 
        $list2[$key][ca_name] = $row2[ca_name]; 
//       $list2[$key][href] = "../new/print_list2.php?bo_table=$row[bo_table]&wr_id=$row2[wr_id]&sca=$row2[ca_name]"; 
        $list1[$key][href] = "../club/club_main.php?botable=1&cb_id=$row[bo_table]&wr_id=$row2[wr_id]&sca=$row2[ca_name]"; 
        $list2[$key][bo_table] = $row[bo_table]; 
        $list2[$key][wr_id] = $row2[wr_id]; 
        $list2[$key][is_notice] = preg_match("/[^0-9]{0,1}{$row2[wr_id]}[\r]{0,1}/",$row[bo_notice]); 
        $list2[$key][wr_hit] = $row2[wr_hit]; 
        $list2[$key][hit] = "($row2[wr_hit])"; 
        $list2[$key][mb_id] = "$row2[mb_id]"; 
        $list2[$key][wr_name] = "$row2[wr_name]"; 

        }//if 
    } //while 
  } 

$list3 = $list1; 
$list4 = $list2; 
@krsort($list1); 
@krsort($list2); 
@ksort($list3); 
@ksort($list4); 
return ;

include "$latest_skin_path/latest.skin.php";
}
?>

Any comment would be appreciated.

[Piranha]

What row is like 91?

[hanpedro]

row 91 is like row 3

[Weedpacket]

hanpedro wrote:

row 91 is like row 3

Well, that makes perfect sense....

But have you tried counting your { and }? There should be the same number of both, and they should be properly nested. It would appear that you have more } than {.

[HalfaBee]

Whats wrong with this line ?

if ($hit_ro_ha_ja=='NO'):

[wilku]

The ":" at the end?
It always makes me smile, $hit varible 😉

[hanpedro]

wilku wrote:

The ":" at the end?
It always makes me smile, $hit varible 😉

Thank you for your kindness!!!
wow!

[hanpedro]

HalfaBee wrote:

Whats wrong with this line ?

if ($hit_ro_ha_ja=='NO'):

Thank you for your kindness for correcting this!

[bradgrafelman]

Don't forget to mark this thread resolved (if it is).

EDIT: Just some general remarks:

1. Array indeces in your case should be strings. $row[name] does not have a string as an index, but a constant. PHP will detect this (assuming there actually isn't a constant named 'name') and throw an E_WARNING and then assume it is a string. So, use quotes: $row['name'].

2. Arrays, more specifically items in arrays referenced by indeces, should not simply appear inside a double-quoted string. If they do, they should be wrapped in braces ( {} ). Instead, I usually escape out of the string and concatenate the array in the middle, like so:

   echo 'Your name is: ' . $row['name'] . '! Hello there.';