processing form

[aftabn10]

I have been trying to create a form which when filled will add the details on a database and then send me an email copy of the details as well. The only problem I currently have is that i have got the script (thanks to installer) but he has disabled the email sending and i was just wondering how i would enable this.

The following is the processing script.

<?php

/**
include './form_fields.inc';
foreach ($form_fields as $category) {
    foreach ($category as $field => $value) {
        echo $field . '<br />';
    }
}

exit;
exit;
**/

echo '<pre>';
print_r($_POST);
echo '</pre>';

$title = 'Hello';

if (!isset($_POST['submit']) || $_SERVER['REQUEST_METHOD'] != "POST") { 
    exit("<p>You did not press the submit button; this page should not be accessed directly.</p>"); 
} else { 
    $exploits = "/(content-type|bcc:|cc:|document.cookie|onclick|onload|javascript|alert)/i"; 
    $profanity = "/(beastial|bestial)/i"; 
    $spamwords = "/(spam|spam|spam|eggandspam)/i"; 
    $bots = "/(Indy|Blaiz|Java|libwww-perl|Python|OutfoxBot|User-Agent|PycURL|AlphaServer)/i"; 

if (preg_match($bots, $_SERVER['HTTP_USER_AGENT'])) { 
    exit("<p>Known spam bots are not allowed.</p>"); 
} 

$long_enough_curr = false; 
$long_enough_prev = false; 
if ($_POST['htime']['yrs'] >= 3) { 
    $long_enough_curr = true; 
}
if ($long_enough_curr || ($_POST['ptime']['yrs'] > 3)) {
    $long_enough_prev = true;
}

check_input($_POST);

echo '<pre>';
print_r($_POST);
echo '</pre>';

extract($_POST);

$recipient = '[e-mail]'; 

$subject = 'You have a new order'; 

$message  = 'Order Form: ' . "\n"; 
$message .= 'Title: ' . $title . "\n"; 
$message .= 'Forename: ' . $forename . "\n"; 
$message .= 'Surname: ' . $surname . "\n"; 
$message .= 'Home Address: ' . $haddress . "\n"; 
$message .= 'Town: ' . $htown . "\n"; 
$message .= 'Postcode: ' . $hpostcode . "\n"; 
$message .= 'Time At Current Address: ' . $htime['yrs'] . ' Years' . $htime['mons'] .' Months' . "\n"; 
$message .= 'Billing Address: ' . $baddress . "\n"; 
$message .= 'Town: ' . $btown . "\n"; 
$message .= 'Billing Postcode: ' . $bpostcode . "\n"; 
$message .= 'Occupation: ' . $jobtitle . "\n"; 
$message .= 'Time With Present Employer: ' . $jobtime['yrs'] . ' Years ' . $jobtime['mons'] . ' Months' . "\n"; 
//$message .= 'Marital Status: ' . $marital . "\n"; 
$message .= 'Date of Birth: ' . $birthdate['day'] .'-' . $birthdate['mon'] . '-' . $birthdate['yr'] . "\n"; 
$message .= 'Telephone: ' . $telephone . "\n"; 
$message .= 'Mobile: ' . $mobile . "\n"; 
if (!$long_enough_curr) { 
    $message .= 'First Previous Address: ' . $paddress . "\n"; 
    $message .= 'Town: ' . $ptown . "\n"; 
    $message .= 'Postcode: ' . $ppostcode . "\n"; 
    $message .= 'Time At Previous Address: ' . $ptime['yrs'] . ' Years ' . $ptime['mons'] . ' Months' . "\n"; 
} else {
    $paddress = 'n/a';
    $ptown = 'n/a';
    $ppostcode = 'n/a';
    $ptime['yrs'] = 0;
    $ptime['mons'] = 0;
}
if (!$long_enough_prev) { 
    $message .= 'Second Previous Address: ' . $paddress2 . "\n"; 
    $message .= 'Town: ' . $ptown2 . "\n"; 
    $message .= 'Postcode: ' . $ppostcode2 . "\n"; 
    $message .= 'Time At Previous Address ' . $ptime2['yrs'] . ' Years ' . $ptime2['mons'] . ' Months' . "\n"; 
} else {
    $paddress2 = 'n/a';
    $ptown2 = 'n/a';
    $ppostcode2 = 'n/a';
    $ptime2['yrs'] = 0;
    $ptime2['mons'] = 0;
}
$message .= 'Accomodation Type: ' . $accom . "\n"; 
$message .= 'Occupation Type: ' . $occ . "\n"; 
//$message .= 'Proof of Address: ' . $dproof . "\n";   
$message .= 'Date of Birth: ' . $dproof['day'] . '-' . $dproof['mon'] . '-' . $dproof['yr'] . "\n";     
$message .= 'E-mail: ' . $email . "\n"; 
$message .= 'Country: ' . $country . "\n";   


echo nl2br($message); 
} 

$db_server = 'server.co.uk';
$user      = 'username';
$password  = 'password';
$db        = 'db';
$tablename = 'orders';

$connection = my_mysql_connect($db_server, $user, $password);

$query = "USE " . $db;
$result = my_mysql_query($query);

$query = "INSERT INTO " . $tablename . 
         " VALUES ('" . mysql_real_escape_string($forename) . "', " .
                  "'" . mysql_real_escape_string($surname) . "', " .
                  "'" . mysql_real_escape_string($haddress) . "', " .
                  "'" . mysql_real_escape_string($htown) . "', " .
                  "'" . mysql_real_escape_string($hpostcode) . "', " .
                        mysql_real_escape_string($htime['yrs']) . ", " .
                        mysql_real_escape_string($htime['mons']) . ", " .
                  "'" . mysql_real_escape_string($baddress) . "', " .
                  "'" . mysql_real_escape_string($btown) . "', " .
                  "'" . mysql_real_escape_string($bpostcode) . "', " .
                  "'" . mysql_real_escape_string($jobtitle) . "', " .
                        mysql_real_escape_string($jobtime['yrs']) . ", " .
                        mysql_real_escape_string($jobtime['mons']) . ", " .
                  "'" . date('Ymd', strtotime($birthdate['mon'] . ' ' . $birthdate['day'] . ', ' . $birthdate['yr'])) . "', " .
                  "'" . mysql_real_escape_string($telephone) . "', " .
                  "'" . mysql_real_escape_string($mobile) . "', " .
                  "'" . mysql_real_escape_string($paddress) . "', " .
                  "'" . mysql_real_escape_string($ptown) . "', " .
                  "'" . mysql_real_escape_string($ppostcode) . "', " .
                        mysql_real_escape_string($ptime['yrs']) . ", " .
                        mysql_real_escape_string($ptime['mons']) . ", " .
                  "'" . mysql_real_escape_string($paddress2) . "', " .
                  "'" . mysql_real_escape_string($ptown2) . "', " .
                  "'" . mysql_real_escape_string($ppostcode2) . "', " .
                        mysql_real_escape_string($ptime2['yrs']) . ", " .
                        mysql_real_escape_string($ptime2['mons']) . ", " .
                  "'" . mysql_real_escape_string($accom) . "', " .
                  "'" . mysql_real_escape_string($occ) . "', " .
                  "'" . date('Ymd', strtotime($dproof['mon'] . ' ' . $dproof['day'] . ', ' . $dproof['yr'])) . "', " .
                  "'" . mysql_real_escape_string($email) . "', " .
                  "'" . mysql_real_escape_string($country) . "')";

$result = my_mysql_query($query);
echo '<pre>';
echo $query;
echo '</pre>';

$headers = 'From: <' . $recipient . '>' . "\n"; 
$headers .= 'Reply-To: <' . $email . '>'; 

/**
if (mail($recipient,$subject,$message,$headers)) { 
    echo "<p>Thank you! Your order has now been placed. We will be in touch shortly.<br><br>User</p>"; 
} else { 
    echo "<p>Sorry, there was an error and your mail was not sent. Please find an alternative method of contacting the webmaster.</p>"; 
} 
**/

function check_input(&$data)
{
    foreach ($data as $key => $value) { 
        if (is_array($value)) {
            check_input($data[$key]);
        } else { 
            if (empty($value) && ((!$GLOBALS['long_enough_curr'] && ($key == 'paddress' || $key == 'ptime'  || $key == 'ptime')) 
                              || (!$GLOBALS['long_enough_prev'] && ($key == 'paddress2' || $key == 'ptime2'  || $key == 'ptime2')))) { 
                exit("<p>Empty fields are not allowed. Please go back and fill in the form properly.</p>"); 
            } elseif (preg_match($GLOBALS['exploits'], $value)) { 
                exit("<p>Exploits/malicious scripting attributes aren't allowed.</p>"); 
            } elseif (preg_match($GLOBALS['profanity'], $value) || preg_match($GLOBALS['spamwords'], $value)) { 
                exit("<p>That kind of language is not allowed through our form.</p>"); 
            } 

        $value = strip_tags($value);
        if (ini_get('magic_quotes_gpc')) {
            $data[$key] = stripslashes($value);
        }
    } 
} 
}

function my_mysql_query($qry)
{
    echo '-----------------------' . '<br />';
    $res = mysql_query($qry);
    if ($res === false) {
        die('<font color="red">Query</font> "' . $qry . '" <font color="red"><strong>failed</strong>:</font> ' . mysql_error() . '<br />');
    } else {
        echo '<font color="green">Query</font> "' . $qry . '" <font color="green"><strong>succeeded</strong>.</font>' . '<br />';
        return $res;
    }
}

function echo_query_result_array($res)
{
    echo '-----------------------' . '<br />';
    while ($row = mysql_fetch_assoc($res)) {
        $i = 0;
        foreach ($row as $key => $value) {
            echo $key . ' => ' . $value;
            if ($i++ < (count($row) - 1)) {
                echo ', ';
            }
        }
        echo '<br />';
    }
}

function my_mysql_connect($srvr, $usr, $pword)
{
    $hndl = mysql_connect ($srvr, $usr, $pword);
    if ($hndl === false) {
        die('<font color="red">Connection to</font> "' . $srvr . '" <font color="red"><strong>failed</strong>:</font> ' . mysql_error() . '<br />');
    } else {
        echo '<font color="green">Connection to</font> "' . $srvr . '" <font color="green"><strong>succeeded</strong>.</font>' . '<br />';
        return($hndl);
    }
}

?>

Please can any1 help?

[roscor]

Take out

/**

**/ 

around

if (mail($recipient,$subject,$message,$headers)) {
    echo "<p>Thank you! Your order has now been placed. We will be in touch shortly.<br><br>User</p>";
} else {
    echo "<p>Sorry, there was an error and your mail was not sent. Please find an alternative method of contacting the webmaster.</p>";
}

The script does not parse this information and such tags are used for the information of the programer

such as

/**
This section sends the Mail
**/

[aftabn10]

Thank you Roscor. Got it sorted. Just one more thing, when i actually submit the form (with sample data) I get the following:

Array
(
[forename] => .
[surname] => .
[haddress] => .
[htown] => .
[hpostcode] => .
[htime] => Array
(
[yrs] => 3
[mons] => 1
)

[baddress] => .
[btown] => .
[bpostcode] => .
[jobtitle] => .
[jobtime] => Array
    (
        [yrs] => 0
        [mons] => 1
    )

[birthdate] => Array
    (
        [day] => 1
        [mon] => Jan
        [yr] => 1907
    )

[telephone] => .
[mobile] => .
[paddress] => 
[ptown] => 
[ppostcode] => 
[ptime] => Array
    (
        [yrs] => 0
        [mons] => 1
    )

[paddress2] => 
[ptown2] => 
[ppostcode2] => 
[ptime2] => Array
    (
        [yrs] => 0
        [mons] => 1
    )

[accom] => .
[occ] => .
[dproof] => Array
    (
        [day] => 1
        [mon] => Jan
        [yr] => 1907
    )

[email] => [e-mail]
[country] => UK
[submit] => Submit

)

Array
(
[forename] => .
[surname] => .
[haddress] => .
[htown] => .
[hpostcode] => .
[htime] => Array
(
[yrs] => 3
[mons] => 1
)

[baddress] => .
[btown] => .
[bpostcode] => .
[jobtitle] => .
[jobtime] => Array
    (
        [yrs] => 0
        [mons] => 1
    )

[birthdate] => Array
    (
        [day] => 1
        [mon] => Jan
        [yr] => 1907
    )

[telephone] => .
[mobile] => .
[paddress] => 
[ptown] => 
[ppostcode] => 
[ptime] => Array
    (
        [yrs] => 0
        [mons] => 1
    )

[paddress2] => 
[ptown2] => 
[ppostcode2] => 
[ptime2] => Array
    (
        [yrs] => 0
        [mons] => 1
    )

[accom] => .
[occ] => .
[dproof] => Array
    (
        [day] => 1
        [mon] => Jan
        [yr] => 1907
    )

[email] => [e-mail]
[country] => UK
[submit] => Submit

)

Order Form:
Title: Hello
Forename: .
Surname: .
Home Address: .
Town: .
Postcode: .
Time At Current Address: 3 Years1 Months
Billing Address: .
Town: .
Billing Postcode: .
Occupation: .
Time With Present Employer: 0 Years 1 Months
Date of Birth: 1-Jan-1907
Telephone: .
Mobile: .
Accomodation Type: .
Occupation Type: .
Date of Birth: 1-Jan-1907
E-mail: .@.com
Country: UK

Connection to "db171.oneandone.co.uk" succeeded.

Query "USE db121342183" succeeded.

Query "INSERT INTO orders VALUES ('.', '.', '.', '.', '.', 3, 1, '.', '.', '.', '.', 0, 1, '19070101', '.', '.', 'n/a', 'n/a', 'n/a', 0, 0, 'n/a', 'n/a', 'n/a', 0, 0, '.', '.', '19070101', '.@.com', 'UK')" succeeded.

INSERT INTO orders VALUES ('.', '.', '.', '.', '.', 3, 1, '.', '.', '.', '.', 0, 1, '19070101', '.', '.', 'n/a', 'n/a', 'n/a', 0, 0, 'n/a', 'n/a', 'n/a', 0, 0, '.', '.', '19070101', '.@.com', 'UK')
Thank you! Your order has now been placed. We will be in touch shortly.

How would i disable all the above and only display what actually is highlighted in bold? is their anything that i need to change in my code as the user does not really need all this info. please help?

[roscor]

Try ommiting

echo '<pre>';
print_r($_POST);
echo '</pre>';

by using /* before and after the script which outputs the array.
see the manual,
http://uk3.php.net/manual/en/function.print-r.php.

[aftabn10]

thank you. i have managed to get rid of the array section, but how would i disable the following:

Connection to "db171.oneandone.co.uk" succeeded.

Query "USE db121342183" succeeded.

Query "INSERT INTO orders VALUES ('.', '.', '.', '.', '.', 3, 1, '.', '.', '.', '.', 0, 1, '19070101', '.', '.', 'n/a', 'n/a', 'n/a', 0, 0, 'n/a', 'n/a', 'n/a', 0, 0, '.', '.', '19070101', '.@.com', 'UK')" succeeded.

INSERT INTO orders VALUES ('.', '.', '.', '.', '.', 3, 1, '.', '.', '.', '.', 0, 1, '19070101', '.', '.', 'n/a', 'n/a', 'n/a', 0, 0, 'n/a', 'n/a', 'n/a', 0, 0, '.', '.', '19070101', '.@.com', 'UK')

I have tried to check for print commands but not found any others. Please help?

[roscor]

try altering

function my_mysql_connect($srvr, $usr, $pword)
{
    $hndl = mysql_connect ($srvr, $usr, $pword);
    if ($hndl === false) {
        die('<font color="red">Connection to</font> "' . $srvr . '" <font color="red"><strong>failed</strong>:</font> ' . mysql_error() . '<br />');
    } else {
        echo '<font color="green">Connection to</font> "' . $srvr . '" <font color="green"><strong>succeeded</strong>.</font>' . '<br />';
        return($hndl);
    }
} 

to

function my_mysql_connect($srvr, $usr, $pword)
{
    $hndl = mysql_connect ($srvr, $usr, $pword);
    if ($hndl === false) {
        die('<font color="red">Connection to</font> "' . $srvr . '" <font color="red"><strong>failed</strong>:</font> ' . mysql_error() . '<br />');
    } else {

}
} 

removing this section stops the echo (display of succeeded line) but should still die() if the code fails

[aftabn10]

Thanks for that Roscor. I have managed to sort that out. sorry to trouble tho, but got one more question. The following is my form page and i was just wondering if i wanted to change the layout of the form and separate it in columns so you dont have to scroll down too much, would i need to change code on the page below or actually change it in the form_fields.inc?

form.php

<?php

require_once('form_fields.inc');
echo '<form action="./process.php" method="post">' . "\r\n";
echo '<left><table border="0" width="0" class="main2">' . "\r\n";
foreach ($form_fields as $category) {
    foreach ($category as $field => $value) {
        $value['type']($field, $value);
    }                                                           

    echo '<tr><td colspan="2" align="right"><font color="blue">------------------------------------</font></td></tr>';
}
echo '</table>' . "\r\n"
   . '<input type="submit" name="submit" value="Submit" />' . "\r\n"
   . '</center></form>' . "\r\n";

function regular_text($field, $value)
{
    echo '<tr><td align="right">' . "\r\n"
       . '<label for="' . $field . '">' . $value['labl'] . ':</label>' . "\r\n"
       . '</td>'
       . '<td align="left">' . "\r\n"
       . '<input type="text" length="' . $value['data'] . '" name="' . $field . '" id="' . $field . '" /><br />' . "\r\n"
       . '</td></tr>' . "\r\n";
}

function regular_select($field, $value)
{
    echo '<tr><td align="right">' . "\r\n"
       . '<label for="' . $field . '">' . $value['labl'] . ':</label>' . "\r\n"
       . '</td>'
       . '<td align="left">' . "\r\n"
       . '<select name="' . $field . '" id="' . $field . '">' . "\r\n";
    for ($i = 0; $i < count($value['data']); $i++) {
        echo '<option value="' . $value['data'][$i] . '">' . $value['data'][$i] . '</option>' . "\r\n";
    }
    echo '</select><br />' . "\r\n"
       . '</td></tr>' . "\r\n";
}

function special_date_select($field, $value)
{
    global $special_date_fields;
    echo '<tr><td align="center" colspan="2">' . "\r\n"
       .  $value['labl'] . ':<br />' . "\r\n";
    foreach ($special_date_fields as $key => $select) {
        echo '<label for="' . $field . '_' . $key . '">' . $select['labl'] . ':</label>' . "\r\n"
           . '<select name="' . $field . '[' . $key . '] ' . 'id="' . $field . '_' . $key . '">' . "\r\n";
        for ($i = 0; $i < count($select['data']); $i++) {
            echo '<option value="' . $select['data'][$i] . '">' . $select['data'][$i] . '</option>' . "\r\n";
        }
        echo '</select>' . "\r\n";
    }
    echo '</td></tr>' . "\r\n";
}

function special_duration_select($field, $value)
{
    global $special_duration_fields;
    echo '<tr><td align="center" colspan="2">' . "\r\n"
       .  $value['labl'] . '<br />' . "\r\n";
    foreach ($special_duration_fields as $key => $select) {
        echo '<label for="' . $field . '_' . $key . '">' . $select['labl'] . '</label>' . "\r\n"
           . '<select name="' . $field . '[' . $key . '] ' . 'id="' . $field . '_' . $key . '">' . "\r\n";
        for ($i = 0; $i < count($select['data']); $i++) {
            echo '<option value="' . $select['data'][$i] . '">' . $select['data'][$i] . '</option>' . "\r\n";
        }
        echo '</select>' . "\r\n";
    }
    echo '</td></tr>' . "\r\n";

}

?>

[aftabn10]

form_fields.inc

<?php

$form_fields = array('name'         => array('forename'   => array('labl' => 'First Name',
                                                                   'type' => 'regular_text',
                                                                   'data' => '20'), 
                                             'surname'    => array('labl' => 'Surname',
                                                                   'type' => 'regular_text',
                                                                   'data' => '20')),
                     'current_addr' => array('haddress'   => array('labl' => 'Address',
                                                                   'type' => 'regular_text',
                                                                   'data' => '20'), 
                                             'htown'      => array('labl' => 'Town',
                                                                   'type' => 'regular_text',
                                                                   'data' => '20'), 
                                             'hpostcode'  => array('labl' => 'Post Code',
                                                                   'type' => 'regular_text',
                                                                   'data' => '20'), 
                                             'htime'      => array('labl' => 'Time at Current Address:',
                                                                   'type' => 'special_duration_select',
                                                                   'data' => '')),
                     'billing_addr' => array('baddress'   => array('labl' => 'Billing Address',
                                                                   'type' => 'regular_text',
                                                                   'data' => '20'), 
                                             'btown'      => array('labl' => 'Town',
                                                                   'type' => 'regular_text',
                                                                   'data' => '20'), 
                                             'bpostcode'  => array('labl' => 'Post Code',
                                                                   'type' => 'regular_text',
                                                                   'data' => '20')),
                     'job'          => array('jobtitle'   => array('labl' => 'Job Title',
                                                                   'type' => 'regular_text',
                                                                   'data' => '20'), 
                                             'jobtime'    => array('labl' => 'Time at Current Job:',
                                                                   'type' => 'special_duration_select',
                                                                   'data' => '')),
                     'info'         => array('birthdate'  => array('labl' => 'Date of Birth',
                                                                   'type' => 'special_date_select',
                                                                   'data' => ''), 
                                             'telephone'  => array('labl' => 'Telephone',
                                                                   'type' => 'regular_text',
                                                                   'data' => '20'), 
                                             'mobile'     => array('labl' => 'Mobile Phone',
                                                                   'type' => 'regular_text',
                                                                   'data' => '20')),
                     'prev_addr'    => array('paddress'   => array('labl' => 'Previous Address',
                                                                   'type' => 'regular_text',
                                                                   'data' => '20'), 
                                             'ptown'      => array('labl' => 'Town',
                                                                   'type' => 'regular_text',
                                                                   'data' => '20'), 
                                             'ppostcode'  => array('labl' => 'Post Code',
                                                                   'type' => 'regular_text',
                                                                   'data' => '20'), 
                                             'ptime'      => array('labl' => 'Time at Previous Address:',
                                                                   'type' => 'special_duration_select',
                                                                   'data' => '')),
                     'prev_addr_2'  => array('paddress2'  => array('labl' => 'Second Previous Address',
                                                                   'type' => 'regular_text',
                                                                   'data' => '20'), 
                                             'ptown2'     => array('labl' => 'Town',
                                                                   'type' => 'regular_text',
                                                                   'data' => '20'), 
                                             'ppostcode2' => array('labl' => 'Post Code',
                                                                   'type' => 'regular_text',
                                                                   'data' => '20'), 
                                             'ptime2'     => array('labl' => 'Time at Second Previous Address:',
                                                                   'type' => 'special_duration_select',
                                                                   'data' => '')),
                     'other'        => array('accom'      => array('labl' => 'Accomodation',
                                                                   'type' => 'regular_text',
                                                                   'data' => '20'), 
                                             'occ'        => array('labl' => 'Occupation',
                                                                   'type' => 'regular_text',
                                                                   'data' => '20'), 
                                             'dproof'     => array('labl' => 'Date of Birth',
                                                                   'type' => 'special_date_select',
                                                                   'data' => ''), 
                                             'email'      => array('labl' => 'E-Mail',
                                                                   'type' => 'regular_text',
                                                                   'data' => '20'), 
                                             'country'    => array('labl'  => 'Country',
                                                                   'type' => 'regular_text',
                                                                   'data' => '20')));

$special_date_fields = array('day' => array('labl' => 'Day',
                                            'type' => 'select',
                                            'data' => range('1', '31')), 
                             'mon' => array('labl' => 'Month',
                                            'type' => 'select',
                                            'data' => array('Jan', 'Feb', 'Mar', 'Apr', 'May', 'Jun', 'Jul', 'Aug', 'Sep', 'Oct', 'Nov', 'Dec')), 
                             'yr'  => array('labl' => 'Year',
                                            'type' => 'select',
                                            'data' => range('1907', '2007'))); 

$special_duration_fields = array('yrs'  => array('labl' => 'Years',
                                                 'type' => 'regular_select',
                                                 'data' => range('0', '50')), 
                                 'mons' => array('labl' => 'Months',
                                                 'type' => 'regular_select',
                                                 'data' => range('1', '12')));

?>