Score variable not updating

[Tezread]

This is driving me up the wall so im probably missing something tiny out.
I have a scoring system

<?php 
include("include/session.php");
include("connect.php");    

$username = $_SESSION['username']; 

if (isset($_POST['submit'])) { 
$answer = array(); 

$answer[1] = $_POST['time']; 
$answer[2] = $_POST['demand']; 
$answer[3] = $_POST['external_support']; 
$answer[4] = $_POST['training']; 
$answer[5] = $_POST['complexity']; 
$answer[6] = $_POST['depth']; 
$answer[7] = $_POST['partuse']; 
$answer[8] = $_POST['cost']; 
$answer[9] = $_POST['orgwhole']; 
$answer[10] = $_POST['external_validated']; 
$answer[11] = $_POST['advocacy'];  

$answer[12] = $_POST['advice'];  

$answer[13] = $_POST['animal'];  

$answer[14] = $_POST['art'];  


///etc

$sql = "UPDATE qualityuser SET time = '$answer[1]',
demand = '$answer[2]',
external_support = '$answer[3]',
training = '$answer[4]',
complexity = '$answer[5]',
depth = '$answer[6]',
partuse = '$answer[7]',
cost = '$answer[8]',
orgwhole = '$answer[9]',
external_validated = '$answer[10]',
advocacy = '$answer[11]',
advice = '$answer[12]',
animal = '$answer[13]',
art = '$answer[14]',
////etc
WHERE username = '$username'";

mysql_query($sql) or exit(mysql_error()); 

}

//score processing for each quality system

function pqasso($answer) 
{ 
$pqasso_score = 0;
//time needed
    if ($answer[1] == "Standards achievable in under 6 months") {$pqasso_score = $pqasso_score + 1000;}
	if ($answer[1] == "Standards achievable in under 12 months") {$pqasso_score = $pqasso_score - 0;} 
	if ($answer[1] == "Neither important nor unimportant – longer time is okay or preferred") {$pqasso_score = $pqasso_score - 0;}


//demand on staff time
	if ($answer[2] == "Standards achievable without high involvement of all staff") {$pqasso_score = $pqasso_score - 0;} 
	if ($answer[2] == "Neither important nor unimportant") {$pqasso_score = $pqasso_score + 1000;}
	if ($answer[2] == "Process of working towards standards needs active involvement of staff") {$pqasso_score = $pqasso_score - 0;} 

//need for external support
	if ($answer[3] == "Standards achievable without significant support from external agency") {$pqasso_score = $pqasso_score + 1000;}
	if ($answer[3] == "Preference for Standards where specific support is available") {$pqasso_score = $pqasso_score - 0;}
	if ($answer[3] == "Neither important nor unimportant") {$pqasso_score = $pqasso_score - 0;}

/// level of training
	if ($answer[4] == "Standards achievable without training") {$pqasso_score = $pqasso_score + 1000;}
	if ($answer[4] == "Some training requirement expected and acceptable") {$pqasso_score = $pqasso_score - 0;} 
    if ($answer[4] == "Significant training requirement expected and acceptable") {$pqasso_score = $pqasso_score - 0;} 
    if ($answer[4] == "Neither important nor unimportant") {$pqasso_score = $pqasso_score - 0;} 

// complexity
	if ($answer[5] == "Vital for standards to be straight-forward and easy to grasp") {$pqasso_score = $pqasso_score + 1000;}
	if ($answer[5] == "Neither important nor unimportant") {$pqasso_score = $pqasso_score - 0;}
	if ($answer[5] == "The need to understand unfamiliar concepts is acceptable") {$pqasso_score = $pqasso_score - 0;}

//relevance to voluntary sector
	if ($answer[6] == "Neither important nor unimportant") {$pqasso_score = $pqasso_score - 0;} 
	if ($answer[6] == "Desirable to be well-used & adapted to voluntary sector use") {$pqasso_score = $pqasso_score + 500;} 
	if ($answer[6] == "Essential to be well-used and adapted to voluntary sector use") {$pqasso_score = $pqasso_score + 1000;}

//facility for part use
	if ($answer[7] == "Essential to be able to use selectively") {$pqasso_score = $pqasso_score + 1000;} 
	if ($answer[7] == "Desirable to be used selectively") {$pqasso_score = $pqasso_score - 0;} 
	if ($answer[7] == "Neither important nor unimportant") {$pqasso_score = $pqasso_score - 0;}

// cost
	if ($answer[8] == "Low cost essential") {$pqasso_score = $pqasso_score + 1000;}
	if ($answer[8] == "Low cost desirable") {$pqasso_score = $pqasso_score - 0;} 
	if ($answer[8] == "Reasonable costs budgeted for") {$pqasso_score = $pqasso_score - 0;} 
    if ($answer[8] == "Neither important nor unimportant") {$pqasso_score = $pqasso_score - 0;} 

////etc	

return $pqasso_score;}

////etc other functions appear the same

//List B Specialist systems and standards
///////////////////telephone helplines/////////////
function tha($answer) 
{ 
$tha_score = 0;

if ($answer[21] == 1) {$tha_score = $tha_score + 1000;}
if ($answer[22] == 1) {$tha_score = $tha_score + 1000;}
if ($answer[27] == 1) {$tha_score = $tha_score + 1000;}
if ($answer[36] == 1) {$tha_score = $tha_score + 1000;}
if ($answer[38] == 1) {$tha_score = $tha_score + 1000;}

return $tha_score;}

/////convert functions to vars

$pqasso_result = pqasso($answer);  

$iip_result = iip($answer); 
$iso_result = iso($answer);
$excel_result = excel($answer);
$social_result = social($answer);
$qmark_result = qmark($answer);
$chmark_result = chmark($answer);
$qfirst_result = qfirst($answer);
$balanced_result = balanced($answer);
$bigpic_result = bigpic($answer);
$tha_result = tha($answer);

//insert scores 
if (isset($_POST['submit'])) { 
include "connect.php";

$username = $_SESSION['username']; 
$scorearray[1] = $pqasso_result;
$scorearray[2] = $iip_result;
$scorearray[3] = $iso_result;
$scorearray[4] = $excel_result;
$scorearray[5] = $social_result;
$scorearray[6] = $qmark_result;
$scorearray[7] = $chmark_result;
$scorearray[8] = $qfirst_result;
$scorearray[9] = $balanced_result;
$scorearray[10] = $bigpic_result;
$scorearray[11] = $tha_result;
$qualitysystem[1] = "PQASSO";
$qualitysystem[2] = "Investors in People";
$qualitysystem[3] = "ISO Standards";
$qualitysystem[4] = "Excel";
$qualitysystem[5] = "Social Audit";
$qualitysystem[6] = "Quality Mark";
$qualitysystem[7] = "Charter Mark";
$qualitysystem[8] = "Quality First";
$qualitysystem[9] = "Balanced Scorecard";
$qualitysystem[10] = "Big Picture";
$qualitysystem[11] = "Telephone Helplines Association";
$searchurl[1] = "http://www.mindseyemidlands.co.uk/notts_quality/info_resource/qualitysystem_complete_details.php?quality_name=PQASSO";
$searchurl[2] = "http://www.mindseyemidlands.co.uk/notts_quality/info_resource/qualitysystem_complete_details.php?quality_name=IIP+(Investors+in+People)";
$searchurl[3] = "http://www.mindseyemidlands.co.uk/notts_quality/info_resource/qualitysystem_complete_details.php?quality_name=ISO+Standards";
$searchurl[4] = "http://www.mindseyemidlands.co.uk/notts_quality/info_resource/qualitysystem_complete_details.php?quality_name=EFQM+Excellence+Model+(European+Foundation+for+Quality+Management)";
$searchurl[5] = "http://www.mindseyemidlands.co.uk/notts_quality/info_resource/qualitysystem_complete_details.php?quality_name=Social+Accounting+and+Audit";
$searchurl[6] = "http://www.mindseyemidlands.co.uk/notts_quality/info_resource/qualitysystem_complete_details.php?quality_name=CLS+Quality+Mark+(Community+Legal+Services)";
$searchurl[7] = "http://www.mindseyemidlands.co.uk/notts_quality/info_resource/qualitysystem_complete_details.php?quality_name=Charter+Mark";
$searchurl[8] = "http://www.mindseyemidlands.co.uk/notts_quality/info_resource/qualitysystem_complete_details.php?quality_name=Quality+First";
$searchurl[9] = "http://www.mindseyemidlands.co.uk/notts_quality/info_resource/qualitysystem_complete_details.php?quality_name=Balanced+Scorecard";
$searchurl[10] = "Big Picture";
$searchurl[11] = "http://www.mindseyemidlands.co.uk/notts_quality/info_resource/qualitysystem_complete_details.php?quality_name=THA+(Telephone+Helplines+Association)+Quality+Standard";

$category[1] = "List A";
$category[2] = "List A";
$category[3] = "List A";
$category[4] = "List A";
$category[5] = "List A";
$category[6] = "List A";
$category[7] = "List A";
$category[8] = "List A";
$category[9] = "List A";
$category[10] = "List A";
$category[11] = "List B";

$values = array(); 
foreach($scorearray as $key => $score) 
{ 
 // each element will be a parenthesized list of values: 
$values[] = sprintf("('%s','%s',%d,'%s','%s')", $username, $qualitysystem[$key], $score, $searchurl[$key], $category[$key]); 
} 
// merge values into sequence of comma-separated value lists: 
$valueList = implode(',', $values); 
// create the SQL: 
$sql = "INSERT INTO `qualityuserscores` (`username`, `qualitysystem`, `score`, `search_url`, `category`) VALUES $valueList
ON DUPLICATE KEY UPDATE last_updated = NOW()";

$result = mysql_query($sql) or exit(mysql_error()); 

}
header("Location: http://www.mindseyemidlands.co.uk/notts_quality/info_resource/selfassess_part2b_v1.php");          

?>

for some reason if i choose any options relating to the function tha the score is not updated it always stays at 0

function tha($answer) 
{ 
$tha_score = 0;

if ($answer[21] == 1) {$tha_score = $tha_score + 1000;}
if ($answer[22] == 1) {$tha_score = $tha_score + 1000;}
if ($answer[27] == 1) {$tha_score = $tha_score + 1000;}
if ($answer[36] == 1) {$tha_score = $tha_score + 1000;}
if ($answer[38] == 1) {$tha_score = $tha_score + 1000;}

return $tha_score;}

why is this?

[NogDog]

Unless I missed something, I don't see where you set any element of the $answer array with an index greater than 14, but your function is looking for array indexes whose values are all 21 and higher.

[Tezread]

all the answer arrays are there I have just showed part of the array as it is so long and we have a 10000 character limit when posting:

if (isset($_POST['submit'])) { 
$answer = array(); 

$answer[1] = $_POST['time']; 
$answer[2] = $_POST['demand']; 
$answer[3] = $_POST['external_support']; 
$answer[4] = $_POST['training']; 
$answer[5] = $_POST['complexity']; 
$answer[6] = $_POST['depth']; 
$answer[7] = $_POST['partuse']; 
$answer[8] = $_POST['cost']; 
$answer[9] = $_POST['orgwhole']; 
$answer[10] = $_POST['external_validated']; 
$answer[11] = $_POST['advocacy'];  

$answer[12] = $_POST['advice'];  

$answer[13] = $_POST['animal'];  

$answer[14] = $_POST['art'];  

$answer[15] = $_POST['aware'];   

$answer[16] = $_POST['childcare'];   

$answer[17] = $_POST['commdev'];  

$answer[18] = $_POST['commrep'];  

$answer[19] = $_POST['commsafe'];  

$answer[20] = $_POST['conservation'];  

$answer[21] = $_POST['counselling'];  

$answer[22] = $_POST['crisis'];  

$answer[23] = $_POST['credit'];  

$answer[24] = $_POST['cultural'];  

$answer[25] = $_POST['daycare'];  

$answer[26] = $_POST['daycentre'];  

$answer[27] = $_POST['debt'];   

$answer[28] = $_POST['domiciliary'];  

$answer[29] = $_POST['education'];  

$answer[30] = $_POST['equipment'];   

$answer[31] = $_POST['financial'];  

$answer[32] = $_POST['health'];   

$answer[33] = $_POST['holiday'];  

$answer[34] = $_POST['homevisit'];  

$answer[35] = $_POST['housing'];  

$answer[36] = $_POST['infoadvice'];  

$answer[37] = $_POST['infrastructure'];  

$answer[38] = $_POST['legal'];  

$answer[39] = $_POST['library'];  

$answer[40] = $_POST['lunch'];   

$answer[41] = $_POST['mediation'];  

$answer[42] = $_POST['mentoring'];  

$answer[43] = $_POST['monitoring'];  

$answer[44] = $_POST['play'];   

$answer[45] = $_POST['playgroup'];  

$answer[46] = $_POST['professional'];   

$answer[47] = $_POST['recreation'];  

$answer[48] = $_POST['recycling'];  

$answer[49] = $_POST['religious'];   

$answer[50] = $_POST['research'];  

$answer[51] = $_POST['respite'];  

$answer[52] = $_POST['socialwelfare'];   

$answer[53] = $_POST['sports'];   

$answer[54] = $_POST['supportbusiness'];   

$answer[55] = $_POST['supportgroups'];  

$answer[56] = $_POST['tenants'];  

$answer[57] = $_POST['trainindividual'];  

$answer[58] = $_POST['uniform'];  

$answer[59] = $_POST['voladvice'];  

$answer[60] = $_POST['workshop'];  

$answer[61] = $_POST['youth'];  

$sql = "UPDATE qualityuser SET time = '$answer[1]',
demand = '$answer[2]',
external_support = '$answer[3]',
training = '$answer[4]',
complexity = '$answer[5]',
depth = '$answer[6]',
partuse = '$answer[7]',
cost = '$answer[8]',
orgwhole = '$answer[9]',
external_validated = '$answer[10]',
advocacy = '$answer[11]',
advice = '$answer[12]',
animal = '$answer[13]',
art = '$answer[14]',
aware = '$answer[15]',
childcare = '$answer[16]',
commdev = '$answer[17]',
commrep = '$answer[18]',
commsafe = '$answer[19]',
conservation = '$answer[20]',
counselling = '$answer[21]',
crisis = '$answer[22]',
credit = '$answer[23]',
cultural = '$answer[24]',
daycare = '$answer[25]',
daycentre = '$answer[26]',
debt = '$answer[27]',
domiciliary = '$answer[28]',
education = '$answer[29]',
equipment = '$answer[30]',
financial = '$answer[31]',
health = '$answer[32]',
holiday = '$answer[33]',
homevisit = '$answer[34]',
housing = '$answer[35]',
infoadvice = '$answer[36]',
infrastructure = '$answer[37]',
legal = '$answer[38]',
library = '$answer[39]',
lunch = '$answer[40]',
mediation = '$answer[41]',
mentoring = '$answer[42]',
monitoring = '$answer[43]',
play = '$answer[44]',
playgroup = '$answer[45]',
professional = '$answer[46]',
recreation = '$answer[47]',
recycling = '$answer[48]',
religious = '$answer[49]', 
research = '$answer[50]',
respite = '$answer[51]',
socialwelfare = '$answer[52]', 
sports = '$answer[53]', 
supportbusiness = '$answer[54]',
supportgroups = '$answer[55]', 
tenants = '$answer[56]',
trainindividual = '$answer[57]',
uniform = '$answer[58]', 
voladvice = '$answer[59]',
workshop = '$answer[60]',
youth = '$answer[61]'

WHERE username = '$username'";

mysql_query($sql) or exit(mysql_error()); 

}

//score processing for each quality system

function pqasso($answer) 
{ 
$pqasso_score = 0;
//time needed
    if ($answer[1] == "Standards achievable in under 6 months") {$pqasso_score = $pqasso_score + 1000;}
	if ($answer[1] == "Standards achievable in under 12 months") {$pqasso_score = $pqasso_score - 0;} 
	if ($answer[1] == "Neither important nor unimportant – longer time is okay or preferred") {$pqasso_score = $pqasso_score - 0;}

[Tezread]

i have changed thre INSERT ... ON DUPLICATE procedure to a REPLACE INTO....
and it seems to work ok now

[bradgrafelman]

Don't forget to mark this thread resolved.