Problem with foreach loop in functions

[Sherrie]

Hi all!

I am trying to create a foreach loop to simplify some of my processes.

Here's what I've got:

function compute_dimension($dim)
{
$comm=array('Q1','Q3','Q45','Q46','Q53','Q71','Q73');
$cust=array('Q4','Q9','Q11','Q21','Q30','Q58','Q68','Q72','Q90','Q95');
$iden=array('Q25','Q36','Q50','Q62','Q83','Q86','Q92');
$jobs=array('Q28','Q44','Q51','Q61','Q87','Q95');

$a=$dim;
	foreach ($a as $qn)
	{
	compute_org($qn);
	}
}

compute_dimension($comm);

I keep getting an error message saying that it's an invalid foreach argument.

It works when I just do this:

function compute_dimension()
{
$comm=array('Q1','Q3','Q45','Q46','Q53','Q71','Q73');
$cust=array('Q4','Q9','Q11','Q21','Q30','Q58','Q68','Q72','Q90','Q95');
$iden=array('Q25','Q36','Q50','Q62','Q83','Q86','Q92');
$jobs=array('Q28','Q44','Q51','Q61','Q87','Q95');

$a=&$comm;
	foreach ($a as $qn)
	{
	compute_org($qn);
	}
}

compute_dimension($comm);

However, I'd like to pass the array values to $a using the function.

Any ideas? This has been driving me batty all day, and would appreciate any help I can get!

Thanks a bunch!

[bradgrafelman]

In your first coding snippet, you never define $comm[/bb], so you're essentially running compute_dimension(NULL) ... which, obviousy, if you try to foreach() NULL... well, you'll get the invalid argument error.

[Sherrie]

bradgrafelman,

Thank you for your reply! I see what you mean now!

But how and where would I need to define $comm? I already defined it in the function, and just tried setting it as a global variable but it still didn't work.

Any suggestions on how to write the function in a better way?

Appreciate your help!

[bradgrafelman]

Well... how are you planning on using this function? You define four arrays inside of the function... are these the only four arrays you ever plan on using? If so, I would say do something like:

function compute_dimension($array_name='') { 

$arrays = array();
$arrays['comm']=array('Q1','Q3','Q45','Q46','Q53','Q71','Q73'); 
$arrays['cust']=array('Q4','Q9','Q11','Q21','Q30','Q58','Q68','Q72','Q90','Q95'); 
$arrays['iden']=array('Q25','Q36','Q50','Q62','Q83','Q86','Q92'); 
$arrays['jobs']=array('Q28','Q44','Q51','Q61','Q87','Q95'); 

if(!isset($arrays[$array_name])) {
	echo 'compute_dimension must be given a valid array name!';
	return FALSE;
} else {
	$a = $arrays[$array_name];
}

// rest of function...
}

compute_dimension('comm');

[Sherrie]

Thanks for your quick reply! It's most appreciated.

That worked like a charm.. thanks a bunch!

[Sherrie]

I'm trying to nest one foreach loop inside another, but what i've got so far doesn't seem to be working... Any ideas?

function compute_demodimension($array_name='',$array2_name='') 
{ 
    $arrays = array(); 
    $arrays['comm']=array('Q1','Q3','Q45','Q46','Q53','Q71','Q73','Q80'); 
    $arrays['cust']=array('Q4','Q9','Q11','Q21','Q30','Q58','Q68','Q72','Q90','Q94'); 
    $arrays['iden']=array('Q25','Q36','Q50','Q62','Q83','Q86','Q92'); 
    $arrays['jobs']=array('Q28','Q44','Q51','Q61','Q87','Q95'); 
	$arrays['lead']=array('Q16','Q31','Q33','Q38','Q40','Q42','Q43','Q64','Q67','Q74','Q85','Q88','Q96'); 
    $arrays['over']=array('Q8','Q10','Q26','Q29','Q34','Q56','Q60','Q81'); 
	$arrays['plan']=array('Q2','Q6','Q17','Q19','Q35','Q37','Q49','Q79','Q91'); 
    $arrays['rewa']=array('Q7','Q13','Q14','Q48','Q69','Q77','Q78','Q84'); 
    $arrays['staf']=array('Q18','Q54','Q59','Q76','Q82'); 
	$arrays['trai']=array('Q15','Q22','Q32','Q55','Q57','Q66','Q70','Q75'); 
    $arrays['visi']=array('Q23','Q27','Q47','Q52'); 
    $arrays['work']=array('Q5','Q12','Q20','Q24','Q39','Q41','Q63','Q65','Q89','Q93'); 
	$arrays['age']=array('1','2','3','4','5');
	$arrays['los']=array('1','2','3','4','5');
	$arrays['education']=array('1','2','3','4','5','6','7');
	$arrays['eecat']=array('1','2');
	$arrays['sex']=array('1','2');
	$arrays['division']=array('1','2','3','4');
	$arrays['dept']=array('1','2','3','4','5','6','7','8');
	$arrays['section']=array('1','2','3','4','5','6','7','8','9','10','11','12');

    $a = $arrays[$array_name]; 
	foreach ($a as $qn)
	{
		$b=$arrays[$array2_name];
		foreach ($b as $value)
		{
			$demo=$arrays[$array2_name];
			compute_demo($qn,$demo,$value);
		}
	}

	echo $_SESSION['nolos1Q1'];
	echo "<br>";
	echo "<br>";
}

The queries can't be executed.

Appreciate any help!

[bradgrafelman]

Any chance you can explain in words what you're trying to do here (each step of the way) ?

EDIT: By the way, I've unmarked this thread as "RESOLVED" for you.

[Sherrie]

bradgrafelman,

Thank you for your reply.

Ok, firstly, I'd like the loop to check the dimension (e.g. comm, lead, cust, etc) to get the relevant questions. Then for each question based on the values in the array in demo required (e.g. age, los, division, dept, etc), to run the function compute_demo which requires the arguments $qn, $demo and $value.

Hope I made some sense?

Also, thank you for unmarking this thread as resolved.