[RESOLVED] My PHP Script

philfrompa

I created a yahtzee game in flash a few years back, and use a php script and sql to pass the scores back and forth.

Everything worked fine for those few years, but now I have noticed that the script has not worked for a while not. I thought at first something changed in flash. But I have narrowed it down to the php script.

I have three sections in the script:

<?php

if ($action=="html")

code

if ($action=="get")

code

if ($action=="add")

code

I pass the variable in the html call to the php script:
http://www. soandso.com/scores.php?action=get, or add, depending on what I wanted done.

If I eliminate the if code, and just call the code, the sql code works fine.

Did something change in php to make these if calls not work?

Thanks in advance for any advice,
Phil

NogDog

Looks like your script depended on register_globals being turned on (and now you're seeing why that's not a good thing to depend on 😉 ). Just reference the $GET super-global, and I suspect you'll be OK:

<?php
$action = $_GET['action'];
if ($action=="html") {
// ...etc....

bradgrafelman

Of course, doing something like that would spit out parse errors, so you might instead what to do something like:

$action = (isset($_GET['action']) ? $_GET['action'] : '');

NogDog

bradgrafelman wrote:
Of course, doing something like that would spit out parse errors, so you might instead what to do something like:
$action = (isset($_GET['action']) ? $_GET['action'] : '');

Just to be pedantic, that would avoid the potential for run-time notices (which is a good thing, mind you). However, it doesn't really have anything to do with "parse errors", though: the code would parse corretly regardless of whether or not $GET['action'] is set or not, and only "spit out" a notice if $GET['action'] is not set. :p

But I agree that Brad's code is more robust and therefore better; I just have too much time on my hands at the moment. (Hopefully I'll get an approval on one or more of the quotes I sent out last week and have some work to do soon!)

bradgrafelman

Hehe, my bad. I had just finished reading a thread about parse errors, so they were naturally on my mind at the time of writing that post.

philfrompa

NogDog wrote:
Looks like your script depended on register_globals being turned on (and now you're seeing why that's not a good thing to depend on 😉 ). Just reference the $GET super-global, and I suspect you'll be OK:
<?php
$action = $_GET['action'];
if ($action=="html") {
// ...etc....

That did the trick. Thanks a million.

Phil

philfrompa

NogDog wrote:
Looks like your script depended on register_globals being turned on (and now you're seeing why that's not a good thing to depend on 😉 ). Just reference the $GET super-global, and I suspect you'll be OK:
<?php
$action = $_GET['action'];
if ($action=="html") {
// ...etc....

This part of the script now works fine, but I also have an Update sections that does not work. This Update script used to work fine also and stopped at the same time as the Get script.

Could this be because of the same problem as above with the register_globals? Below is the script:

<?php

include "mygameinc.php";

    {

            $sql = "UPDATE $dbTable SET name='".$name."',score='".$score."' WHERE id='".$id."'";
            echo $sql;
              $result = mysql_query($sql);

              /*if ($notify){
                    mail($notify,"new high score added ",$name."\n".$score,"");
            }*/ //commented out while testing.

    }

I really apprectiate the help in getting the Get script working and welcome any suggestions for the update script.

Thanks again,
Phil

bradgrafelman

philfrompa wrote:
Could this be because of the same problem as above with the register_globals?

Here's an easy way to answer your own question:

Look at the variables used in your query... $name, $socre, etc. etc. Where in your code did you specifically assign a value to those variables? If the answer is 'nowhere', then where are these variables supposed to magically come from? Well, if you're expecting the data to come from a form or from the query string, then yes, your code was depending upon register_globals to magically create the variables for you.