MySQL Insert not working in PHP Code?!

[duckduckgoose]

Gah! I can't for the life of me figure out why this isn't working. From within a while statement, I'm trying to insert records into a db.

while ($row = mysql_fetch_array($result, MYSQL_ASSOC)) {

  $ins = "INSERT INTO temp (product_id, quantity, sessionid, price, shipping, description) VALUES ('".$row['product_id']."', '".$_SESSION['cart'][$row['product_id']]."', '".$sessnum."', '".$row['product_price']."', '".$row['shipping_cost']."', '".$row['product_desc']."')";

  $res = mysql_query($ins);

....
}

If I echo $ins, I get a good query:

INSERT INTO temp (product_id, quantity, sessionid, price, shipping, description) VALUES ('1345', '1', 'gt4qe3cv1vpkz9akt9trnnlat7', '129', '9', 'TSHIRT - Blue/Green - SMALL')

In fact, if I copy and paste this query at the mysql prompt, it works fine. But it doesn't work when the script runs. Nothing is inserted into my table. I did:

if($res) {
  echo 'fine';
} 

And it printed 'fine' to the screen. I don't understand what's happening. I checked all of the syntax, etc., but it's not working. Help!

[severeheadache]

Can you be more specific, other than it "does not work". Is it a PHP parse error? MySQL error? I am assuming by the context that it is a MySQL error (since you can echo things out), so can you share the MySQL error so we can see if we might be able to help.

-Mike

[ClarkF1]

Try

$res = mysql_query($ins) or die('Error '.mysql_error().' with query ".$ins);

[coldfused]

third line down theirs a mistake:

$row['product_id']]

should be

$row['product_id']

and in development, like the above mentioned you should always use mysql_error() to find out what went wrong, as it will give you information about what went wrong in your code faster than posting on forums.

so:
$query = "INSERT a INTO b AND so forth";
$result = @($query) or die("There was a problem:".mysql_error());

[severeheadache]

coldfused wrote:

third line down theirs a mistake:

$row['product_id']]

should be

$row['product_id']

No, actually that is correct he is embedding the value of 1 array as the key of another, the whole line is:

$_SESSION['cart'][$row['product_id']]

Which spaced out is:

$_SESSION['cart'][ $row['product_id'] ]

That is valid syntax. Please post the MySQL error.

I agree with the others, use the "OR" syntax but simply using a DIE is usually bad programming practice. Instead return a boolean false so your application can handle it gracefully. IF you are using PHP5, throw an exception. I visit so many pages where the server gets overloaded and the user is presented with these die statements. Instead, throw an exception, have the code catch it and redirect to a "server busy" static page. This is important because hackers often will DDOS your box until it pukes these messages and often it tells them the table, the fields, etc that are in your DB. Why expose that?

do this:

$res = @mysql_query($ins) or false;

if ( ! $res )
{
     // If you do not have exceptions you could write out a graceful message:
    echo 'My apologies, the db is currently down. Please try back later';

// Write a meaningful message to the error_log:
error_log( '=======================================' );
error_log( 'QUERY ERROR:' );
error_log( 'Error #: ' . mysql_errorno() );
error_log( 'Query  : ' . mysql_error() );
error_log( '=======================================' );

// If you must die, then do it here, note, if you are including scripts, a
// die here will not necessarily kill your running script.
 die();
}

Please note the "@" before the mysql_query. This will suppress the errors to the screen so it does not look to the user like your script barfed on them. You can remove this in debugging if you want the errors.

I know I did not solve the problem, I am waiting for more information as I posted earlier.

Sorry to rant about that.