[RESOLVED] in_array $_FILES and help with if...else statement

[SpecialFX]

This function is to preview an entry before it is submitted, my problem is when I'm uploading more than 1 new photos to a past (edited) entry (that is the only time it delves into the if statement). The line with the if statement containing the in_array function like it is will produce only the side that is uploading a new image with $temp_uploads variable. However if I inverse it to '!== false' then it only gets all the ones from the db, no matter how many times it's looped. I need it to work like it should and actually use the if...else statement.

function preview($page, $edit_id) {
  		global $db, $temp_uploads, $uploads;

	$table  = $db.$page;
	$fields = array_merge($_POST, $_FILES);
    $preview_form .= '<div class="white"></br><form enctype="multipart/form-data" action="?p='.$page.'&z=s&i='.$edit_id. '" method="post"><table class="preview" align="center">';

	//loop through each field in the array
	foreach($fields as $field => $value){
		//if field's value has something special that needs to be done to it EX. upload an image.
		if (strpos($field, "|") !== false) {
			require_once('extra.php');
			list($possible, $detail) = explode("|", $field);
			$field = $possible;
			if (strpos($detail, ";") !== false){
				$get_details = explode(";", $detail);
				//select field from table with id number from select input
				if($get_details[0] == 'Fetch_select'){
					$detail = 'id'.substr($detail, 12);					
					$fetch = detail('Fetch_preview', $detail, $value, $page, $header=false, $row['id']);
					$preview_form .= '<tr><td><strong>'.format($field).':</strong></br>'.$fetch.'</td></tr><input type="hidden" value="'.$value.'" name="'.$field.'" />';	
				}
			}
			//upload a tmp image on a new entry (no id)
			if(($detail == "Upload_tmp") && (!is_numeric($edit_id))){ 
  				$value = detail($detail, $field."|".$detail, $field, $page, null, $edit_id);
				$preview_form .= '<tr><td><strong>'.format($field).':</strong></br>';
				if($value !=''){
					$preview_form .= '<img src="'.$temp_uploads.$value.'" /><input type="hidden" value="'.$value.'" name="'.$field.'|'.$detail.'_move" />';
				}
				$preview_form .= '</td></tr>';
			//upload new image to a past entry (editing with id)
			} else if(($detail == "Upload_tmp") && (is_numeric($edit_id))){
				$table 			  = $db.$page;
				$get   			  = @mysql_query('SELECT '.$field.' FROM `'.$table.'` WHERE `id` = '.$edit_id.' LIMIT 1');
				$num   			  = @mysql_num_rows($get);
				$row   			  = @mysql_fetch_array($get);
				$edit_image 	  = $row[$field];
				$edit_image_short = substr($edit_image, 41);
				$preview_form .= '<tr><td><strong>'.format($field).':</strong></br>';
				//check whether field from db is being posted if it isn't then upload it
				if((in_array($edit_image_short, $_FILES)) === false){
					$value = detail($detail, $field."|".$detail, $field, $page, null, $edit_id);
					if($value !=''){
						$preview_form .= '<img src="'.$temp_uploads.$value.'" /><input type="hidden" value="'.$value.'" name="'.$field.'|'.$detail.'_move" />';
					}
				//else show already uploaded image
				} else {
					if($edit_image !=''){
						$preview_form .= '<img src="'.$uploads.$edit_image.'" /><input type="hidden" value="'.$edit_image.'" name="'.$field.'" />';
					}
				}
				$preview_form .= '</td></tr>'; 
			}
		} else {
        	$preview_form .= '<tr><td><strong>'.format($field).':</strong></br>'.stripslashes($value);
			if($field == 'date'){
  				$value = strtotime($value);
  			}
			$preview_form .= '<input type="hidden" value="'.stripslashes($value).'" name="'.$field.'" /></td></tr>';
        }
		//store incase of editing
		$_SESSION[$field] = stripslashes($value);

		unset($search);
		unset($edit_image);
		unset($edit_image_short);
    }
    $preview_form .= '<tr><td><input type="submit" value="Submit Entry" />';
	$preview_form .= '<input type="button" value="Edit" OnClick="window.location.href=\'?p='.$page.'&z=e&i='.$edit_id.'&pv=y\'" /></td></tr>';
 	$preview_form .= '</table></form></br></div>';
    echo $preview_form;
}

[banzaimonkey]

Hm. Well, there's another conditional inside the else statement. Let's figure out which one's failing.

if((in_array($edit_image_short, $_FILES)) === false)
{
  echo 'if';
  $value = detail($detail, $field."|".$detail, $field, $page, null, $edit_id);
  if($value !='')
  {
    echo 'if + if';
    $preview_form .= '<img src="'.$temp_uploads.$value.'" /><input type="hidden" value="'.$value.'" name="'.$field.'|'.$detail.'_move" />';
  }
  //else show already uploaded image
}
else
{
  echo 'else';
  if($edit_image !='')
  {
    echo 'else + if';
    $preview_form .= '<img src="'.$uploads.$edit_image.'" /><input type="hidden" value="'.$edit_image.'" name="'.$field.'" />';
  }
}

If you add the echo lines you can see which conditionals are failing. It's possible that else is actually being executed, but the conditional inside that else fails the truth check. Alternatively, it's possible that the first if is true, but the conditional inside that one is not.

[SpecialFX]

If I don't upload anynew images and just submit it doesn't get the images from the db, and only comes back as 'if', however, if I upload a new image that particular field comes back as the 'if + if' properly, but again all the other fields are 'if' when they should be 'else + else'.

[bradgrafelman]

SpecialFX and I discussed this outside of the forums, and I believe I found the problem (or at least one of the problems, if there are more):

The "edit" routine involved displaying the same form shown when creating a new entry, with the addition of pre-filling all of the values of the HTML form elements with the data from the entry. When it came to the uploaded images, the code attempted to slip the old file name into a "value" attribute for the INPUT element, which is not allowed of course (would be a security exploit - browsers dont let you touch that type of INPUT element since it uploads data from the client's computer).

Suggested he add a hidden INPUT element with the old file name and checking for that instead.

Hope this helps!

EDIT: Yep, it's sorted now. Marking this one resolved...