Do I need a JOIN statement for this to work

dcjones

Hi all,

I have 2 tables

table1 and table2

I want to be able to extract all the date form both tables, this is what I have

SELECT table1.,table2.
FROM table1, table2
WHERE table1.member_id = member_id
AND
table2.id = id

Do I need some sort of JOIN statement, if so where do I start.

Roger_Ramjet

You already have a join: it is the comma between the tables. This produces a Cartesian join where every row is joined to every row in the second table. That is modified by your WHERE condition and produces the results you need.

Personally, I hate to see that, I feel it is just lazy coding. It also will not work on other databases. Now I don't know if writing queries that way causes the query parser to do extra work or not. My feeling is that being explicit about JOINs cannot hurt but may sometimes help. Certainly it means that your habitual sql coding style will not trip you up when you work with other databases.

Explicit Join:

SELECT table1.*,table2.*
FROM table1 INNER JOIN table2 ON table1.member_id = table2.member_id

Not sure about your table structure so the join condition may be wrong.

dcjones

Hi and thanks again for your reply, I am learning fast.

I have this

SELECT table1., table2.
FROM table1 JOIN table2
WHERE table1.member_id = 1337987 AND table2.id = 4

And when I run the query(replacing the =1337987 and =4 with variables) I get the correct results, but when I append my url I get no data.

The url looks like this:

http://mydomain/bag/agents/agent_results_report_fullrecord.php?member_id=1337988$id=4

I know you don't like my SQL but it does work. I tried the code you kindly posted but it did not work.

Can you advise please.

Roger_Ramjet

http://mydomain/bag/agents/agent_results_report_fullrecord.php?member_id=1337988&id=4

Roger_Ramjet

As I said, I don't know your table structure so I don't know the column names to join on, my code was only for example.