[RESOLVED] Submit wont link to next page

[Ambo]

I have written this as an answer to some other major issues I had with another form I was trying...
The problem now is, If a required field left empty...it links to this page..."ALL GOOD"
But when the 'Submit' button is clicked, the page goes white and doesn't show the page reqested...

Where have I gone wrong?? 😕

<?

if (!$who) {include("http://xxxxxxxxxxxxxxxxxx/~xxxxxxxxxxx/required.php"); exit; } else {

if (!$email) {include("http://xxxxxxxxxxxxxxxxxx/~xxxxxxxxxxx/required.php"); exit; } else {

if (!$spam) {include("http://xxxxxxxxxxxxxxxxxx/~xxxxxxxxxxx/required.php"); exit; } else {

if (!$comment) {include("http://xxxxxxxxxxxxxxxxxx/~xxxxxxxxxxx/required.php"); exit; } else {

if (submit == "true") {include("http://xxxxxxxxxxxxxxxxxx/~xxxxxxxxxxx/contactaccept.php"); exit; } else {

mail("[e-mail]",  "XXXX.XXX = Contact Form", "

Contact Name:           $sal. $who  ,
Email Address: 		  	$email ,
Address: 				$street1 ,
Address: 				$suburb, 
Address: 				$state, $postcode, 
Home: 				  	$phone1 ,
Mobile: 				$phone2 ,
Type of contact;		[ $type ] 
============================================
Comments: 				$comment
============================================
");

}

}

}

}

}

?>

Help greatly appreciated

[suntra]

Where do the variables $who, $email, $spam, $comment, $submit come form ? Are they from a form (method = post) ? Yes ? You should use $POST['variable_name'] like $POST['who'].

Also, what is the constant "submit" ? You wrote « if(submit==true) », no " $ " ! If submit is simply defined in the posted form, it won't be equal to true (a boolea value), but since you use '==' it should be alright.

Now, you should simplify your code !

if(!$_POST['who'] ||!$_POST['email'] ||!$_POST['spam'] ||!$_POST['comment']) {
    include("http://xxxxxxxxxxxxxxxxxx/~xxxxxxxxxxx/required.php");
    exit();
}
if($_POST['submit']) { // ??
    include("http://xxxxxxxxxxxxxxxxxx/~xxxxxxxxxxx/contactaccept.php");
    exit();
}
// email code...

[Ambo]

Suntra...thank you quick reply..

<?

if(!$_POST['who'] ||!$_POST['email'] ||!$_POST['spam'] ||!$_POST['comment']) { 
    include("http://xxxx.xxxxxx.xxx.xx/~xxxxxxxxxxx/required.php"); 
    exit(); 
}
if($_POST['submit']) { //??  <<<---all my email stuff to go here???
mail("[e-mail]",  "XXXX.XXX = Contact Form", 
"Contact Name:           $sal. $who  , 
Email Address:           $email , 
Address:                 $street1 , 
Address:                 $suburb, 
Address:                 $state, $postcode, 
Home:                    $phone1 , 
Mobile:                  $phone2 , 
Type of contact;        [ $type ] 
============================================ 
Comments:                 $comment 
============================================ 
");  

    include("http://xxxx.xxxxxx.xxx.xx/~xxxxxxxxxxx/contactaccept.php"); 
    exit(); 
} 

?>

Is this what you mean???

As I'm very knew to making stuff with php...I had to write it out 'long-hand' as before...so I get an idea of what is going on. 🙂

The way it is layed out here the...include("http://xxxx.xxxxxx.xxx.xx/~xxxxxxxxxxx/required.php"); ...show up as before. But the...include("http://xxxx.xxxxxx.xxx.xx/~xxxxxxxxxxx/contactaccept.php");...wont.just goes to white.

[suntra]

You wrote this in your first post :

if (submit == "true") {include("http://xxxxxxxxxxxxxxxxxx/~xxxxxxxxxxx/contactaccept.php"); exit; }

what is "submit" ? The way it is written means that it is a constant, but I doubt it is. Where is "submit" (or $submit ?) defined ? In the posted form, in PHP (but not shown to save some space), ... ?

[Ambo]

Suntra...Please excuse my daft...

The submit...isn't that what happens when the user clicks the "submit button"...or have I just shown how absolute little I know about this stuff 😉

[Ambo]

Hmmm..thank you santra. With you not fixing it for me I hae been able to realize how blind I was...after a couple of coffees and a walk about..all solved.

I didn't have to assign anytthing other than...

<?

if(!$_POST['who'] ||!$_POST['email'] ||!$_POST['spam'] ||!$_POST['comment']) { 
    include("http://xxxx.xxxxxx.xxx.xx/~xxxxxxxxxxx/required.php"); 
    exit(); 
}

include("http://xxxx.xxxxxx.xxx.xx/~xxxxxxxxxxx/contactaccept.php"); 


mail("[e-mail]",  "XXXXX.COM = Contact Form", 
"Contact Name:           $sal. $who  , 
Email Address:           $email , 
Address:                 $street1 , 
Address:                 $suburb, 
Address:                 $state, $postcode, 
Home:                    $phone1 , 
Mobile:                  $phone2 , 
Type of contact;        [ $type ] 
============================================ 
Comments:                 $comment 
============================================ 
"); 


?>

Thank for showing me how to 'tidy-up' my work as well...Your input has been appreciated.
Cheers
Matt