Call to a member function getNumMembers() on a non-object

Tezread

I am getting an error message which is most irrititating as the script works on other projects:

Fatal error: Call to a member function getNumMembers() on a non-object in /var/www/vhosts/mindseyemidlands.co.uk/httpdocs/icommission/client2.php on line 265

here is my code - you will notice that the form is supposed to show only if the user is logged on.

<?php
include("include/session.php");
$_SESSION['formdata1']=''; 
$username = $_SESSION['username']; 
include("connect.php"); 

// query 
$sql = "SELECT * FROM client WHERE username = '".$username."'"; 
$result = mysql_query($sql); 
// if we have rows, fetch them & prepopulate the form
if(mysql_num_rows($result) > 0) { 
   $row = mysql_fetch_array($result); 
} else { 
   $row = array('client'=>'','organisation'=>'','address1'=>'','address2'=>'','town'=>''
   ,'postcode'=>'' ,'telephone'=>'','email'=>'','website'=>'','comments'=>'');
} 
?> 
<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Transitional//EN" "DTD/xhtml1-transitional.dtd"><html><!-- InstanceBegin template="/Templates/template.dwt" codeOutsideHTMLIsLocked="false" --><head><title>icommission</title>

<meta http-equiv="Content-Type" content="text/html; charset=iso-8859-1" /></head>
<body>
<div id="banner">
  <h1 align="center"><img src="logo.jpg" alt="icommission" width="575" height="118" /></h1>
</div>
<div id="navigation"><table width="600" border="0">
  <tr>
    <td width="345"><div align="left"><a href="client.php">Client</a></div></td>
    <td width="345"><div align="left"><a href="serviceprovider.php">Service Provider </a></div></td>
    </tr>
</table>
</div>
<div id="centercontent">
<!-- InstanceBeginEditable name="edit1" -->

<table>
<tr><td>

<?php
/**
 * User has already logged in, so display relavent links, including
 * a link to the admin center if the user is an administrator.
 */
if($session->logged_in){
   echo "<h1>Logged In</h1>";
   echo "Welcome <b>$session->username</b>, you are logged in. <br><br>"
       ."[<a href=\"userinfo.php?user=$session->username\">My Account</a>] &nbsp;&nbsp;"
       ."[<a href=\"useredit.php\">Edit Account</a>] &nbsp;&nbsp;";
   if($session->isAdmin()){
      echo "[<a href=\"admin/admin.php\">Admin Center</a>] &nbsp;&nbsp;";
   }
   echo "[<a href=\"process.php\">Logout</a>]";
   ?>
<form name="form1" id="form1" method="post" action="client_formhandler.php">
<table width="500" border="0">
 <tr>
 <td>Client name</td>
<td>
 <input name="client" type="text" id="client" value="<?=$row['client']?>" size="40"></td>
  </tr>
    <tr>
      <td>Organisation</td>
      <td><input name="organisation" type="text" id="organisation" value="<?=$row['organisation']?>" size="40"></td>
      </tr>
    <tr>
      <td>Address1</td>
      <td><input name="address1" type="text" id="address1" value="<?=$row['address1']?>" size="40"></td>
      </tr>
    <tr>
      <td>Address2</td>
      <td><input name="address2" type="text" id="address2" value="<?=$row['address2']?>" size="40"></td>
      </tr>
    <tr>
      <td>Town</td>
      <td><input name="town" type="text" id="town" value="<?=$row['town']?>" size="40"></td>
      </tr>
    <tr>
      <td>Postcode</td>
      <td><input name="postcode" type="text" id="postcode" value="<?=$row['postcode']?>" size="40"></td>
      </tr>
    <tr>
      <td>Telephone </td>
      <td><input name="telephone" type="text" id="telephone" value="<?=$row['telephone']?>" size="40" /></td>
    </tr>
    <tr>
      <td>Email</td>
      <td><input name="email" type="text" id="email" value="<?=$row['email']?>" size="40"></td>
      </tr>
    <tr>
      <td>Website</td>
      <td><input name="website" type="text" id="website" value="<?=$row['website']?>" size="40"></td>
      </tr>
    <tr>
      <td>Comments</td>
      <td><input name="comments" type="text" id="comments" value="<?=$row['comments']?>" size="40"></td>
      </tr>
    <tr>
      <td colspan="2">&nbsp;</td>
      </tr>
    <tr>
      <td>Click submit </td>
      <td><input type="submit" name="submit" value="submit" /></td>
      </tr>
    <tr>
      <td colspan="2">&nbsp;</td>
      </tr>
  </table>
</form>

<?php

}

else	{

echo '<h1>Login</h1>';

/**
 * User not logged in, display the login form.
 * If user has already tried to login, but errors were
 * found, display the total number of errors.
 * If errors occurred, they will be displayed.
 */
if($form->num_errors > 0){
   echo "<font size=\"2\" color=\"#ff0000\">".$form->num_errors." error(s) found</font>";
}
?>

<form action="process.php" method="post">
<table align="left" border="0" cellspacing="0" cellpadding="3">
<tr><td>Username:</td><td><input type="text" name="user" maxlength="30" value="<? echo $form->value("user"); ?>" /></td><td><? echo $form->error("user"); ?></td></tr>
<tr><td>Password:</td><td><input type="password" name="pass" maxlength="30" value="<? echo $form->value("pass"); ?>" /></td><td><? echo $form->error("pass"); ?></td></tr>
<tr><td colspan="2" align="left"><input type="checkbox" name="remember" <? if($form->value("remember") != ""){ echo "checked"; } ?> />
<font size="2">Remember me next time &nbsp;&nbsp;&nbsp;&nbsp;
<input type="hidden" name="sublogin" value="1" />
<input type="submit" value="Login" /></td></tr>
<tr><td colspan="2" align="left"><br /><font size="2">[<a href="forgotpass.php">Forgot Password?</a>]</font></td><td align="right"></td></tr>
<tr><td colspan="2" align="left"><br />Not registered? <a href="register.php">Sign-Up!</a></td></tr>
</table>
</form>

<?php
}

echo "</td></tr><tr><td align=\"center\"><br><br>";
echo "<b>Member Total:</b> ".$database->getNumMembers()."<br>";
echo "There are $database->num_active_users registered members and ";
echo "$database->num_active_guests guests viewing the site.<br><br>";

include("include/view_active.php");
?>

</td></tr>
</table>


<!-- InstanceEndEditable -->

</div>

</body>
<!-- InstanceEnd --></html>

any help greatly appreciated as always. I see one isse I may have is the way I am echoing the form.

<?php
/**
 * User has already logged in, so display relavent links, including
 * a link to the admin center if the user is an administrator.
 */
if($session->logged_in){
   echo "<h1>Logged In</h1>";
   echo "Welcome <b>$session->username</b>, you are logged in. <br><br>"
       ."[<a href=\"userinfo.php?user=$session->username\">My Account</a>] &nbsp;&nbsp;"
       ."[<a href=\"useredit.php\">Edit Account</a>] &nbsp;&nbsp;";
   if($session->isAdmin()){
      echo "[<a href=\"admin/admin.php\">Admin Center</a>] &nbsp;&nbsp;";
   }
   echo "[<a href=\"process.php\">Logout</a>]";
   ?>
<form name="form1" id="form1" method="post" action="client_formhandler.php">
<table width="500" border="0">
 <tr>
 <td>Client name</td>
<td>
 <input name="client" type="text" id="client" value="<?=$row['client']?>" size="40"></td>
  </tr>

how else can I echo it other than echoing the login script, closing with ?> then showing the form fields

Trouble is I want to prepopulate the form hence the value is displayed thus

NogDog

Where do you instantiate the object $database? If you don't, then that's the problem. (I did a search for the word "new" in your code, and don't see it anywhere.)

Tezread

check out this script - main.php which has no error messages:

<?
include("include/session.php");
?>

<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Transitional//EN" "DTD/xhtml1-transitional.dtd"><html><!-- InstanceBegin template="/Templates/template.dwt" codeOutsideHTMLIsLocked="false" --><head><title>icommission</title>

<style type="text/css">
	@import "all.css"; /* just some basic formatting, no layout stuff */

body {
margin:10px 10px 0px 10px;
padding:0px;
background-color: #990000;
margin-left: 12px;
margin-top: 12px;
margin-right: 12px;
	}

#leftcontent {
	position: absolute;
	left:10px;
	top:50px;
	width:200px;
	background:#fff;
	border:1px solid #000;
	}

#centercontent {
	background:#fff;
	margin-left: 10px;
	margin-right:10px;
	border:1px solid #000;
	/*
	IE5x PC mis-implements the box model. Because of that we sometimes have
	to perform a little CSS trickery to get pixel-perfect display across browsers.
	The following bit of code was proposed by Tantek Celik, and it preys upon a CSS
	parsing bug in IE5x PC that will prematurly close a style rule when it runs
	into the string "\"}\"". After that string appears in a rule, then, we can override
	previously set attribute values and only browsers without the parse bug will
	recognize the new values. So any of the name-value pairs above this comment
	that we need to override for browsers with correct box-model implementations
	will be listed below.

	We use the voice-family property because it is likely to be used very infrequently,
	and where it is used it will be set on the body tag. So the second voice-family value 
	of "inherit" will override our bogus "\"}\"" value and allow the proper value to
	cascade down from the body tag.

	The style rule immediately following this rule offers another chance for CSS2
	aware browsers to pick up the values meant for correct box-model implementations.
	It uses a CSS2 selector that will be ignored by IE5x PC.

	Read more at http://www.glish.com/css/hacks.asp
	*/

	voice-family: "\"}\"";
	voice-family: inherit;
	margin-left: 201px;
	margin-right:201px;
	}

		#navigation {
	background:#CCCCCC;
	margin-left: 199px;
	margin-right:199px;
	margin-top: 30px;
	border:1px solid #000;
	}
html>body #centercontent {
	margin-left: 201px;
	margin-right:201px;
	}

#rightcontent {
	position: absolute;
	right:10px;
	top:50px;
	width:200px;
	background:#fff;
	border:1px solid #000;
	}

#banner {
	background:#fff;
	height:40px;
	border-top:1px solid #000;
	border-right:1px solid #000;
	border-left:1px solid #000;
	voice-family: "\"}\"";
	voice-family: inherit;
	height:39px;
	}
html>body #banner {
	height:39px;
	}

p,h1,pre {
	margin:0px 10px 10px 10px;
	}

h1 {
	font-size:14px;
	padding-top:10px;
	}

#banner h1 {
	font-size:14px;
	padding:10px 10px 0px 10px;
	margin:0px;
	}

#rightcontent p {
	font-size:10px
	}

body,td,th {
	font-family: Arial, Helvetica, sans-serif;
}
.style1 {font-size: 36px}
</style>
<meta http-equiv="Content-Type" content="text/html; charset=iso-8859-1" /></head>
<body>
<div id="banner">
  <h1 align="center"><img src="logo.jpg" alt="icommission" width="575" height="118" /></h1>
</div>
<div id="navigation"><table width="600" border="0">
  <tr>
    <td width="345"><div align="left"><a href="client.php">Client</a></div></td>
    <td width="345"><div align="left"><a href="serviceprovider.php">Service Provider </a></div></td>
    </tr>
</table>
</div>
<div id="centercontent">
<!-- InstanceBeginEditable name="edit1" -->

<table>
<tr><td>


<?
/**
 * User has already logged in, so display relavent links, including
 * a link to the admin center if the user is an administrator.
 */
if($session->logged_in){
   echo "<h1>Logged In</h1>";
   echo "Welcome <b>$session->username</b>, you are logged in. <br><br>"
       ."[<a href=\"userinfo.php?user=$session->username\">My Account</a>] &nbsp;&nbsp;"
       ."[<a href=\"useredit.php\">Edit Account</a>] &nbsp;&nbsp;";
   if($session->isAdmin()){
      echo "[<a href=\"admin/admin.php\">Admin Center</a>] &nbsp;&nbsp;";
   }
   echo "[<a href=\"process.php\">Logout</a>]";
}
else{
?>

<h1>Login</h1>
<?
/**
 * User not logged in, display the login form.
 * If user has already tried to login, but errors were
 * found, display the total number of errors.
 * If errors occurred, they will be displayed.
 */
if($form->num_errors > 0){
   echo "<font size=\"2\" color=\"#ff0000\">".$form->num_errors." error(s) found</font>";
}
?>
<form action="process.php" method="post">
<table align="left" border="0" cellspacing="0" cellpadding="3">
<tr><td>Username:</td><td><input type="text" name="user" maxlength="30" value="<? echo $form->value("user"); ?>" /></td><td><? echo $form->error("user"); ?></td></tr>
<tr><td>Password:</td><td><input type="password" name="pass" maxlength="30" value="<? echo $form->value("pass"); ?>" /></td><td><? echo $form->error("pass"); ?></td></tr>
<tr><td colspan="2" align="left"><input type="checkbox" name="remember" <? if($form->value("remember") != ""){ echo "checked"; } ?> />
<font size="2">Remember me next time &nbsp;&nbsp;&nbsp;&nbsp;
<input type="hidden" name="sublogin" value="1" />
<input type="submit" value="Login" /></td></tr>
<tr><td colspan="2" align="left"><br /><font size="2">[<a href="forgotpass.php">Forgot Password?</a>]</font></td><td align="right"></td></tr>
<tr><td colspan="2" align="left"><br />Not registered? <a href="register.php">Sign-Up!</a></td></tr>
</table>
</form>

<?
}

/**
 * Just a little page footer, tells how many registered members
 * there are, how many users currently logged in and viewing site,
 * and how many guests viewing site. Active users are displayed,
 * with link to their user information.
 */
echo "</td></tr><tr><td align=\"center\"><br><br>";
echo "<b>Member Total:</b> ".$database->getNumMembers()."<br>";
echo "There are $database->num_active_users registered members and ";
echo "$database->num_active_guests guests viewing the site.<br><br>";

include("include/view_active.php");

?>


</td></tr>
</table>


<!-- InstanceEndEditable -->

</div>

</body>
<!-- InstanceEnd --></html>

NogDog

No evidence there of $database being instantiated, unless it's done in the "session.php" include file (which doesn't sound likely, based on the name). For the command $database->getNumMembers() to work, $database must be an object instantiated from a defined class via the [man]new[/man] keyword.