[RESOLVED] rtrim question

[zzz]

I have written a function that grabs data from my db and build an output. Each line connected with ;

function myFunction($db, $userID, $ExpArea) {

if ($v1 = $db->get_results("SELECT * FROM t1"))
{
foreach ($v1 as $v2 ) {
   echo stripslashes($v2 ->var)."; ";
}
}
}

Later I include this function into another loop on my page. However there's always that extra ; and I'm not sure how to get rid of it.

foreach ($myData as $key => $value) {
	$ExpArea = $key;
	ExperienceListSummary($db, $userID, $ExpArea);
}

My output looks something like:

asdas dasd; asdasdasd; asdasdasd; asdasdasd;

I need to get rid of the last ;

😕

[laserlight]

This is one (relatively inefficient) way of doing it:

function myFunction($db, $userID, $ExpArea) {
    if ($v1 = $db->get_results("SELECT * FROM t1"))
    {
        $items = array();
        foreach ($v1 as $v2)
        {
            $items[] = $v2->var;
        }
        echo implode("; ", $items);
    }
}

[kilo_dB]

The way I usually handle this is:

function myFunction($db, $userID, $ExpArea) {
     $sep = "";
      if ($v1 = $db->get_results("SELECT * FROM t1"))
    {
    foreach ($v1 as $v2 ) {
       echo $sep.stripslashes($v2 ->var);
       $sep = '; ';
    }
    }
} 

This just builds the result by concatenating, but the separator is null the first time it is used.
PS Why is this an rtrim question, rtrim just removes whitespace!

[laserlight]

This just builds the result by concatenating, but the separator is null the first time it is used.

The bad part is that the separator is being assigned on each iteration. It would be better to loop from the first to the second last row, but that requires one to know just how many rows are retrieved, which may also be slow or infeasible. In this case, your solution looks good to me.

Why is this an rtrim question, rtrim just removes whitespace!

I think zzz wanted to use the optional argument to rtrim() to trim off the semi-colon, but that will not work for printing the string right away.

[zzz]

Yes, I think I'll give it a whirl to kilo_dB's solution. And Yes, larerlight is right, I was thinking of stripping the ';' with rtrim but just could not figure out how to plug it...

Thanks a bunch both!

[zzz]

Just tried -- works perfect!