[RESOLVED] looping a form so I can go through and delete all values checked in form

numerical25

I have a page that loops out a list of products. beside each product is a check box to check if you want to delete it or not. On submit, I want to look through each product and delete whatever been checked. how would i go about looping through each value and deleting whatevers been checked

Piranha

Why would you want to go through each product, it seems like it is enough to go through the products that should be deleted. Post the form you have, it's easier to help you out with that.

numerical25

I want to loop through the form after its been submitted because if you got a 100 long list full of products. and you want to delete a few. How else can you find out which ones been checked, which ones havnt. I have my form in a loop. so a user could submit a form with 40 products, a user could submit a form with 100. it varies. there is no set limit on how many products will be submited and there is no limit on how many will be checked for deletion. here is my source

 <?php require_once('Connections/ok.php'); ?>
			<?PHP mysql_select_db($database_ok,$ok); ?>
			<?php $query="SELECT * FROM PRODUCTS";
			$results=mysql_query($query,$ok);?>
			<table width="489" border="0" cellpadding="0" cellspacing="0">
  <tr>
  	<td width="118" align="center">Make Store Front </td>
    <td width="78" align="center">Delete</td>
    <td width="221">Product Name</td>
    <td width="72">Price</td>
  </tr>
  <?php $numrows = mysql_num_rows($results); ?>
  <?php while ( $row = mysql_fetch_assoc($results)){ ?>
  <form action="admin.php?admin=4" method="post" name="info">
 <tr>
 	<td align="center"><input type="checkbox" name="storeFront[]" value="<?php $row['ProductID'];?>" /></td>
    <td align="center"><input type="checkbox" name="delete[]" value="<?php $row['ProductID'];?>" /></td>
    <td><a href="admin.php?admin=4&productID=<?php echo $row['ProductID'];?>"><?php echo $row['productName'];?></a></td>
    <td><?php echo sprintf('$%.2f',$row['productPrice']);?></td>
  </tr>
  <?php $numrows = --$numrows ?>
  <?php if ($numrows == 0) { ?>
  <tr>
  	<td>
		<input type="submit" name="submit" value="Update" />
	</td>
  </tr>	
  </form>
   <?php } ?>
  <?php }?>
</table>

take email for example. When you open your email. you get a big ass list of mail and beside is the delete button. you just check all the ones you want to delete and then press delete. i want that with this on submittion

Piranha

Only the checked checkboxes will submit their value, the other ones won't be submitted. Basically you can do something like this (pseudocode):

$comma_separated = implode(",", $_POST['delete']; // Will create a comma delimited string
$sql = "DELETE FROM table WHERE id IN ($comma_separated)"; // Will delete all of them in one query
$result = mysql_query($sql);

Note that you have to check for database injection, and possibly have other checks as well. I only intended to show you an example of how you can do it.

numerical25

what are database injections ??

and so basically when a form is submited, but is empty, then the form wont exist on the other page ?? or is that only for check boxes.
for a text box when you submit, it considers it to be there but empty on the next page. but for a checkbox, if you dont check it, then it wont even submit the check box on the next page????

Piranha

That is only for checkboxes and (I think but are not 100% sure) radio buttons. As you say, a text field will be submitted with an empty string. The easiest way to really understand this is to make a few tests, then you will see what is and what is not submitted.

About database injection or SQL injection (it's the same thing) you can read the article on PHPBuilder to understand what it is. The article explains it far better than I would be able to do.

numerical25

for some reason im getting a error with the implode function. here is my code below.

<?php if (isset($_POST['delete'])){ 
			require_once('Connections/ok.php');		
			mysql_select_db($database_ok,$ok);
			echo $_POST['delete']; // returns "1" 
			var_dump($_POST['delete']);// returns string(1) 
			$deletelist = implode(",", $_POST['delete']);
			$query = "DELETE FROM products WHERE productID = '{$deletelist}'";
			mysql_query($query,$ok);
			$Pstatus = "Product has been deleted";  }?>

this is the error i get

Warning: implode() [function.implode]: Bad arguments. in C:\www\apache\htdocs\admin.php on line 163

NOTE:

The values are there, I did a var_dump and it shows its there. I also echo it out and the it echos the delete array values. I dont know why its having failure with it. By the way, the values are integers, but im not sure if that has anything to do with it

Piranha

Strange, your code seems to work here. Anyway, here is another way to do it. Not as pretty, but it will make the job (or at least it does here):

	$test = "";
	foreach ($_POST['delete'] as $del)
	{
		$test .= $del . ", ";
	}
	$test = substr($test, 0, -2);
	echo $test;

numerical25

could it be that some function libraries are enabled or something ??

and for the code you just gave me, whats the subtraction function for ??

numerical25

still not working here is my code

<?php if (isset($_POST['delete'])){ 
			require_once('Connections/ok.php');		
			mysql_select_db($database_ok,$ok);
			echo $_POST['delete'];
			var_dump($_POST['delete']);
			$del = ""; 
    			foreach ($_POST['delete'] as $val) 
   					 { 
        				$del .= $val . ", "; 
   					 } 
   				 $test = substr($test, 0, -2); 
  			  echo $del;

		$query = "DELETE FROM products WHERE productID = '{$del}'";
		mysql_query($query,$ok);
		$Pstatus = "Product has been deleted";  }?>
<?php }?>

and the error message is

Warning: Invalid argument supplied for foreach() in C:\www\apache\htdocs\admin.php on line 164

Piranha

The subtraction is to remove the last comma. Anyway I think it is kind of strange that it is not working. What version of PHP do you use?

It may be possible to get any of the two alternatives to work by simply put the array in another variable. But I have no idea if it will work or not. If it don't work I don't know how to fix the problem.

numerical25

Im using php5 and i did try to put the array in a another varible as well. still got the same issue.

Piranha

I'm sorry, but then I don't understand what is wrong. Hopefully someone else can help you out.

numerical25

🙁 I cant figure my site out. I want to say that its php it self. if the same script works for you and not me. what version of php are you using ???

Weedpacket

What do you get when you var_dump($_POST['delete'])?

And once you get that going, you'll need to fix your query (as per what Piranha wrote earlier).

numerical25

I fixed it. sorry. The problem was that when i use the implode(",",$POST['var']);
its was a invalid argument inside the parameter only because Im trying to seperate a specific element. $POST['var'] ...
to get the entire list. you must implode it like this

implode(",",$_POST);

My list of products had the same name but different value

I had it looping out the list with a checkbox beside it

so when I implode(",",$_POST['val'])

it looked for a specific value which was most likely the last value. instead of just looking for them all.

Piranha

In your second post you posted that it was an array, and I have tried to help you according to that. Now all of a sudden it is not an array, no wonder it doesn't work.

numerical25

well forms are array's arnt they ?? anything with the $var['element'] is an array isnt it. Or atleast I thought so. oops.

Weedpacket

Just because $_POST is an array doesn't mean its elements are arrays as well.

numerical25

Yea i know, i just misunderstood