[RESOLVED] array troubles

[DeathfireD]

Ok I've been trying to parse a list of urls from a site and get only the domain.com part then filter out the duplicates and and convert the list of domains to an ips then filter out the duplicates again and then save to a text file. Well so far I've got the parsing down, duplicate domain name's filtered out, and the domain to ip conversion done. However when I try to filter out the duplicate IPs and also remove any of the domain names that didn't get converted I cant seem to since php errors off saying argument must be an array.

Heres my code:

<?php
$url = "http://fenopy.com/fakefinder/fake.php?cmd=tracker";
$text = @file_get_contents($url);
//$str = $text;

//parse domains only (ex. domainname.com)
preg_match_all('/http:\/\/(.*):(.*)<br\/>/', $text, $output); // fetch the content


//////////////////////////////////////
// Remove dupes
//////////////////////////////////////
$unie = array_unique($output[1]);

//////////////////////////////////////
// change host to ip
//////////////////////////////////////
while (list($key, $value) = each($unie)) {
	 //change domain.com to ip
     $ip = gethostbyname(strtolower($value));
        //make list of ips into an array again
     $fin = array(1 => $ip);

 //Debug test array
 //print_r($array);
  //filter out any duplicate ips (also need to filter out any left over domains)
 $endlist = array_unique($fin[1]);
    echo "<pre>", print_r($endlist[1]),"</pre>";


             //   echo '<li>' . $endlist . '</li>';

  }

?>

So as you can see my while loop makes the past array into a list so I had to make the list into an array again. However when I do this and I attempt to use the array_unique() function it dose not seem to recognize it as an array. So I need some help. If anyone knows a better way to do this please feel free to show me.

Overview
1)Need to filter out duplicate ips
2)Need to remove left over domains
3)Need to write to file

[Weedpacket]

You got yourself confused somewhere along there

$ip = gethostbyname(strtolower($value)); 

So $ip is a string.

$fin = array(1 => $ip); 

$fin is an array containing a single string element.

$endlist = array_unique($fin[1]); 

$fin[1] is a string (that single element of $fin), not an array. $endlist = array_unique($fin); wouldn't be any good either; since $fin only contains one element, it must be unique.

Making it up as I go along...

preg_match_all('!(http://.*?)<br/>!', $text, $output);
$urls = array_map('parse_url', $urls);
$hosts = array();
foreach($urls as $url)
{
$hosts[] = $url['host'];
}
$ips = array_unique(array_map('gethostbyaddr', $hosts));

[DeathfireD]

hmm that explains allot. However the code you thought up doesn't seem to work. heres my updated code with your changes.

The error I'm getting is this.

Warning: array_map() [function.array-map]: Argument #2 should be an array in C:\Dans\web sites\snippets\test6.php on line 19

Warning: Invalid argument supplied for foreach() in C:\Dans\web sites\snippets\test6.php on line 21

1

Code:

<?php
$url = "http://fenopy.com/fakefinder/fake.php?cmd=tracker";
$text = @file_get_contents($url);
$str = $text;

//parse domains only (ex. domainname.com)
//preg_match_all('/http:\/\/(.*):(.*)<br\/>/', $text, $output); // fetch the content

//////////////////////////////////////
// Remove dupes
//////////////////////////////////////
//$unie = array_unique($output[1]);

//////////////////////////////////////
// change host to ip
//////////////////////////////////////

preg_match_all('!(http://.*?)<br/>!', $text, $output);
$urls = array_map('parse_url', $urls);
$hosts = array();
foreach($urls as $url)
{
$hosts[] = $url['host'];
}
$ips = array_unique(array_map('gethostbyaddr', $hosts));


//while (list($key, $value) = each($unie)) {
//     $ip = gethostbyname(strtolower($value));
//     $fin = array(1 => $ip);
     //print_r($array);
//     $endlist = array_unique($fin[1]);

    echo "<pre>", print_r($ips[1]),"</pre>";


	  //   echo '<li>' . $endlist . '</li>';

//      }

?>

Also heres an update that I attempted on my own but still getting errors saying array_unique cannot be used becuse the argument is not an array.

<?php
$url = "http://fenopy.com/fakefinder/fake.php?cmd=tracker";
$text = @file_get_contents($url);
$str = $text;

preg_match_all('/http:\/\/(.*):(.*)<br\/>/', $text, $output); // fetch the content of the first <artist>-tag


//////////////////////////////////////
// change host to ip
//////////////////////////////////////


$unie = array_unique($output[1]);

foreach($unie as $key => $value){
     $ip = gethostbyname(array_unique($value));
         echo '<li>' . $ip . '</li>';

  }


?>

[Weedpacket]

DeathfireD wrote:

However the code you thought up doesn't seem to work.

I'm not surprised; cut-and-paste code never works. It's there for illustration only and is intended to be read and understood, not blindly copied. (as Richard Feynman said: "Don't listen to what I say, listen to what I mean"). I did warn about that.

If you read the code (that's what source code is for), you would have noticed that

$urls = array_map('parse_url', $urls); 

is wrong, and it should have read

$urls = array_map('parse_url', $output[0]); 

(I also note that if you had error reporting set to E_ALL, you'd have been told that $urls is wrong.)
You would have also noticed that I had written "gethostbyaddr" instead of "gethostbyname".

[DeathfireD]

mmm that that might have helped :/. I guess I should have read that more carefully. Anyway, I ended up with this as a finished working loop. I had some help on irc but ended up realizing I was missing $ip = gethostbyname($host); in the example they where explaining to me. After that was added all seems to work fine.

$ips = array();

foreach($unie as $host){
     $ip = gethostbyname($host);
     $ips[] = $ip;
}
 $fin = array_unique($ips);

So thanks for your help. I suppose I should look into the array_map function sometime since it's probably a better way of doing what I was working on.

PS. E_ALL is on.