[RESOLVED] running loop within "if" fails.

spookztar

Hi guys,

I have a small issue, but I don't get any error messages. I'm trying to run a loop that inserts data if a criteria is true. But when I run it, nothing happens. All i get is a freeze of sorts. Everything works fine without the insertion loop.

The code:

if ($dbconnector = @mysql_connect($dbhost, $dbusername, $dbpassword) && $dbhost !=="" && $dbselector = @mysql_select_db($dbname)) {
mkdir('bandfiles', 0755) OR die('<h3 class="warning">Failure: failed making "bandfiles" directory. Check the permissions on your installation server.</h3>');
mkdir('bandfiles/prod_pics', 0755) OR die('<h3 class="warning">Failure: failed making "pics" directory. Check the permissions on your installation server.</h3>');
mkdir('bandfiles/media_samples', 0755) OR die('<h3 class="warning">Failure: failed making "media samples" directory. Check the permissions on your installation server.</h3>');
mkdir('bandfiles/media_files', 0755) OR die('<h3 class="warning">Failure: failed making "media_files" directory. Check the permissions on your installation server.</h3>');
//
// Inserting valid values for future reference.
//
$query[] = "INSERT INTO parameter VALUES(1, 'dbname', '$dbname')";
$query[] = "INSERT INTO parameter VALUES(2, 'dbhost', '$dbhost')";
$query[] = "INSERT INTO parameter VALUES(3, 'admin', 'admin')";
for ($nr=0;$nr<3;$nr++){
  mysql_query($query[$nr]) OR die('<h3 class="warning">Error processing query $nr: . mysql_error())</h3>';
  }
die('<h3 class="success">Success: Your parameters checked out, and have been permanently stored for future reference. The needed folders have also been created in your webdirectory along with a siteuser. Please remove this file (setup.php) from your webdirectory, as it\'s not safe to leave it on your server.</h3>');
}
else die('<h3 class="warning">Connecting using your supplied database parameters failed, so your connection info was not saved and the application folders not created. Go back and re-check your entered values, and try again.<h3>');

As far as I can see, the loop should just run after the last folder has been created and the whole process die with the success message, if no hickups occur. Why does this not work as intended?

Bye,

Kudose

$query[] = "INSERT INTO parameter VALUES(1, 'dbname', '$dbname')";
$query[] = "INSERT INTO parameter VALUES(2, 'dbhost', '$dbhost')";
$query[] = "INSERT INTO parameter VALUES(3, 'admin', 'admin')";
foreach($query as $key => $val){
  mysql_query($val) or die("<h3 class=\"warning\">Error processing query $key: ".mysql_error()".</h3>");
  }

spookztar

Thanx for replying, Kudose.

That doesn't do it either. It results in a blank, white screen - which also happens after a few seconds using the "for" loop.

I don't think it's the kind of loop that's the problem here, as I can't see anything wrong with the "for" version, and the problem remains. Unless someone can specifically tell me why the "for" version is a problem, I would like to stick to that.

Thanx.

Kudose

Put error_reporting(E_ALL); at the top of your script.

spookztar

All I get is the white screen when I reload the browser. Other PHP files load just fine. I already had ini_set('display_errors', ON); at the top of the script, but I got absolutely no info on the nature of this.

Kudose

Try removing the error suppression from the database connection/selection.

spookztar

No change. As stated earlier, the script works just fine when the insertion part is excluded.

This should be so simple, it's just blowing my mind...😕

Can you confirm, that as far as structure goes, there's nothing wrong with the order of things?

Kudose

Your die statement on mysql_query is bad.

This is the reformatted code ... nothing changed, except fixing the bad die statement.

<?php
  if ($dbconnector = @mysql_connect($dbhost, $dbusername, $dbpassword) 
    && 
      $dbhost !=="" && $dbselector = @mysql_select_db($dbname)
    ){
      mkdir('bandfiles', 0755) OR die('<h3 class="warning">Failure: failed making "bandfiles" directory. Check the permissions on your installation server.</h3>');
      mkdir('bandfiles/prod_pics', 0755) OR die('<h3 class="warning">Failure: failed making "pics" directory. Check the permissions on your installation server.</h3>');
      mkdir('bandfiles/media_samples', 0755) OR die('<h3 class="warning">Failure: failed making "media samples" directory. Check the permissions on your installation server.</h3>');
      mkdir('bandfiles/media_files', 0755) OR die('<h3 class="warning">Failure: failed making "media_files" directory. Check the permissions on your installation server.</h3>');
      //
      // Inserting valid values for future reference.
      //
      $query[] = "INSERT INTO parameter VALUES(1, 'dbname', '$dbname')";
      $query[] = "INSERT INTO parameter VALUES(2, 'dbhost', '$dbhost')";
      $query[] = "INSERT INTO parameter VALUES(3, 'admin', 'admin')";
      for ($nr=0;$nr<3;$nr++){
        mysql_query($query[$nr]) OR die('<h3 class="warning">Error processing query $nr: ' . mysql_error().'</h3>');
      }
      die('<h3 class="success">Success: Your parameters checked out, and have been permanently stored for future reference. The needed folders have also been created in your webdirectory along with a siteuser. Please remove this file (setup.php) from your webdirectory, as it\'s not safe to leave it on your server.</h3>');
  } else { 
     die('<h3 class="warning">Connecting using your supplied database parameters failed, so your connection info was not saved and the application folders not created. Go back and re-check your entered values, and try again.<h3>');
  }
?>

spookztar

Yup. That did it.

Man, the irony. The "die" actually killed my script...

One minor (off topic) detail, and I'll let you off!

In the inserts, I specify the numeric ID, but as MySQL autogenerates a number for this field anyway, I shouldn't have to do this. What do I put there to let the auto_increment feature work out the numbering for itself?

Thanx a bunch for your time. Much appreciated. 🙂

Kudose

$query[] = "INSERT INTO parameter VALUES('', 'dbname', '$dbname')";
      $query[] = "INSERT INTO parameter VALUES('', 'dbhost', '$dbhost')";
      $query[] = "INSERT INTO parameter VALUES('', 'admin', 'admin')";

No problem 🙂

spookztar

great.

Thanks for your input.

bradgrafelman

spookztar wrote:
What do I put there to let the auto_increment feature work out the numbering for itself?

You shouldn't put anything at all, because you shouldn't even be listing the auto_increment column in your INSERT statement.

Oh wait - you're not listing columns at all. You should always list the columns in your INSERT query... that way you know which value is going where (and so that you can skip special columns such as auto_increment ones).

Additionally, there's no need to incur the overhead of multiple INSERT queries... you can do them all at once:

INSERT INTO parameter (column1, column2) VALUES ('dbname', '$dbname'), ('dbhost', '$dbhost'), ...

spookztar

Ooh, I see. Thanx for that one. I can see how things could become messy doing it the less-specified way. You're basically saying, that I should pretend that the auto_increment field doesn't even exist.

And this whole looping business wasn't even necessary??? I could just have done:

$query = "INSERT INTO parameter (name, param) VALUES ('dbname', '$dbname'), ('dbhost', '$dbhost'), ('admin', '$initpasswd')";

and that would have done it?

bradgrafelman

spookztar wrote:
and that would have done it?

Yup. The code you have there would insert 3 new rows (make sure those variables have been properly escaped, incase they come from user-supplied data).

spookztar

Right. Sanitization, ok.

Something along the lines of:

mysql_real_escape_string('$dbname', '$dbhost', '$initpasswd');

The above function is supposed to be better than strip_tags(). Correct?

bradgrafelman

spookztar wrote:
The above function is supposed to be better than strip_tags().

When used correctly (your coding snippet is incorrect), yes.