Please Assist

edsdesigns

I would like to know if anyone can please help me in taking the code I have created in the attached file and condense it even farther then what I have already done, I would greatly apprieciate the help. If you have any questions about the below file please flee free to contact me at anytime. For anyone that helps me out with this I just want to thank you for your help

Installer

You define the same function (display_pics()) five times (or more; I might have lost count)? More than once in the same script will cause a fatal error, so you might have added in your post that the script won't run. I'm guessing that all you get is a blank page because you don't have error reporting/display enabled. Remove four of the function definitions, then place the remaining one somewhere out of the way, like at the end of the script or even in an included file. Having it "inline" is unnecessary and only interrupts the reading flow of the script.

Also, on first look, all those db queries could be combined into half as many or fewer.

So I recommend: Turning on error reporting/ display, relocating one of the function definitions and erasing the rest, and combining queries. Then we can go from there.

edsdesigns

I understand what you are saying and I probaly should not have repeated the code like I did. No there are no errors in the code everything works like clock work what I do not understand is how to reduce where to place the coding so that it is much smaller and more efficent can you please explain or show me if at all possible. Thanks alot.

Installer

Yeah, I saw, after a closer look, that you have the function defined in separate "if" blocks. Still, there's no need to define it more than once.

Using "global" in a function more often than not defeats one of the main purposes of functions, reusability. Instead, pass the values to the function.

It looks like you want "$picrows to be the same throughout the script, so why define it several times?. Define it once, near the top of the script or in a configuration file, where it can be easily found and changed.

The display_pics() function also does two things. It retrieves data, and constructs a display. This again is against a purpose of functions. Divide it into two functions, passing only the needed variables to each one.

Something like this should work (the second function is pared down to more clearly demonstrate):

function fetch_query_result($result)
{
    $num = mysql_num_rows($result);
    while ($row = mysql_fetch_array($result);
        $result_array['id'][] = $row['id'];
        $result_array['catagory'][] = $row['catagory'];  // Synonym for "category"?
        $result_array['image'][] = $row['image'];
    }
    return $result_array;
)

function display_pics($pics_arr, $columns)  // Add needed html to this function.
{
    $rows = 1 + round(count($pics_arr) / $columns);
    for ($r = 0; $r < $rows; $r++) {
        echo '<tr>';
        foreach ($pics_arr as $each) {
            echo '<td align="center" valign="top" bgcolor="#000000">';
               . '<img src="http://diahannphillips.com/images/stock/' . $pics_arr['image'] . '" border="0"></td>';
        }
        echo "</tr>";
    }
}

Perform the queries and pass the resource handle to the first function. Then pass the array returned from that to the second function. The array will contain the images, and other data you can use elsewher.

I'll look at it some more a little later.