Help with login please

JBD2435

For the code below I get this error..... Parse error: syntax error, unexpected '>' in /home/jbd2435/public_html/project2/login.php on line 23

Could someone please help me out with this? I think it could be a mixed syntax error...

<? 
// Login & Session example by sde 
// auth.php 
include("connect.php");
// start session 
session_start();  

// convert username and password from _POST or _SESSION 
if($_POST){ 
  $_SESSION['username']=$_POST["username"]; 
  $_SESSION['password']=$_POST["password"];   

} 

// query for a user/pass match 
$result=mysql_query("select * from users  

  where username='" . $_SESSION['username'] . "' and password='" . $_SESSION['password'] . "'"); 

// retrieve number of rows resulted 
$num=mysql_num_rows($result);  

// print login form and exit if failed. 
if($num < 1){ 
  echo "You are not authenticated.  Please login."<br><br> 
} 
?>

edsdesigns

The problem you have with line 23 and the reason for the syntax error is becuse if you look at the and of the line you have the ending quotation mark in the worng place and you have to end each echo with a ; other wise you will also get the same problem so replace Line 23 with the line of code included in this post

echo "You are not authenticated.  Please login.<br><br>";

Piranha

First up, don't use short tags. Use <?php instead. One reason is that it won't work from php6.

Second, make sure that your variables are safe from database injection before you use them in queries. [man]mysql_real_escape_string[/man] can help you with this.

And now for your question. After a php command you should use semicolon. And there is no command named <br><br>. I assume that you mean to use it as html, then it should be inside the " signs.

JBD2435

Now I get this error

Warning: session_start() [function.session-start]: Cannot send session cache limiter - headers already sent (output started at /home/jbd2435/public_html/project2/connect.php:18) in /home/jbd2435/public_html/project2/login.php on line 6
[B]You are not authenticated. Please login.[/B]

The last part is part of the script

Piranha

All headers (including session_start) have to be called before you output anything to the browser. Not a space, not an enter is allowed. I suggest that you move it to the top of the page.

JBD2435

Thank you all for the help! IT works now, I just have to get the authentication working properly and everything will work fine.

edsdesigns

I have a login and registration script that if you would like to try out that is a much more secure method if you are intersted. Both scripts use sessions and MD5 encription.

Tiddly_Winks

edsdesigns wrote:
I have a login and registration script that if you would like to try out that is a much more secure method if you are intersted. Both scripts use sessions and MD5 encription.

I'm interested if you still have it available. Newbie here looking for as many good examples as I can get.