Couldn't execute query.

tomlei

Hi,

I am having problems here trying to get a php page to load. We have just moved the site to a new server, the codes havent' been changed, but the pages just wouldn't load. Both PHP and IIS are set up properly.

When I try to run the following query, it returns a message "Couldn't execute query." There are no other error messages so I don't know where to start....

Many thanks.

<?
$client = $HTTP_GET_VARS['client'];

if (!$client) {
   $client = "boy";
}

if(!isset($HTTP_GET_VARS['searchnames'])){ 
$searchnames = "";	
} else {
$searchnames = $HTTP_GET_VARS['searchnames'];	
}

if(!isset($HTTP_GET_VARS['searchheight'])){ 
$searchheight = "";	
} else {
$searchheight = $HTTP_GET_VARS['searchheight'];	
}


if(!isset($HTTP_GET_VARS['searcheyes'])){ 
$searcheyes = "";	
} else {
$searcheyes = $HTTP_GET_VARS['searcheyes'];	
}

if(!isset($HTTP_GET_VARS['searchhair'])){ 
$searchhair = "";	
} else {
$searchhair = $HTTP_GET_VARS['searchhair'];	
}


if(!isset($HTTP_GET_VARS['searchshoes'])){ 
$searchshoes = "";	
} else {
$searchshoes = $HTTP_GET_VARS['searchshoes'];	
}

if(!isset($HTTP_GET_VARS['searchage'])){ 
$searchage = "";	
} else {
$searchage = $HTTP_GET_VARS['searchage'];
$searchagetype = $HTTP_GET_VARS['searchagetype'];
if ($searchagetype != "m"){	
		$searchyearquery = calculate_year($searchage, $searchage);
} else {
	$searchyearquery = calculate_month($searchage, $searchage);	
}
}

if(!isset($HTTP_GET_VARS['searchyear'])){ 
$searchyear = "";	
} else {
$searchyear = $HTTP_GET_VARS['searchyear'];	
	$searchyearquery = calculate_year($searchyear, $searchyear);	
}

if(!isset($HTTP_GET_VARS['searchmonth'])){ 
$searchmonth = "";	
} else {
$searchmonth = $HTTP_GET_VARS['searchmonth'];	
if ($searchmonth) {
	$searchyearquery = calculate_month($searchmonth, $searchyear);	
}	
}


if(!isset($HTTP_GET_VARS['lower'])){ 
$lower = "";	
} else {
$lower = $HTTP_GET_VARS['lower'];	
}

if(!isset($HTTP_GET_VARS['upper'])){ 
$upper = "";	
} else {
$upper = $HTTP_GET_VARS['upper'];	
}

if(!isset($HTTP_GET_VARS['largeimage'])){ 
$largeimage = "";	
} else {
$largeimage = $HTTP_GET_VARS['largeimage'];	
}

if(!isset($HTTP_GET_VARS['upperage'])){ 
$upperage = "";	
} else {
$upperage = $HTTP_GET_VARS['upperage'];	
}

if(!isset($HTTP_GET_VARS['lowerage'])){ 
$lowerage = "";	
} else {
$lowerage = $HTTP_GET_VARS['lowerage'];	
}

$yearquery = calculate_year($upperage, $lowerage);	

if (!$lower){
$lower = 0;
}

if (!$upper){
$upper = 10;
}

$query = "SELECT *,RIGHT(dateofbirth,4) AS YEAR,MID(dateofbirth,4,2) AS MONTH FROM person WHERE type = '$client' AND release = 'yes'"; 


if ($yearquery) {
    $query = "$query AND ($yearquery)";
}

if ($searchyearquery) {
    $query = "$query AND ($searchyearquery)";
}


if ($searchheight) {
    $query = "$query AND height = '$searchheight'";	
}

if ($searchnames) {
    $query = "$query AND firstname = '$searchnames' OR surname = '$searchnames'";	
}

if ($searcheyes) {
    $query = "$query AND eyecolour = '$searcheyes'";	
}
if ($searchhair) {
    $query = "$query AND haircolour = '$searchhair'";	
}
if ($searchshoes) {
    $query = "$query AND shoesize = '$searchshoes'";	
}

// if ($searchage) {
// $query = "$query AND dateofbirth = '$searchage'";
// }

if ($action == "viewshortlist"){
	$query = "SELECT *,RIGHT(dateofbirth,4) AS YEAR,MID(dateofbirth,4,2) AS MONTH FROM person"; 
$shortlistquery = CMS_view_shortlist($_SESSION['shortlist']);
$query = "$query $shortlistquery";
} 	

$query = "$query AND release = 'yes'";

// echo $query;
// echo $shortlistquery;

$total_result = query_database("$query");

$total_num = mysql_num_rows($total_result);

if ($action != "viewshortlist"){
	$query = "$query ORDER by YEAR DESC,MONTH ASC LIMIT $lower,$upper";
}

// echo $query;

$result = query_database("$query");

$result2 = query_database("$query");

$clientid = $HTTP_GET_VARS['clientid'];

if(!isset($HTTP_GET_VARS['clientid'])){
$rowx = mysql_fetch_array($result2);
$clientid = $rowx['id'];
} else {
if ($clientid != ""){
    $clientid = $HTTP_GET_VARS['clientid'];
}else{
    $rowx = mysql_fetch_array($result2);
    $clientid = $rowx['id'];	
}	
}


$client_result = query_database("SELECT * FROM person WHERE id = '$clientid'");

while ($row = mysql_fetch_array($client_result)) {

$large_id = $row['id'];
$large_firstname = $row['firstname'];
$large_surname = $row['surname'];
$large_dateofbirth = $row['dateofbirth'];
$large_height = $row['height'];
$large_eyecolour = $row['eyecolour'];
$large_haircolour = $row['haircolour'];
$large_shoesize = $row['shoesize'];
$large_image1 = $row['image1'];
$large_image2 = $row['image2'];
$large_image3 = $row['image3'];
$large_image4 = $row['image4'];
$large_image5 = $row['image5'];
$large_image6 = $row['image6'];

}

Piranha

Please enclose code in [ php] code here [ /php] brackets (without the spaces). It makes it much easier to view and debug the code.

Now to your problem. To get a little background we need a few questions answered. Do you have the same version of MySQL? Of PHP? If not, what versions did you have before and what version do you have now? Did you use IIS before?

To help you further we need the exact query that doesn't work. You have lots of queries in the code, and we don't know what query it is that doesn't work.

A few other things about your code. Don't use short tags, one reason is that it will not work from PHP6. And don't use $HTTP_GET_VARS['lower'], use $_GET['lower'] instead. I don't think that this cause any big trouble at the moment, but it is always good to use the current ways since the old ones will be removed in the future.

bradgrafelman

Piranha wrote:
I don't think that this cause any big trouble at the moment

On the contrary, this could cause a big problem - using the default settings, these long variables ($HTTP*VARS) aren't even created by PHP. So, if the hosting company decides to upgrade and doesn't re-enable this deprecated feature (as they shouldn't), this script would fail because of it.

tomlei wrote:
are no other error messages so I don't know where to start

You can start by outputting other error messages (since they'll be a bit more helpful). This post from the Debugging 101 thread illustrates one method of producing meaningful error messages when a SQL query fails (examine the bit under the "mysql_query returns false on failure" comment). Modify your code accordingly and tell us what the MySQL error is.

Piranha

Ty for correcting me Brad.