sql syntax error? help needed

nolimitman

Im trying to make a master detail page in dreamweaver using a database with
id set as unique value and 3 fields, name last name and email varchar.

Im following this guide how to make a master detail page in dreamweaver
http://www.adobe.com/support/dreamweaver/building/master_detail_php/

Everything is working ok until i test the page and i get these error messages
i tested the site both on local server and on my webhost.

tested on local server the page links to detail page but get this message
You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near 'ORDER BY id ASC' at line 1

Tested on my webhost

You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near '' at line 1

I use id as unique value in the database and in the url for the links.

I suspect something is wrong in my database/table but not sure since i followed the steps very carefully how to set up the pages in dreamweaver.
I would appreciate some help how to solve this problem which probably lays
in the sql/database since im a beginner at creating tables.

Installer

There may well be something wrong with your database/table, but the cause of the SQL syntax error message you're seeing is an error in your SQL syntax.

Put your query string into a variable and echo it, then check it for the error.

nolimitman

Thanks for your answer, im a total beginner at php and mysql so im not exactly sure how to do what youre suggesting.
With a error in the sql syntax it means that something is wrong with the table in the database or in any of the fields in table or can it mean that something is wrong with the php code?

Installer

It means that there is something wrong with your query string, e.g:

SELECT WHERE a = b c AS d FROM my_table;

would cause a syntax error condition (because the WHERE clause is out of order).

So, in your code, before you execute the query (presumably with mysql_query()) echo out the query itself (the part that goes between the parentheses). Like:

$x = 1;
$query = "SELECT * FROM my_table WHERE a_field = " . $x;
echo $query;
$result = mysql_query($query);

Edit: If you can't find the syntax mistake, post the echoed line and maybe someone can find it.

nolimitman

For some reason i cant get the echo string to work but here is my php code i would appreciate if you or anybody else here could get something out of it.
the error message says
You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near '' at line 1

My php code for the detail page Where the error should be located at line 1
or am i way off?

1<?php require_once('Connections/site1.php'); ?> is the problem on this line ?
<?php
$colname_Recordset_2 = "id";
if (isset($GET['goto'])) {
$colname_Recordset_2 = (get_magic_quotes_gpc()) ? $GET['goto'] : addslashes($_GET['goto']);
}
mysql_select_db($database_site1, $site1);
$query_Recordset_2 = sprintf("SELECT * FROM web_members WHERE id = %s", $colname_Recordset_2);
$Recordset_2 = mysql_query($query_Recordset_2, $site1) or die(mysql_error());
$row_Recordset_2 = mysql_fetch_assoc($Recordset_2);
$totalRows_Recordset_2 = mysql_num_rows($Recordset_2);
?>
<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.01 Transitional//EN" "http://www.w3.org/TR/html4/loose.dtd">
<html>
<head>
<title>Untitled Document</title>
<meta http-equiv="Content-Type" content="text/html; charset=iso-8859-1">
<style type="text/css">

</style></head>

the master page code
<?php require_once('Connections/site1.php'); ?>
<?php
$maxRows_Recordset1 = 10;
$pageNum_Recordset1 = 0;
if (isset($GET['pageNum_Recordset1'])) {
$pageNum_Recordset1 = $GET['pageNum_Recordset1'];
}
$startRow_Recordset1 = $pageNum_Recordset1 * $maxRows_Recordset1;

mysql_select_db($database_site1, $site1);
$query_Recordset1 = "SELECT name, lastname, email FROM web_members";
$query_limit_Recordset1 = sprintf("%s LIMIT %d, %d", $query_Recordset1, $startRow_Recordset1, $maxRows_Recordset1);
$Recordset1 = mysql_query($query_limit_Recordset1, $site1) or die(mysql_error());
$row_Recordset1 = mysql_fetch_assoc($Recordset1);

if (isset($GET['totalRows_Recordset1'])) {
$totalRows_Recordset1 = $GET['totalRows_Recordset1'];
} else {
$all_Recordset1 = mysql_query($query_Recordset1);
$totalRows_Recordset1 = mysql_num_rows($all_Recordset1);
}
$totalPages_Recordset1 = ceil($totalRows_Recordset1/$maxRows_Recordset1)-1;
?>
<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.01 Transitional//EN" "http://www.w3.org/TR/html4/loose.dtd">
<html>
<head>
<title>Untitled Document</title>
<meta http-equiv="Content-Type" content="text/html; charset=iso-8859-1">
</head>

<body>
<table border="1">
<tr>
<td>name</td>
<td>lastname</td>
<td>email</td>
</tr>
<?php do { ?>
<tr>
<td><a href="detail.php?goto=<?php echo$row_Recordset_2['id']; ?>"><?php echo $row_Recordset1['name']; ?></a></td>
<td><?php echo $row_Recordset1['lastname']; ?></td>
<td><?php echo $row_Recordset1['email']; ?></td>
</tr>
<?php } while ($row_Recordset1 = mysql_fetch_assoc($Recordset1)); ?>
</table>
</body>
</html>
<?php
mysql_free_result($Recordset1);
?>

bradgrafelman

When posting PHP code, please use the board's [PHP][/PHP] bbcode tags - they make the code much, much easier to read (as well as aiding the diagnosis of syntax errors). You should edit your post now and add these bbcode tags to help others in reading/analyzing your code.