[RESOLVED] Directory listing show single and double periods.

dmacman1962

Hi All,

I thought I had this resolved here but after looking closely, I noticed the hyperlink had a single and double period in the beginning of the file name and it linked to files that are not there.

I suspect they are the usual
. <------
.. <------
filename.jpg

you see in a directory listing...

I did have to modify my code to get it to match the ID of the order and the beginning of the filenames as such.

$file_list = ftp_nlist($connftp, "/public_html/staff/uploads/");
			foreach ($file_list as $file)
			{
			if (preg_match("/^$ID/",$file)) {
				//if(strpos($file, $ID) === 0 && !is_dir($file) && !is_dir($dir.'/'.$file_list)) 
					 // echo "<a href=".$path.$file.">".$file."</a><br />";
			echo '<a href="'.$path.'/'.$file.'">'.$file.'</a><br />';
			}
			}

How can I filter out these to 'non-files?'

Thanks,
Don

laserlight

Just compare, an example is given in the PHP Manual concerning [man]readdir/man.

dmacman1962

Instead of re-writing the all the code, I just changed it to this...

if ($file != "." && $file != "..") {
   echo '<a href="'.$path.'/'.$file.'">'.$file.'</a><br />';
}

And that eliminated it. A hack approach, or OK?

Thanks,
Don

laserlight

$file_list = ftp_nlist($connftp, "/public_html/staff/uploads/");
foreach ($file_list as $file)
{
    if (preg_match("/^$ID/",$file) && $file != "." && $file != "..") {
        //if(strpos($file, $ID) === 0 && !is_dir($file) && !is_dir($dir.'/'.$file_list))
        // echo "<a href=".$path.$file.">".$file."</a><br />";
        echo '<a href="'.$path.'/'.$file.'">'.$file.'</a><br />';
    }
}

I note again that there is no need for preg_match() here when strpos() will do.

dmacman1962

Sorry to go against the grain, but I tried ...

if(strpos($file, $ID) === 0 && !is_dir($file) && !is_dir($dir.'/'.$file_list)) {
echo "<a href=".$path.$file.">".$file."</a><br />";
}

...and it did not show the files.

And I am wondering, with it checking position 0 what if it is a 2,3 or more digit ID, will it still match?

Thanks,
Don

laserlight

More like:

foreach ($file_list as $file)
{
    if (strpos($file, $ID) === 0 && $file != "." && $file != "..") {
        echo '<a href="'.$path.'/'.$file.'">'.$file.'</a><br />';
    }
}

If you really only want to list files, then you can use:

foreach ($file_list as $file)
{
    if (is_file($file) && strpos($file, $ID) === 0) {
        echo '<a href="'.$path.'/'.$file.'">'.$file.'</a><br />';
    }
}

And I am wondering, with it checking position 0 what if it is a 2,3 or more digit ID, will it still match?

Yes. Test and see.

halojoy

hi
I use the following code in many of my scripts.
It will exclude any file where first charater is = '.'
$file[0] or $file{0} -----> gives first char in a one value string variable (not an array).

It works in most of my scripts.
Not as precise, as to test The Whole Filename, with all characters.
... but it
will exclude following 3 very common filenames:
.
..
.htaccess

<?php

if ( $file[0] != "." ) { 

// if first char not = '.'
// then include and add filename $file in Array List

}

?>

Regards
halojoy
🙂

laserlight

That sounds like a good idea to me, in view that the *nix convention is for hidden files to have names beginning with a period.

I note that now the {} syntax for accessing characters in strings is (or will be) deprecated in favour of the (formerly deprecated) [] array-element-like syntax.

halojoy

laserlight wrote:
That sounds like a good idea to me, in view that the *nix convention is for hidden files to have names beginning with a period.

I note that now the {} syntax for accessing characters in strings is (or will be) deprecated in favour of the (formerly deprecated) [] array-element-like syntax.

Okay, thanks for this info, laserlight
I start using $file[0] .... from now on.
This is the normal, and most known way,
to adress 1 specific character in a single value STRING.
It will not work if $file is an array!!

But neither would $file{0}.

🙂

bradgrafelman

halojoy wrote:
It will not work if $file is an array!!

What do you mean?

$file = array(0 =>'hi');

echo $file[0][0]; // outputs: h

dmacman1962

Thanks to all!

I love this forum. 🙂

Don

halojoy

bradgrafelman wrote:
What do you mean?
$file = array(0 =>'hi');
echo $file[0][0]; // outputs: h

So it will work arrays!
Yes, if we know how many dimensions ( which is often the case, for sure )
But try your code with this array, bradgrafelman

<?php
$file = array(
array( 0 => 'hi their', 1 => 'buy buy my friend' ),
array( 0 => 'toeday heillo', 1 => 'morrow goodbye' )
);
echo $file[0][0]; // outputs: ????

My statement was:
$file[0] will not work with arrays

Think it is still true. ... at least it will not always return 1 character.
And this was what I wanted to say.
On the subject of this topic and in this context
it will work when readdir(),
as filnames are only simple strings, not arrays

===========================================
Here is my nice coding suggestion, again:

<?php

// Test while using readdir( $dir )
if ( $file[0] != "." ) {

// if first char of filename is not = '.'
// then include and add filename $file in Array List
// Will exclude [ '.' and '..' and '.htaccess' ] from your directory list

}

?>

===========================================

Regards
halojoy
🙂

Weedpacket

Incidentally, might [man]glob/man work for you?

bradgrafelman

Or, if you know that all of the files you want will have extensions, you can use '.' in your glob() - I do this a lot so I don't have to worry about filtering '.' and '..' from the results.

dmacman1962

Wow!

Nice answers.

I tested WeedPackets and it will do it, except I am stuck on the path.

I tried ...

foreach (glob('/public_html/staff/uploads/*.*') as $filename) {

and it will not work as is. I tried several other variants on the path/name concationation and none worked.

I got most of my tests from the php.net page and they seemed to work for the authors, but not in my case. Am I missing something here?

Thanks,

Don

bradgrafelman

You need to use the correct filepath. Either use the full absolute path (e.g. /home/username/public_html/staff/uploads/) or use a relative path.

dmacman1962

Hi brad,

I got the correct path and it is finding my "uploads" folder with this code.

foreach (glob("/home/advisory/public_html/staff/uploads/".$id."*.*") as $filename) {
	echo "$filename - " . filesize($filename) .  " bytes<br />";
}

and it displays this...

/home/advisory/public_html/staff/uploads/2-answers.jpg - 51605 bytes

I tried...

$name = ereg($filename, $link);
echo "<a href=\"".$filename."\">".$name."</a>";

But that did not work.

Any ideas?

Thanks again,
Don

Weedpacket

You're confusing filesystem paths with URLs. (<a href="/home/advisory/public_html/staff/uploads/2-answers.jpg">thingy</a> isn't going to mean anything useful to the client, unless they have malicious intent....)

$filename is a filesystem path, what you want in the tag is a URL. You could use basename() to remove the filesystem path and then attach the appropriate path for the URL.