Simple form help

dugindog

here's what I am after:

a simple form (html) that allows a user to select a file (.txt type), then on submit, reads the file to a variable so I can process the file.

I don't work with file uploads very often, and constantly forget how. any help would be appreciated.

here's what I've got:

<?



if (!isset($_REQUEST[id])) {


?>

<html>
<body>
<form>
<input type="hidden" name="id" value="set">

<table>
<tr>
<td>Select file to upload</td><td><input type="file" name="file"></td>
</tr>
<tr>
<td colspan="2"><input type="submit"></td>
</tr>
</table>
</form>
</body>
</html>


<?
}

if (isset($_REQUEST[id])) {

echo $_REQUEST[id] . "<HR>";

$filecontent = $_FILES[$_REQUEST[files]];

echo $filecontent;

}

?>

please help out if you can (I know I'm being stupid, but like I said I normally don't work with file reads (especially from a form).

dugindog

but still won't even upload the file to a dir help please?

<?



if (!isset($_REQUEST[id])) {


?>

<html>
<body>
<!--<form method="POST">
<input type="hidden" name="id" value="set">
<input type="hidden" name="MAX_FILE_SIZE" value="25000" />

<table>
<tr>
<td>Select file to upload</td><td><input type="file" name="uploadfile"></td>
</tr>
<tr>
<td colspan="2"><input type="submit"></td>
</tr>
</table>
</form>
-->
This form allows you to upload a file to the server.<br>

<form action="filetest.php" method="post"><br>
Type (or select) Filename: <input type="file" name="uploadFile">
<input type="hidden" name="MAX_FILE_SIZE" value="25000" />
<input type="hidden"name="id" value="ID has been SET">
<input type="submit" value="Upload File">
</form>





</body>
</html>


<?
}

if (isset($_REQUEST[id])) {

echo $_REQUEST[id] . "<HR>";

?>


<?php

if ( move_uploaded_file ($_FILES['uploadFile'] ['tmp_name'], 
       "/tupload/{$_FILES['uploadFile'] ['name']}")  )
      {  print '<p> The file has been successfully uploaded </p>';
       }
else
      { 
        switch ($_FILES['uploadFile'] ['error'])
         {  case 1:
                   print '<p> The file is bigger than this PHP installation allows</p>';
                   break;
            case 2:
                   print '<p> The file is bigger than this form allows</p>';
                   break;
            case 3:
                   print '<p> Only part of the file was uploaded</p>';
                   break;
            case 4:
                   print '<p> No file was uploaded</p>';
                   break;
         }
       }


$contents = $_FILES['uploadFile']['content'];


}

echo "<HR>$contents";

echo "<HR>Complete";
?>

greenie2600

Okay, so it doesn't do what you want it to, but what does it do? Are you getting an error, or seeing some other unexpected behavior?

You might want to check php.net's documentation on handling file uploads.

Also, I noticed an unrelated problem with your code:

$_REQUEST[id]

String literals should be quoted. Example:

$my_string = 'Here is some text to put inside this string';

In other words, your code should read:

$_REQUEST['id']

Your code works the way it is, but only by accident. id (with no quotes) refers to a constant named "id". However, no such constant is defined - and when PHP encounters a reference to an undefined constant, it just evaluates it as a string containing the name of the (nonexistent) constant. So, your code does exactly what you wanted it to, but only through lucky coincidence 🙂 If you later define() a constant named "id", your code will break.

Even if you never use constants, it's probably not a good idea to rely on this behavior. It might change in future versions of PHP, and it'll be confusing for other programmers working with your code. Just a tip...

dugindog

greenie2600 wrote:
Okay, so it doesn't do what you want it to, but what does it do? Are you getting an error, or seeing some other unexpected behavior?

You might want to check php.net's documentation on handling file uploads.

Also, I noticed an unrelated problem with your code:
$_REQUEST[id]
String literals should be quoted. Example:
$my_string = 'Here is some text to put inside this string';
In other words, your code should read:
$_REQUEST['id']
Your code works the way it is, but only by accident. id (with no quotes) refers to a constant named "id". However, no such constant is defined - and when PHP encounters a reference to an undefined constant, it just evaluates it as a string containing the name of the (nonexistent) constant. So, your code does exactly what you wanted it to, but only through lucky coincidence 🙂 If you later define() a constant named "id", your code will break.

Even if you never use constants, it's probably not a good idea to rely on this behavior. It might change in future versions of PHP, and it'll be confusing for other programmers working with your code. Just a tip...

I corrected the [id] -> ['id']

as for the results of the script.

(dashes are a HR)
and NO file is placed in the directory tupload
output below.

ID has been SET
--------------------------------------------------------------------------------

--------------------------------------------------------------------------------

--------------------------------------------------------------------------------
Complete

NO errors, but no desired results either, is there a variable error I am not seeing?

dugindog

also view the page at:
www.go-remote.com/filetest.php