Undefined index: vorname in [...]

[nitramf]

hi!
I am a newbie to PHP and have searched this site and Google for this error and have found many references but no solutions, please forgive if this has been addressed before.
This is the Error-Message:
Notice: Undefined index: vorname in /var/www/web1/html/neu/php/lehreradmin.php on line 8

Here is the Complete Code of lehreradmin.php:

<?
error_reporting(E_ALL);
include 'config.php';
    // Konfigurationsdatei laden
$db=mysql_connect(MYSQL_HOST, MYSQL_USER, MYSQL_PASS);
mysql_select_db('usr_web1_4');
echo mysql_errno() . ": " . mysql_error(). "\n";
if($_REQUEST['vorname']!='' AND $_REQUEST['name']!='')
   mysql_query(
$query = ('delete from lehrertabelle where id='.$_POST['id']);

$result = mysql_query ($query);
echo "Lehrer Eingetragen/Geloescht";

?> 

Here is the index.php:

<?php
error_reporting(E_ALL);
# Konfigurationsdatei laden:
include("config.php");



$db_link = mysql_connect(MYSQL_HOST, MYSQL_USER, MYSQL_PASS);

if($db_link) {
    echo "Verbindung wurde aufgebaut<br />\n";
    echo "In der Variable steht folgendes: ".$db_link;
} else {
    echo "Es konnte keine Verbindung aufgebaut werden";
}

#======= Aktionen ausführen:
// Falls ein Lehrer zur Löschung übergeben wurde:#
if(!empty($_REQUEST['lehrerloeschen'])) {

   $loeschen=mysql_query("DELETE FROM `lehrertabelle` WHERE `id`='".$_REQUEST['lehrerloeschen']."'");
echo mysql_errno() . ": " . mysql_error(). "\n";
};

# Falls ein Lehrer zum Speichern eingetragen wird:
if(!empty($_REQUEST["vorname"]) AND !empty($_REQUEST['name'])) {
   $speichern=mysql_query("INSERT INTO `lehrertabelle` VALUES(NULL, '".$_REQUEST['name']."', '".$_REQUEST['vorname']."')");
};


#======= Löschformular:
mysql_select_db('usr_web1_4');
$lehrer=mysql_query("SELECT * FROM `lehrertabelle` ORDER BY `name` ASC");
echo mysql_errno() . ": " . mysql_error(). "\n";
#======= Wenn Lehrer eingetragen sind Auswahlliste erstellen:

if("mysql_num_rows($lehrer)>=1") {
   ?>
  <form action="lehreradmin.php" method="POST">
      <select name="lehrerloeschen">
   <?php
include("config.php");
   while($dieserlehrer=mysql_fetch_array($lehrer)) {
      ?><option value="<?php echo $dieserlehrer['id']; ?>"><?php echo $dieserlehrer['name'].", ".$dieserlehrer['vorname']; ?></option><?php
   };
   ?></select><input type="submit" value="L&ouml;schen!" /></form>
   <?php
}
# Ansonsten Meldung ausgeben:
else {
   echo "<p>Keine Lehrkr&auml;fte eingetragen!</p>";
};

# Darunter ein Formular zum Hinzufügen eines neuen Lehrers:
?>
<form action="./lehreradmin.php" method="POST">
   Nachname: <input type="text" name="name" size="30" /><br />
   Vorname: <input type="text" name="vorname" size="30" /><br />
   <input type="submit" value="Speichern!" />
</form>

Thats the Link to my Script:
http://php.support-netz.eu/

Greetings,
nitramf

[Piranha]

It is because there is not variable that fits in $REQUEST['vorname']. Use "if (isset($REQUEST['vorname']) && ..." then you will make sure if there is such a variable or not.

But it is better to use the correct array and not request. Use $POST and $GET instead, it may save you trouble.

And don't use short open tags. Use <?php instead.

[nitramf]

Hi!

Shall i write

  $loeschen=mysql_query("DELETE FROM `lehrertabelle` WHERE `id`='".$_post['lehrerloeschen']."'");
echo mysql_errno() . ": " . mysql_error(). "\n";
}; 

[Piranha]

No, variables are case sensitive. POST and GET should be in caps, the code in your post should probably be:

$loeschen=mysql_query("DELETE FROM `lehrertabelle` WHERE `id`='".$_POST['lehrerloeschen']."'");
echo mysql_errno() . ": " . mysql_error(). "\n";
}; 

[Weedpacket]

..and make sure that $_POST['lehrerloeschen'] doesn't contain something like 1' or 1=1 or '1'='1....

[nitramf]

When i create a new teacher, this error is present:
Notice: Undefined index: id in /var/www/web1/html/neu/php/lehreradmin.php on line 9

When i go directly on lehreradmin.php i get this error:
Notice: Undefined index: vorname in /var/www/web1/html/neu/php/lehreradmin.php on line 8

Now im endly confused :queasy:
Here is the complete Code again:
index.php:

<?php
error_reporting(E_ALL);
# Konfigurationsdatei laden:
include("config.php");



$db_link = mysql_connect(MYSQL_HOST, MYSQL_USER, MYSQL_PASS);

if($db_link) {
    echo "Verbindung wurde aufgebaut<br />\n";
    echo "In der Variable steht folgendes: ".$db_link;
} else {
    echo "Es konnte keine Verbindung aufgebaut werden";
}

#======= Aktionen ausführen:
// Falls ein Lehrer zur Löschung übergeben wurde:#
if(!empty($_REQUEST['lehrerloeschen'])) {

  $loeschen=mysql_query("DELETE FROM `lehrertabelle` WHERE `id`='".$_POST['lehrerloeschen']."'");
echo mysql_errno() . ": " . mysql_error(). "\n";
}; 
# Falls ein Lehrer zum Speichern eingetragen wird:
if(!empty($_REQUEST["vorname"]) AND !empty($_REQUEST['name'])) {
   $speichern=mysql_query("INSERT INTO `lehrertabelle` VALUES(NULL, '".$_REQUEST['name']."', '".$_REQUEST['vorname']."')");
};


#======= Löschformular:
mysql_select_db('usr_web1_4');
$lehrer=mysql_query("SELECT * FROM `lehrertabelle` ORDER BY `name` ASC");
echo mysql_errno() . ": " . mysql_error(). "\n";
#======= Wenn Lehrer eingetragen sind Auswahlliste erstellen:

if("mysql_num_rows($lehrer)>=1") {
   ?>
  <form action="lehreradmin.php" method="POST">
      <select name="lehrerloeschen">
   <?php
include("config.php");
   while($dieserlehrer=mysql_fetch_array($lehrer)) {
      ?><option value="<?php echo $dieserlehrer['id']; ?>"><?php echo $dieserlehrer['name'].", ".$dieserlehrer['vorname']; ?></option><?php
   };
   ?></select><input type="submit" value="L&ouml;schen!" /></form>
   <?php
}
# Ansonsten Meldung ausgeben:
else {
   echo "<p>Keine Lehrkr&auml;fte eingetragen!</p>";
};

# Darunter ein Formular zum Hinzufügen eines neuen Lehrers:
?>
<form action="./lehreradmin.php" method="POST">
   Nachname: <input type="text" name="name" size="30" /><br />
   Vorname: <input type="text" name="vorname" size="30" /><br />
   <input type="submit" value="Speichern!" />
</form>

lehreradmin.php

<?php
error_reporting(E_ALL);
include 'config.php';
    // Konfigurationsdatei laden
$db=mysql_connect(MYSQL_HOST, MYSQL_USER, MYSQL_PASS);
mysql_select_db('usr_web1_4');
echo mysql_errno() . ": " . mysql_error(). "\n";
if (($_REQUEST['vorname'] != '') && ($_REQUEST['name'] != '' )) {
    $query = "DELETE FROM lehrertabelle WHERE id = " . $_POST['id'];
    $result = mysql_query ($query);
    echo "Lehrer Eingetragen/Geloescht";
} 

?> 

[Piranha]

If you see the id in the URL then you should use GET. If it is sent with a form that uses post as method then you should use POST. To understand it search, read and try it out a couple of times.

And do what Weedpacket says, otherwise the database is wide open for anyone to tamper with.

[nitramf]

The error is present.

<?php
error_reporting(E_ALL);
include 'config.php';
    // Konfigurationsdatei laden
$db=mysql_connect(MYSQL_HOST, MYSQL_USER, MYSQL_PASS);
mysql_select_db('usr_web1_4');
echo mysql_errno() . ": " . mysql_error(). "\n";
if (($_GET['vorname'] != '') && ($_GET['$_GET name'] != '' )) {
    $query = "DELETE FROM lehrertabelle WHERE id = " . $_GET['id'];
    $result = mysql_query ($query);
    echo "Lehrer Eingetragen/Geloescht";
} 

?> 

[laserlight]

You need to use [man]isset[/man] or [man]empty[/man] on incoming variables to check that they actually exist before using them.

[nitramf]

laserlight wrote:

You need to use [man]isset[/man] or [man]empty[/man] on incoming variables to check that they actually exist before using them.

Is that right?

if(isset($vorname));

[laserlight]

You have the right idea. In your most recent example, I do not see why you need $GET['vorname'] in the first place, and $GET['$_GET name'] looks like a mistake (though it is legal).

I might write something along these lines:

<?php
error_reporting(E_ALL);
include 'config.php';
// Konfigurationsdatei laden
$db = mysql_connect(MYSQL_HOST, MYSQL_USER, MYSQL_PASS);
mysql_select_db('usr_web1_4');
echo mysql_errno() . ": " . mysql_error(). "\n";
if (isset($_GET['vorname'], $_GET['id'])) {
    $query = "DELETE FROM lehrertabelle WHERE id = " . (int)$_GET['id'];
    $result = mysql_query ($query);
    echo "Lehrer Eingetragen/Geloescht";
}

?>

[nitramf]

Hi!
when i go to index.php, and go to the Source Code, this is in it:

<b>Notice</b>:  Constant MYSQL_HOST already defined in <b>/var/www/web1/html/neu/php/config.php</b> on line <b>5</b><br />
<br />
<b>Notice</b>:  Constant MYSQL_USER already defined in <b>/var/www/web1/html/neu/php/config.php</b> on line <b>6</b><br />

<br />
<b>Notice</b>:  Constant MYSQL_PASS already defined in <b>/var/www/web1/html/neu/php/config.php</b> on line <b>7</b><br />
<br />
<b>Notice</b>:  Constant MYSQL_DATABASE already defined in <b>/var/www/web1/html/neu/php/config.php</b> on line <b>8</b><br />

Here is my config.php:

<?php
    // config.php
    error_reporting(E_ALL);

define('MYSQL_HOST',     'localhost');
define('MYSQL_USER',     'web1');
define('MYSQL_PASS',     'examplePassword');
define('MYSQL_DATABASE', 'usr_web1_5');
?>

I can´t save and delete Teachers 😢
Here my index.php:

<?php
error_reporting(E_ALL);
# Konfigurationsdatei laden:
include("config.php");



$db_link = mysql_connect(MYSQL_HOST, MYSQL_USER, MYSQL_PASS);

if($db_link) {
    echo "Verbindung wurde aufgebaut<br />\n";
    echo "In der Variable steht folgendes: ".$db_link;
} else {
    echo "Es konnte keine Verbindung aufgebaut werden";
}

#======= Aktionen ausführen:
// Falls ein Lehrer zur Löschung übergeben wurde:#
if(!empty($_REQUEST['lehrerloeschen'])) {

   $loeschen=mysql_query("DELETE FROM `lehrertabelle` WHERE `id`='".$_REQUEST['lehrerloeschen']."'");
echo mysql_errno() . ": " . mysql_error(). "\n";
};

# Falls ein Lehrer zum Speichern eingetragen wird:
if(!empty($_REQUEST["vorname"]) AND !empty($_REQUEST['name'])) {
   $speichern=mysql_query("INSERT INTO `lehrertabelle` VALUES(NULL, '".$_REQUEST['name']."', '".$_REQUEST['vorname']."')");
};


#======= Löschformular:
mysql_select_db('usr_web1_5');
$lehrer=mysql_query("SELECT * FROM `lehrertabelle` ORDER BY `name` ASC");
echo mysql_errno() . ": " . mysql_error(). "\n";
#======= Wenn Lehrer eingetragen sind Auswahlliste erstellen:

if("mysql_num_rows($lehrer)>=1") {
   ?>
  <form action="lehreradmin.php" method="POST">
      <select name="lehrerloeschen">
   <?php
include("config.php");
   while($dieserlehrer=mysql_fetch_array($lehrer)) {
      ?><option value="<?php echo $dieserlehrer['id']; ?>"><?php echo $dieserlehrer['name'].", ".$dieserlehrer['vorname']; ?></option><?php
   };
   ?></select><input type="submit" value="L&ouml;schen!" /></form>
   <?php
}
# Ansonsten Meldung ausgeben:
else {
   echo "<p>Keine Lehrkr&auml;fte eingetragen!</p>";
};

# Darunter ein Formular zum Hinzufügen eines neuen Lehrers:
?>
<form action="./lehreradmin.php" method="POST">
   Nachname: <input type="text" name="name" size="30" /><br />
   Vorname: <input type="text" name="vorname" size="30" /><br />
   <input type="submit" value="Speichern!" />
</form>

My lehreradmin.php:

<?php
error_reporting(E_ALL);
include 'config.php';
// Konfigurationsdatei laden
$db = mysql_connect(MYSQL_HOST, MYSQL_USER, MYSQL_PASS);
mysql_select_db('usr_web1_5');
echo mysql_errno() . ": " . mysql_error(). "\n";
if (isset($_GET['vorname'], $_GET['id'])) {
    $query = "DELETE FROM lehrertabelle WHERE id = " . (int)$_GET['id'];
    $result = mysql_query ($query);
    echo "Lehrer Eingetragen/Geloescht";
}

?> 

Please help me 🙂

nitramf

[Weedpacket]

...which means you're including the config.php file twice. One here:

# Konfigurationsdatei laden:
include("config.php"); 

And once here:

     <select name="lehrerloeschen">
   <?php
include("config.php"); 

[nitramf]

Thx 🙂

But i can´t insert and delete Teachers 🙁

nitramf

[nitramf]

Can´t anyone help me? 🙁

[jmack159]

when you include your config file, use include_once, that will ensure you are only including the file once, which is where your getting the errors you posted above from. what, if any, mysql errors are you getting?

[nitramf]

I get no other errors, that confuses me :eek:
The Script does not insert/delete Teachers.

nitramf

[jmack159]

once you form your query, try printing them:

echo $query;

in index.php you do not select a database to work with until after your insert/delete queries, but you select your db right before the select query. is it only the queries in index.php that are failing? also, try this for your queries:

$result = mysql_query($query) or die(mysql_errno().mysql_error());

this will cause the script to print out the sql errors, then it will exit immediately.

[nitramf]

This i get, when i try to insert an Teacher.
Notice: Undefined index: id in /var/www/web4/html/neu/php/lehreradmin.php on line 9
Lehrer Eingetragen/Geloescht

[jmack159]

that means that $GET['id'] is not set. in the query string is there a parameter named id? if your not sure try:

echo $_SERVER['REQUEST_URI'];