What's wrong with the code

izbryte

I know this is really dumb and I apologize in advance. I have a form with one textbox. If the user types the right "password" in the textbox they are then sent to that url. So if I have a website "http://www.correct_password.com" and they type in "correct_password" then they go there. Here's the code I have but it's not working. Is there something that's obviously wrong?

if (isset($_POST['submit'])) { // Handle the form.

// Check for a name.
if (strlen($_POST['PASSWORD']) < 0){
	echo '<p>You forgot to enter your event registration code.</p>';
}

	elseif ($_POST['PASSWORD'] == 'correct_password'){
	header ("Location: http://www.correct_password.com");
}
else {
	echo '<p>You did not enter a valid event registration code.</p>';

}
}
else{
echo '<p>No Submit.</p>';
}

Piranha

So, what is happening when you have the right password?

Do you use caps in the form for the word PASSWORD?

izbryte

Piranha wrote:
So, what is happening when you have the right password?

It's showing the "No Submit." error.

Piranha wrote:
Do you use caps in the form for the word PASSWORD?

Yes.

Here's the form in case that helps...

<form action="event-registration.php" method="POST">
<td><input type="text" name="PASSWORD" value="" size="15"></td>
	<tr>
		<td><input type="image" src="MD002gifs/btn_submit.gif" border="0">
		<input type="hidden" name="CHECK" value="YES"></td>
	</tr></form>[/QUOTE]

Piranha

There is the problem. You don't have an input called submit, but it is needed in the handling of the form.

shamly

as piranha mentioned you dont have a post variable named SUBMIT so first try using

if (isset($_POST['check'])) { // Handle the form.

next point is length if password entered is less than 1. Make sure to use trim() as well

if (strlen(trim($_POST['PASSWORD'])) < 1){

izbryte

OOPS! I'm sooo sorry! I've been playing with this too much I gave you the wrong form! Here's the latest one: (sorry again)

<form action="checklink.php" method="POST">
<td><input type="text" name="PASSWORD" value="" size="15"></td>
<tr>
<td><input name="submit" type="image" id="submit" src="MD002gifs/btn_submit.gif" alt="Submit" border="0"></td>
</tr></form>

and I've updated the code with trim so now it's:

if (isset($_POST['submit'])) { // Handle the form.

// Check for a name.
if (strlen(trim($_POST['PASSWORD'])) < 0){
	echo '<p>You forgot to enter your event registration code.</p>';
}

	elseif ($_POST['PASSWORD'] == 'correct_password'){
	header ("Location: http://www.correct_password.com");
}
else {
	echo '<p>You did not enter a valid event registration code.</p>';

}
}
else{
echo '<p>No Submit.</p>';
}

But I'm still having the same problem..."no submit"

Weedpacket

See http://www.php.net/manual/en/language.variables.external.php
If you look at the contents of the $_POST array you'll see that because you're using an image submit there is no element called "submit"; instead there are elements called "submit_x" and "submit_y".

For one thing, since you're not actually using the image submit for its intended purpose (server-side image maps) you might as well just use an ordinary submit button; use a stylesheet to specify its background image, size, and all that.

For another, since you want to verify the value of $_POST['PASSWORD'] you'll need to verify if that exists before trying to validate its contents. And if you're going to do that, you don't need to look at the value of the submit field anyway.

Piranha

Never trust the value from a submit button to be passed on, in some cases it won't be. Instead use a hidden input. But for this, do as Weedpacket are saying.

bradgrafelman

You've hit an instance where IE (by sheer dumb luck, maybe?) follows standards yet FireFox doesn't. If you tried this same form in FireFox instead of IE, it'd probably work.

As Weedpacket points out, the browsers don't have to submit the 'submit' element, but instead the 'submit_x' and 'submit_y' elements. FireFox, however, will submit all 3.

EDIT: Bwah? Now FF is doing the same as IE... but I swear FireFox did this before... have they fixed this in recent versions?...