Working Yesterday Broken Today

[whobutsb]

So I have this script, I didn't change it at all in the past couple of days and all of a sudden its not working. I keep getting my own error message that the picture file i'm uploading is not a .jpg file when it clearly is. Here is the code, is there something I'm missing?

<?php
$title = strip_tags(trim($_POST['title']));
$teaser = strip_tags(trim($_POST['teaser']));
$content = strip_tags(trim($_POST['content']));
$date = $_POST['date'];

if (isset($_POST["Submit"])) 
{
//upload directory.
//change to fit your need eg. files, upload .... etc.
$upload_dir = "_images/right_thing/";
//number of files to upload.
$num_files = 1;
//the file size in bytes.
$size_bytes =151200; //51200 bytes = 50KB.
//Extensions you want files uploaded limited to.
$limitedext = array(".jpg",".jpeg");

define ("FILE_DIR", "_images/right_thing/");
if (is_uploaded_file($_FILES['file']['tmp_name'])) {
	if ($_FILES['file']['type'] != "application/".$limitedext) {
		echo "Pictures Must Be in .JPG Format!";
		}
	else {
$name = $_POST['title'];
$result = move_uploaded_file($_FILES['file']['tmp_name'],FILE_DIR."/$name.jpg");
if ($result == 1) echo "File Successfuly Uploaded.";
	else {
echo "There was problem uploading the file";
$query = "INSERT INTO Right_thing (date, title, teaser, content, image) VALUES ('$date', '$title', '$teaser', '$content', '$title')";
$result = mysql_query($query) or die ("couldn't add entry");
	}
}
}
}
?>

[Kudose]

whobutsb wrote:

I keep getting my own error message that the picture file i'm uploading is not a .jpg file when it clearly is.

Print out the file type with your error message.

Your image may be a JPEG, but in PJPEG format or something else.

[whobutsb]

Thanks alot for the help. I'm trying to create alittle announcement widget for our companies website on this page we have a title, teaser content, content, and the picture. I have one more question on my page I have a table which displays all the news stories and their pictures. Next to each one I have an "Edit" and "Delete" which will do as they are stated. I'm just not sure how to make them work or have the data be posted in the edit fields. Any help would be great. Here is my code for the page:

<form enctype="multipart/form-data" name="add" method="post" action="">
<table width="75%" border="0">
  <tr>
    <td width="16%"><div align="right">Title</div></td>
    <td width="84%"><input name="title" type="text" id="title"></td>
    </tr>
  <tr>
    <td><div align="right">Teaser Content</div></td>
    <td><textarea name="teaser" id="teaser"></textarea></td>
    </tr>
  <tr>
    <td><div align="right">Content</div></td>
    <td><textarea name="content" id="content"></textarea></td>
  </tr>
  <tr>
    <td><div align="right">Image</div></td>
    <td><input name="file" type="file" id="file"> 
    (File Must Be in .jpg format)</td>
  </tr>
</table>
<p><br>
  <input name="date" type="hidden" id="date" value= "<?php echo date('Y-m-d'); ?>">
</p>
<p>
  <input type="submit" name="Submit" value="Submit"> 
  </p>
</form>


<p>&nbsp;</p>
<p>&nbsp;</p>
<p>&nbsp;</p>
<table width="75%" border="1">
  <tr>
    <td width="2%">ID</td>
    <td width="7%">Date</td>
    <td width="19%">Title</td>
    <td width="50%">Content</td>
    <td width="22%">Image</td>
  </tr>
<?php
  do { ?>
  <tr>
    <td><?php echo $row_right_thing ['id']; ?></td>
    <td><?php echo $row_right_thing ['date']; ?></td>
    <td><?php echo $row_right_thing ['title']; ?></td>
    <td><?php echo $row_right_thing ['content']; ?></td>
    <td><img src= "_images/right_thing/<?php echo $row_right_thing ['image'];?>.jpg"></td>
	<td><input type="submit" name="edit" value="Edit" onclick="" /></td>
	<td><input type="submit" name="delete" value="Delete" onclick="" /></td>
  </tr>
  <?php	}

 while ($row_right_thing = mysql_fetch_assoc($result_right_thing));
 ?>

</table>

[Kudose]

Something like this should get you started:

<?php
  /** check for delete via $_GET **/
  if(isset($_GET['delete']) && is_numeric($_GET['delete'])){
    $toDelete = $_GET['delete'];
    /** setup the SQL to delete the record and run it **/
  }

  /** check for from post --- "edit" button click **/
  if(isset($_POST['edit'])){
    /** setup SQL and run it **/
  }
?>
<form enctype="multipart/form-data" name="add" method="post" action="">
  <table width="75%" border="0">
    <tr>
      <td width="16%">
        <div align="right">Title</div>
      </td>
      <td width="84%">
        <input name="title" type="text" id="title">
      </td>
    </tr>
    <tr>
      <td>
        <div align="right">Teaser Content</div>
      </td>
      <td>
        <textarea name="teaser" id="teaser"></textarea>
      </td>
    </tr>
    <tr>
      <td>
        <div align="right">Content</div>
      </td>
      <td>
        <textarea name="content" id="content"></textarea>
      </td>
    </tr>
    <tr>
      <td>
        <div align="right">Image</div>
      </td>
      <td>
        <input name="file" type="file" id="file"> (File Must Be in .jpg format)
      </td>
    </tr>
  </table>
  <p><br><input name="date" type="hidden" id="date" value= "<?php echo date('Y-m-d'); ?>"> </p>
  <p><input type="submit" name="Submit" value="Submit"></p>
</form>
<p>&nbsp;</p> <p>&nbsp;</p> <p>&nbsp;</p>
<table width="75%" border="1">
  <tr>
    <td width="2%">ID</td>
    <td width="7%">Date</td>
    <td width="19%">Title</td>
    <td width="50%">Content</td>
    <td width="22%">Image</td>
  </tr>
  <?php while(($row_right_thing = mysql_fetch_assoc($result_right_thing) !== FALSE) { ?>
  <tr>
    <td><?php echo $row_right_thing['id']; ?></td>
    <td><?php echo $row_right_thing['date']; ?></td>
    <td><?php echo $row_right_thing['title']; ?></td>
    <td><?php echo $row_right_thing['content']; ?></td>
    <td><img src= "_images/right_thing/<?php echo $row_right_thing['image'];?>.jpg"></td>
    <td><input type="submit" name="edit" value="Edit" /></td>
    <td><input type="button" name="delete" value="Delete" onclick="window.location.href='http://www.mywebsite.com/thispage.php?delete=<?php echo $row_right_thing['id']; ?>';" /></td>
  </tr>
  <?php } ?>
</table>

You will need to setup the SQL and run it, if you don't know how just post back that you don't.

You'll also need to edit the URL in the delete buttons onclick.

[Kudose]

Did you get the file upload problem solved? If not, what happened when you printed the file type?

[whobutsb]

Yea I was able to get the file upload problem solved and the delete row solved. Thanks for your help. I'm sorry for doing this to you but I'm now trying to get the image to get resized when it is uploaded to the directory. As of right now it is uploading fine but the image doesn't resize it just remains its current size. Heres the code I added:

<?php
if (isset($HTTP_POST_VARS["Submit"])) 
		{
$title = strip_tags(trim($_POST['title']));
$teaser = strip_tags(trim($_POST['teaser']));
$content = strip_tags(trim($_POST['content']));
$date = $_POST['date'];
//upload directory.
//change to fit your need eg. files, upload .... etc.
$upload_dir = "_images/right_thing/";
//number of files to upload.
$num_files = 1;
//the file size in bytes.
$size_bytes =151200; //51200 bytes = 50KB.
//Extensions you want files uploaded limited to.
$limitedext = array("jpg","jpeg");

define ("FILE_DIR", "_images/right_thing/");
if (is_uploaded_file($_FILES['file']['tmp_name'])) {
	if ($_FILES['imageupload']['type'] == "image/gif" OR $_FILES['imageupload']['type'] == "image/pjpeg" OR $_FILES['imageupload']['type'] == "image/jpeg") {
		echo "Pictures Must Be in .JPG Format!";
		}
	else {
$name = $_POST['title'];
//Resize the image
$imgsize = GetImageSize($_FILES['file']['tmp_name']);
 if (($imgsize[0] > 50) || ($imgsize[1] > 50))
    {
	list ($width, $height) = $imgsize;
	$new_width = 50;
	$new_height = 50;
	$image_p = imagecreatetruecolor($new_width, $new_height);
	$image = imagecreatefromjpeg($_FILES['file']);
	imagecopyresampled ($image_p, $iamge, 0, 0, 0, 0, $new_width, $new_height, $width, $height);
	imagejpeg(image_p, null, 100);
	}
$result = move_uploaded_file(imagejpeg(image_p, null, 100),FILE_DIR."/$name.jpg");
// Resize the Picture for Thumbnail Size

//Insert Information Into Database
if ($result == 1) {
$query = "INSERT INTO Right_thing (date, title, teaser, content, image) VALUES ('$date', '$title', '$teaser', '$content', '$title')";
$result = mysql_query($query) or die ("couldn't add entry");
 echo "File Successfuly Uploaded.";
 }
	else {
echo "There was problem uploading the file";

}
}
}
}

[bradgrafelman]

Just a quick note... $_FILES['file']['tmp_name'] is optional and provided by the browser; some browsers may not provide this, some people may upload .exe files and say "Oh sure, that's a JPEG, don't worry about it..." .

This line:

    $image = imagecreatefromjpeg($_FILES['file']); 

isn't quite right; you need to pass the location of the file to the function. Since you haven't moved it yet, this would be the 'tmp_name' index.

As for this bit of code:

    imagejpeg(image_p, null, 100); 
    } 
$result = move_uploaded_file(imagejpeg(image_p, null, 100),FILE_DIR."/$name.jpg"); 

1. Why are you calling imagejpeg() twice?
2. You forgot to put dollar signs in front of image_p.

Also... looks like your script is vulnerable to SQL injection attacks; you should sanitize all user-supplied data via a function such as [man]mysql_real_escape_string/man before you ever place it in a query.