uploading a PDF

[yanks6rule]

I am having problems uploading PDF files. I don't need this code to be complex as there is not going to be a lot of traffic at this site. All I want to be able to do is for a user in my group to upload a PDF to a website that is then written to a directory that can be accessed later for web viewing.

Here is the basic code I am using:

<?php

// Where the file is going to be placed
$target_path = "/a random path/pdfs/";
$today = time();

/ Add the original filename to our target path.

Result is "uploads/filename.extension" /
$fn = "$today";
$fnup = "$fn";
$fnup .= ".pdf";

$target_path .= "$fnup";
if ($_FILES['uploadedfile']['error'] > 0) {

echo "ERROR: ". $_FILES['uploadedfile']['error'] . " (value between 1-4)";

} else {

if(move_uploaded_file($_FILES['uploadedfile']['tmp_name'], $target_path)) {
echo "The file $fn
has been uploaded";
} else{
echo "There was an error uploading the file, please try again!";
}
}

?>

I have a one form field that gets processed by this form. Now the problem is two fold. First only about half the PDF's I try uploading work. If you print the array it grabs the file name but nothing else I get an error of 2, with a size of 0. Also when I try viewing after upload the file is corrupted and I can no longer view it. Sorry if I am missing something obvious, I am new to file uploads.

Thanks
Bob

[Kudose]

Two things I can think of.

1. Is your form enctype multipart/form-data?
2. You are getting error number 2 because the file exceeds the MAX_FILE_SIZE directive as stated in the manual.

[yanks6rule]

I have read through many of the previous posts and I changed my php.ini (just to check this) to post_max_size = 100M and upload_max_filesize to 50M the file I am trying to upload is only 292kb, so it should be fine.

My form has this header <form enctype="multipart/form-data" method="POST" action="random php file">

The wierd part is that I can upload certain PDF's and not other ones. If I change my code and do a print_r($_FILES) it gets the name but it leaves the type blank and it says the size is 0 with an error number 2. I hope this helps a little more.

Thanks
Bob

[Kudose]

Without having the "kind of functional" code, I can't be of much more help.

Sorry.

[jmack159]

i would try throwing $SERVER['DOCUMENT_ROOT'] in front of your $target_path. i would switch around your if/else for moving the uploaded file. i would write:

if(move_uploaded_file($_FILES['uploadedfile']['tmp_name'], $target_path)) {
     echo "The file $fn has been uploaded";
} else {
     echo "There was an error uploading the file, please try again!";
     echo "ERROR: ". $_FILES['uploadedfile']['error'] . " (value between 1-4)";
}

move_uploaded_file will return false on failure, and checks to make sure that the file is a valid uploaded file.

do you have a form field that looks like this in your form?
<input type="hidden" name="MAX_FILE_SIZE" value="30000" />
(value is size in bytes)
that is the max_file_size that php is referring to in the manual, not the php.ini

an error of 1 would be a violation of the upload_max_filesize in php.ini, 2 is the max_file_size in the actual html form.

i would remove the spaces from your target path. looking throught the manual, i saw this:

Due to the large amount of directory listing styles we cannot guarantee that files with exotic names (like containing spaces) are handled properly.

the only other thing i would suggest, but i don't think is causing the error is to simplify the creation of the target path string. you can get the same result, but much easier to read, by using:

$target_path = "/a_random_path/pdfs/".time()."pdf";

hope something in here helps!

[bradgrafelman]

jmack159 wrote:

2 is the max_file_size in the actual html form.

Speaking of the error code returned in file uploads ([man]features.file-upload.errors[/man]), have you added a MAX_FILE_SIZE hidden element to your form? If so, what did you set the value to be?

[yanks6rule]

Gentlemen thank you for the suggestions. I went back and looked at my code and I am going to post the form and the php file that processes the form to show you what I have done. I have taken some of your suggestions and I don't know if I am working with a bad PDF, if you want I post a random PDF that isn't working for me as well. Let me know.

Form

<html>
<head>
<title>PDF Upload</title>
</head>
<body>

<form enctype="multipart/form-data" action="uploader.php" method="POST">
<input type="hidden" name="MAX_FILE_SIZE" value="100000" />
Choose a file to upload: <input name="uploadedfile" type="file" /><br />
<input type="submit" value="Upload File" />
</form>
</body>
</html>

PHP to process form

<?php

// Where the file is going to be placed
$target_path = "/opt/lampp/papers/pdfs/";
$today = time();

/* Add the original filename to our target path.  

Result is "uploads/filename.extension" */
$fn = "$today";

$target_path = "/opt/lampp/htdocs/papers/pdfs/".$today."pdf";
if(move_uploaded_file($_FILES['uploadedfile']['tmp_name'], $target_path)) {
     echo "The file $fn has been uploaded";
} else {
     echo "There was an error uploading the file, please try again!<br />";
     echo "ERROR: ". $_FILES['uploadedfile']['error'] . " (value between 1-4)";
} 
?>

Thank you

[jmack159]

are you getting any errors with this new code?

your missing a . after you reopen quotes before the string 'pdf'

do you know your two target paths are different? why give it a value then 7 lines later give it a completely new value?

do you have display_errors set to on?

[bradgrafelman]

Okay, well, you know what the error message means... so, increase the MAX_FILE_SIZE_LIMIT (since it's currently set at ~97.6kb).

[yanks6rule]

Hey thanks it looks like that fixed the problem I am going to try doing a couple more uploads with a more complicated form and see if I can get that to work as well.

I want to work on one more script that was not working with PDF's as well before I mark resolved. Thanks everyone.

Bob