Corrupt Gif

[Shawazi]

The following code makes a thumbnail fine for JPGs but not GIFs. I can actually view the corrupt GIF on my site, but if I try to resample it again later it messes up. Also if I download it to my computer and open it with IE7 it only shows a red X.

$target_id = imagecreatetruecolor($dest_x, $dest_y);
$target_pic = imagecopyresampled($target_id,$source_id_original, 0, 0, 0, 0, $dest_x, $dest_y, $size[0],$size[1]);
$thumblink = $thumb_dir.$prefix.$name;
if (ereg("\.gif$", $main))
{
	$source_id = imagegif($target_id,$thumblink, $quality);
	$source_id_original = imagecreatefromgif($thumblink);
}
else 
{
	$source_id = imagejpeg($target_id,$thumblink, $quality);
	$source_id_original = imagecreatefromjpeg($thumblink);
}

[bradgrafelman]

How is that code supposed to work? You run the imagecopyresampled() function and expect it to pull data from $source_id_original which isn't defined until inside the if() statement.

Try switching the order of things so that your variables are defined before you attempt to use them.

[Shawazi]

Sorry I missed being more clear. $source_id_original is passed into this function as the original image. The function then returns a new $source_id_original in case I want to manipulate the image more. If $source_id_original wasn't defined, the image would not show up at all.