[RESOLVED] Is this wrong ?

kostis12345

I have put this code:
<php
echo"<a href=/index.php>Home</a><br/>;?>
<php
if(isset($COOKIE['gryffindor']))
echo"<a href=/forum/viewforum.php?id=7>Common Room</a>
elseif(isset($COOKIE['slytherin']))
echo"<a href=/forum/viewforum.php?id=16>Common Room</a>
else
echo"You haven't been sorted yet";
?>
IS something wrong with it ?

laserlight

Yes. You would find out if you indented your code properly and used a text editor with syntax highlighting. Oh, and you should enclose PHP code posted in php forum bbcode tags.

<?php
echo "<a href=/index.php>Home</a><br/>;

if (isset($_COOKIE['gryffindor']))
    echo "<a href=/forum/viewforum.php?id=7>Common Room</a>
elseif (isset($_COOKIE['slytherin']))
    echo "<a href=/forum/viewforum.php?id=16>Common Room</a>
else
    echo "You haven't been sorted yet";
?>

kostis12345

I get this

Parse error: parse error, unexpected T_ENCAPSED_AND_WHITESPACE, expecting T_STRING or T_VARIABLE or T_NUM_STRING in /var/www/vhosts/biglle.com/httpdocs/biglletesthomepage.php on line 4

🙁 sorry but I am new to php.

laserlight

The problem is that you did not properly delimit your strings. Since you began your strings with a double quote, you should end them with a double quote.

The other problem was that you used <php instead of <?php, but I corrected that for you.

NogDog

Notice the difference in the color highlighting between the original code LaserLight copied for you within "php" vB code tags and the following:

<?php
echo "<a href=/index.php>Home</a><br/>";

if (isset($_COOKIE['gryffindor']))
    echo "<a href=/forum/viewforum.php?id=7>Common Room</a>";
elseif (isset($_COOKIE['slytherin']))
    echo "<a href=/forum/viewforum.php?id=16>Common Room</a>";
else
    echo "You haven't been sorted yet";
?>

You also left out some semi-colons at the end of some of the echo commands, which I inserted above.

A suggestion: while you can "get away with" not using braces around the commands following if/elseif/else conditionals when the command is only one line, it's probably a good habit to go ahead and use them anyway so as to avoid logic errors later on if you add more functionality to a given condition:

<?php
echo "<a href=/index.php>Home</a><br/>";

if (isset($_COOKIE['gryffindor']))
{
    echo "<a href=/forum/viewforum.php?id=7>Common Room</a>";
}
elseif (isset($_COOKIE['slytherin']))
{
    echo "<a href=/forum/viewforum.php?id=16>Common Room</a>";
}
else
{
    echo "You haven't been sorted yet";
}
?>

kostis12345

Thanks everyone for helping and NogDog thx a lot it worked with your way.

bradgrafelman

Don't forget to mark this thread resolved.