Help - Email problem - PHPBuilder Forums

Help - Email problem

rmorf

Hi
I am new to php and i had to deal with a website already created - so we had to move it to our server and make it work (windows server) - evrything is working fine besides one thing - there is an email sending function on the page which when you get it to send something to a certain email it generates and error and gives me Couldnt execute query. All other functions on the page are working so i dont know what the problem might be. So here is the code:

<?
    include('../cms/database/database.php');
    include('proj.php');
    include('shortlist.php'); 

?>

<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.01 Transitional//EN">
<html>
<head>
<title>Rascals Modeling Agency</title>
<meta http-equiv="Content-Type" content="text/html; charset=iso-8859-1">
<link href="css/rascals.css" rel="stylesheet" type="text/css">

<?
    $client = $HTTP_GET_VARS['client'];

if (!$client) {
   $client = "boy";
}

if(!isset($HTTP_GET_VARS['searchnames'])){ 
$searchnames = "";	
} else {
$searchnames = $HTTP_GET_VARS['searchnames'];	
}

if(!isset($HTTP_GET_VARS['searchheight'])){ 
$searchheight = "";	
} else {
$searchheight = $HTTP_GET_VARS['searchheight'];	
}


if(!isset($HTTP_GET_VARS['searcheyes'])){ 
$searcheyes = "";	
} else {
$searcheyes = $HTTP_GET_VARS['searcheyes'];	
}

if(!isset($HTTP_GET_VARS['searchhair'])){ 
$searchhair = "";	
} else {
$searchhair = $HTTP_GET_VARS['searchhair'];	
}


if(!isset($HTTP_GET_VARS['searchshoes'])){ 
$searchshoes = "";	
} else {
$searchshoes = $HTTP_GET_VARS['searchshoes'];	
}

if(!isset($HTTP_GET_VARS['searchage'])){ 
$searchage = "";	
} else {
$searchage = $HTTP_GET_VARS['searchage'];
$searchagetype = $HTTP_GET_VARS['searchagetype'];
if ($searchagetype != "m"){	
		$searchyearquery = calculate_year($searchage, $searchage);
} else {
	$searchyearquery = calculate_month($searchage, $searchage);	
}
}

if(!isset($HTTP_GET_VARS['searchyear'])){ 
$searchyear = "";	
} else {
$searchyear = $HTTP_GET_VARS['searchyear'];	
	$searchyearquery = calculate_year($searchyear, $searchyear);	
}

if(!isset($HTTP_GET_VARS['searchmonth'])){ 
$searchmonth = "";	
} else {
$searchmonth = $HTTP_GET_VARS['searchmonth'];	
if ($searchmonth) {
	$searchyearquery = calculate_month($searchmonth, $searchyear);	
}	
}


if(!isset($HTTP_GET_VARS['lower'])){ 
$lower = "";	
} else {
$lower = $HTTP_GET_VARS['lower'];	
}

if(!isset($HTTP_GET_VARS['upper'])){ 
$upper = "";	
} else {
$upper = $HTTP_GET_VARS['upper'];	
}

if(!isset($HTTP_GET_VARS['largeimage'])){ 
$largeimage = "";	
} else {
$largeimage = $HTTP_GET_VARS['largeimage'];	
}

if(!isset($HTTP_GET_VARS['upperage'])){ 
$upperage = "";	
} else {
$upperage = $HTTP_GET_VARS['upperage'];	
}

if(!isset($HTTP_GET_VARS['lowerage'])){ 
$lowerage = "";	
} else {
$lowerage = $HTTP_GET_VARS['lowerage'];	
}

$yearquery = calculate_year($upperage, $lowerage);	

if (!$lower){
$lower = 0;
}

if (!$upper){
$upper = 10;
}

$query = "SELECT *,RIGHT(dateofbirth,4) AS YEAR,MID(dateofbirth,4,2) AS MONTH FROM person WHERE type = '$client' AND _release = 'yes'"; 

if ($yearquery) {
    $query = "$query AND ($yearquery)";
}

if ($searchyearquery) {
    $query = "$query AND ($searchyearquery)";
}


if ($searchheight) {
    $query = "$query AND height = '$searchheight'";	
}

if ($searchnames) {
    $query = "$query AND firstname = '$searchnames' OR surname = '$searchnames'";	
}

if ($searcheyes) {
    $query = "$query AND eyecolour = '$searcheyes'";	
}
if ($searchhair) {
    $query = "$query AND haircolour = '$searchhair'";	
}
if ($searchshoes) {
    $query = "$query AND shoesize = '$searchshoes'";	
}
//    if ($searchage) {
//	    $query = "$query AND dateofbirth = '$searchage'";	
//    }


if ($action == "viewshortlist"){
	$query = "SELECT *,RIGHT(dateofbirth,4) AS YEAR,MID(dateofbirth,4,2) AS MONTH FROM person"; 
$shortlistquery = CMS_view_shortlist($_SESSION['shortlist']);
$query = "$query $shortlistquery";
} 	

$query = "$query AND _release = 'yes'";


//    echo $query;
//    echo $shortlistquery;		

$total_result = query_database("$query");

$total_num = mysql_num_rows($total_result);

if ($action != "viewshortlist"){
	$query = "$query ORDER by YEAR DESC,MONTH ASC LIMIT $lower,$upper";
}	

//    echo $query;	

$result = query_database("$query");

$result2 = query_database("$query");

$clientid = $HTTP_GET_VARS['clientid'];

if(!isset($HTTP_GET_VARS['clientid'])){
$rowx = mysql_fetch_array($result2);
$clientid = $rowx['id'];
} else {
if ($clientid != ""){
    $clientid = $HTTP_GET_VARS['clientid'];
}else{
    $rowx = mysql_fetch_array($result2);
    $clientid = $rowx['id'];	
}	
}


$client_result = query_database("SELECT * FROM person WHERE id = '$clientid'");

while ($row = mysql_fetch_array($client_result)) {

$large_id = $row['id'];
$large_firstname = $row['firstname'];
$large_surname = $row['surname'];
$large_dateofbirth = $row['dateofbirth'];
$large_height = $row['height'];
$large_eyecolour = $row['eyecolour'];
$large_haircolour = $row['haircolour'];
$large_shoesize = $row['shoesize'];
$large_image1 = $row['image1'];
$large_image2 = $row['image2'];
$large_image3 = $row['image3'];
$large_image4 = $row['image4'];
$large_image5 = $row['image5'];
$large_image6 = $row['image6'];

}
?>

And this is for the email form

<? if ($shortlist){  

					       echo "<a href=\"";
					       echo rascals_url($clientid,$client,$lower,$upper,$searchheight,$searcheyes,$searchhair,$searchshoes,$searchage,"",$lowerage,$upperage,"viewshortlist","",$searchnames);
					       echo "\" class=\"main\"> View shortlist</a>  |  ";
					       echo "<a href=\"";
					       echo rascals_url($clientid,$client,$lower,$upper,$searchheight,$searcheyes,$searchhair,$searchshoes,$searchage,"",$lowerage,$upperage,"deleteshortlist","",$searchnames);
					       echo "\" class=\"main\"> Delete shortlist</a>";
					       echo "<br></form>";
					       echo "<form action=\"rascals.php\">";
					       echo "Email to&nbsp;<input type=\"text\" name=\"emailaddress\" class=\"textfield\">";
					       echo "<input type=\"hidden\" name=\"clientid\" value=\"$clientid\">";
					       echo "<input type=\"hidden\" name=\"client\" value=\"$client\">";
					       echo "<input type=\"hidden\" name=\"lower\" value=\"$lower\">";
					       echo "<input type=\"hidden\" name=\"upper\" value=\"$upper\">";
					       echo "<input type=\"hidden\" name=\"searchheight\" value=\"$searchheight\">";
					       echo "<input type=\"hidden\" name=\"searchhair\" value=\"$searchhair\">";
					       echo "<input type=\"hidden\" name=\"searchshoes\" value=\"$searchshoes\">";
					       echo "<input type=\"hidden\" name=\"searchage\" value=\"$searchage\">";
					       echo "<input type=\"hidden\" name=\"lowerage\" value=\"$lowerage\">";
					       echo "<input type=\"hidden\" name=\"upperage\" value=\"$upperage\">";
					       echo "<input type=\"hidden\" name=\"action\" value=\"emailshortlist\">";
					       echo "<input type=\"submit\" value=\"Go\" class=\"button\">";
				       	       echo "</form>";
					       } 
					   ?>

Please help me i dont know what to do.

Thanks inadvance

Scriptmaker

The actual text of the error would help. Also, don't type a space after the first bracket of the bbCode

[code=php]

[/code] otherwise it just formats it as plain text.

There could be a problem with using the old Get variables like you are using. As I understand, the $HTTP_GET_VARS array is still supported, but isn't superglobal, so you need to say

global $HTTP_GET_VARS;

bradgrafelman

Just FYI, the board's bbcode tags (

) don't have spaces in them. I've already edited your post for you (since it was stretching the page), but please keep this in mind for the future.

EDIT:

Scriptmaker wrote:
As I understand, the $HTTP_GET_VARS array is still supported, but isn't superglobal, so you need to say
global $HTTP_GET_VARS; 

On the contrary, you shouldn't use $HTTP_GET_VARS (or any other $HTTP*VARS variable, for that matter) at all! These are deprecated (and may not even be enabled on your server). Instead, you should use the $_GET superglobal (as well as the others like it; more info at: [man]variables.predefined[/man]).

Also, if you are having SQL query errors, then debug your SQL query! Common method of doing so is:

$query = 'sql query here';
$exec = mysql_query($query) or die('MySQL error: ' . mysql_error() . '<hr>Query: ' . $query);

EDIT2: Also, the '<?' short tags are yet another deprecated coding practice; you should instead use the full '<?php' tags.