foreach - INSERT help

[focus310]

Hello:

I have a form which consists of two array variables (current and prior). I need to insert the results into a table. When I run my script, the table is empty.

I did some testing/troubleshooting to see if my values are coming through and they are. I echoed all my form variables and the results were correct. I am having difficulty inserting the results into a table. I need to insert both array variables (current and prior). I first attempted to try current and my table was empty. I don't know how to even begin to include the second array in my query for the insert.

Can someone help me out? I commented by query statements because I was testing my variables.

My table has four columns: id, behavior_name, current, prior. Here is my code.

Thank you for the help.

<?php
require_once ('mysql_connect.php');

if (isset($_POST['submitted'])) {


  //validate form data  

if ( !empty ( $_POST['behavior']) )  { 
     $behavior = escape_data($_POST['behavior']);   

   } else { 
     $behavior = FALSE; 
   }   

if ( isset ( $_POST['current']) && (is_array($_POST['current'])))  { 
     $current = TRUE;   

   } else { 
     $current = NULL;
   }    

if ( isset ( $_POST['prior']) && (is_array($_POST['prior'])))  { 
     $prior = TRUE;   

   } else { 
     $prior = NULL;


   } 


if ($behavior && $current && $prior) {

echo $behavior;

foreach ($_POST['current'] as $value)  

    {
      echo "<li>$value</li>\n";
}
echo'</ul>';

foreach ($_POST['prior'] as $vprior)  

    {
      echo "<li>$vprior</li>\n";
}
echo'</ul>';

//$query='INSERT INTO behavior(behavior_name, current, prior)
//        VALUES '; 
//          foreach($_POST['current'] as $cvalue) {
//            $query .="($behavior, $cvalue), ";
//       }
//   $query = substr($query,0,-2);
//  $result=@mysql_query($query);


}
}        

else { 
    echo 'No good.';

}
?>

<form action="behavior_form_test.php" method="post">
<table>
<tr><td valign="top">
<input type="checkbox" name="behavior" id="Abuse" value="Abuse">Abuse</td>
<td align="top"><input type="checkbox" name="current[]" id="Physical" value="Physical">Physical<br>
<input type="checkbox" name="current[]" id="Emotional" value="Emotional">Emotional<br>
<input type="checkbox" name="current[]" id="Other" value="Other">Other<br><br></td>
<td align="top"><input type="checkbox" name="prior[]" id="Physical" value="Physical">Physical<br>
<input type="checkbox" name="prior[]" id="Emotional" value="Emotional">Emotional<br>
<input type="checkbox" name="prior[]" id="Other" value="Other">Other<br><br></td>
</tr>

<tr><td><input type="checkbox" name="behavior" id="Eating Disorder" value="Eating Disorder">Eating Disorder</td></tr>
<tr><td><input type="checkbox" name="behavior" id="Aggressive" value="Aggressive">Aggressive</td></tr>
</table>
<input type="submit" name="btnSubmit" id="btnSubmit" value="Submit" class="btn" >
<input type="hidden" name="submitted" value="TRUE" />

[Piranha]

You try to insert 3 variables but only mark 2 for insert. That would be the problem. And you should echo errors to get an idea of what is wrong, but only on the development server. And you should make sure that you are not vunrable to sql injection (there are 2 more articles about it in security section). Something like this should work to solve all the problems:

$query='INSERT INTO behavior(behavior_name, current) // Only 2 variables here
        VALUES ';
          foreach($_POST['current'] as $cvalue) {
            $cvalue = escape_data($cvalue); // Safe for sql injection
            $query .="('$behavior', '$cvalue'), "; // Also safe for sql injection
       }
   $query = substr($query,0,-2);
  $result=@mysql_query($query) or die(mysql_error()); // outputs possible errors

[focus310]

Hi,

Thank you so much. It worked for both variables.

I need to include the second variable; prior. How do I go about including prior with current?

Can you have two variables in a single foreach statement?

Thanks for the help.

[Piranha]

You include prior on both places, then it will work. Look at the difference between your code and mine and you will probably get it. But you need 2 queries, 1 won't do.

Try it and you will find out. Or look in the manual, then you will know for sure.

But assuming that you have a numerical array it is easy to handle 2 arrays with a for-statement.

[focus310]

I think I see what's happening.

[focus310]

Hi,

I ran your code and it is working - sort of.

When I first attempt to run the script, the insert works correctly.
For example, I chose Abuse and then I choose Physical, Emotional. The result in the table appears as it should:
Abuse - Physical
Abuse - Emotional.

Now, when I try to chose Abuse ->Other and then choose Eating Disorder->Anorexia, the result I get in my table looks like this:
Eating Disorder->Physical
Easting Disorder->Anorexia

The table result should appear as:
Abuse->Other
Eating Disorder->Anorexia

I'm not sure why this is happening. It seems to be inserting the last chosen set of values and is not inserting the appropriate choices.

Can you help me out?

[Piranha]

Maybe, maybe not. To be able to know which I need to see the code and the query.

[focus310]

Hi,

Here is the complete script.

<?php
require_once ('mysql_connect.php');

if (isset($_POST['submitted'])) {


  //validate form data  

if ( !empty ( $_POST['behavior']) )  { 
     $behavior = escape_data($_POST['behavior']);   

   } else { 
     $behavior = FALSE; 
   }   

if ( isset ( $_POST['current']) && (is_array($_POST['current'])))  { 
     $current = TRUE;   

   } else { 
     $current = NULL;
   }    


if ($behavior && $current) {

$query='INSERT INTO behavior(behavior_name, current)  

        VALUES '; 
          foreach($_POST['current'] as $cvalue) { 
            $cvalue = escape_data($cvalue);  

            $query .="('$behavior', '$cvalue'), ";  

       } 
   $query = substr($query,0,-2); 
  $result=@mysql_query($query) or die(mysql_error());  

}
else { 
    echo 'No good.';
} 
}
?>

<form action="behavior_form_test.php" method="post">
<table>
<tr><td valign="top">
<input type="checkbox" name="behavior" id="Abuse" value="Abuse">Abuse</td>
<td align="top"><input type="checkbox" name="current[]" id="Physical" value="Physical">Physical<br>
<input type="checkbox" name="current[]" id="Emotional" value="Emotional">Emotional<br>
<input type="checkbox" name="current[]" id="Other" value="Other">Other<br><br></td>
<td align="top"><input type="checkbox" name="prior[]" id="Physical" value="Physical">Physical<br>
<input type="checkbox" name="prior[]" id="Emotional" value="Emotional">Emotional<br>
<input type="checkbox" name="prior[]" id="Other" value="Other">Other<br><br></td>
</tr>

<tr><td><input type="checkbox" name="behavior" id="Eating Disorder" value="Eating Disorder">Eating Disorder</td></tr>
<tr><td><input type="checkbox" name="behavior" id="Aggressive" value="Aggressive">Aggressive</td></tr>
</table>
<input type="submit" name="btnSubmit" id="btnSubmit" value="Submit" class="btn" >
<input type="hidden" name="submitted" value="TRUE" />

[Piranha]

The problem is the foreach-loop in the query. It will only change current, not behavior. As I said before, try another type of loop, a for-loop would probably be a good idea.

[focus310]

Hi,

I've done quite a bit of reading on the "for" loop. I understand what's happening when it is applied to conditions such as $counter < 31, etc.

I'm not testing for anything like that. I'm not sure what I'm supposed to place as my condition.

[Piranha]

Please post information about the actual data (key and value) in the arrays. Otherwise it is hard to know what loop is the best.

[focus310]

Hi,

This is what the array is currently printing:
Array
(
[behavior] => Agression
[current] => Array
(
[0] => Physical
[1] => Emotional
[2] => Physical
[3] => Object
)

This is what it should be:
Array
(
[behavior] => Abuse
[current] => Array
(
[0] => Physical
[1] => Emotional
)
[behavior] => Aggression
[current] => Array
(
[0] => Physical
[1] => Object
)

[Piranha]

But how do the arrays you get look like? I understand how the result should look, but I need to know how the arrays you recieve look like.

[focus310]

Hi,

When I run the script and print the results of the array, this is what I get:

Array
(
[behavior] => Agression
[current] => Array
(
[0] => Physical
[1] => Emotional
[2] => Physical
[3] => Object
)