"If" inside a "while" loop

[daveyc]

Hi Guys,

Is it possible to insert an "if" statement inside a "while" loop?

Here's the code i have at the moment.

$sql = "SELECT * from callbacks";
	  $result = mysql_query($sql);
		 while ($row = mysql_fetch_array($result)) { 
					$idno = $row['id'];
					$name = $row['name'];
					$number = $row['number'];
					$service = $row['service'];
					$timecall = $row['calltime'];
					$reason = $row['reason'];
					$status = $row['status'];
					if ($status == ""){
$tdcolor = "#FFFFFF";
$fontcol = "#FF0000";
					}else{
					$tdcolor = "#FF0000";
					$fontcol = "#FFFFFF";

				echo '   <tr>
          <td height="40" bgcolor="'.$tdcolor.'"><div align="center">'.$name.'</div></td>
          <td bgcolor="'.$tdcolor.'"><div align="center"><font color="'.$fontcol.'">'.$number.'</div></td>
          <td bgcolor="'.$tdcolor.'"><div align="center"><font color="'.$fontcol.'">'.$service.'</div></td>
          <td bgcolor="'.$tdcolor.'"><div align="center"><font color="'.$fontcol.'">'.$timecall.'</div></td>
          <td valign="middle" bgcolor="'.$tdcolor.'"><font color="'.$fontcol.'">
            <div align="center">
              <form id="form1" name="form1" method="GET" action="process.php" enctype="application/x-www-form-urlencoded"><input name="id" type="hidden" value="'.$idno.'"/>
              <input name="called" type="submit" id="called" value="Called" /> 
              <input name="Notcalled" type="submit" id="Notcalled" value="Not Called" />
              </form>
          </div></font></td>
		  <td bgcolor="'.$tdcolor.'"><div align="center"><font color="'.$fontcol.'">'.$reason.'</font></div></td>
        </tr>';
	 }}
				}

I understand why it's not working. Due to the use of a }, which the while loop is using. But any ideas on how i could get it working?

Thanks a bunch 🙂

Dave

[NogDog]

There is no problem with having an IF within a WHILE loop and therefore nested levels of { . . . }. However, with the code sample you've provided, the braces to not balance out: you appear to have an extra closing "}". If you more carefully indent the code, it becomes obvious that there is a mismatch somewhere:

$sql = "SELECT * from callbacks";
$result = mysql_query($sql);
while ($row = mysql_fetch_array($result)) {
   $idno = $row['id'];
   $name = $row['name'];
   $number = $row['number'];
   $service = $row['service'];
   $timecall = $row['calltime'];
   $reason = $row['reason'];
   $status = $row['status'];
   if ($status == ""){
      $tdcolor = "#FFFFFF";
      $fontcol = "#FF0000";
   }else{
      $tdcolor = "#FF0000";
      $fontcol = "#FFFFFF";

  echo '   <tr>
  <td height="40" bgcolor="'.$tdcolor.'"><div align="center">'.$name.'</div></td>
  <td bgcolor="'.$tdcolor.'"><div align="center"><font color="'.$fontcol.'">'.$number.'</div></td>
  <td bgcolor="'.$tdcolor.'"><div align="center"><font color="'.$fontcol.'">'.$service.'</div></td>
  <td bgcolor="'.$tdcolor.'"><div align="center"><font color="'.$fontcol.'">'.$timecall.'</div></td>
  <td valign="middle" bgcolor="'.$tdcolor.'"><font color="'.$fontcol.'">
  <div align="center">
  <form id="form1" name="form1" method="GET" action="process.php" enctype="application/x-www-form-urlencoded"><input name="id" type="hidden" value="'.$idno.'"/>
  <input name="called" type="submit" id="called" value="Called" />
  <input name="Notcalled" type="submit" id="Notcalled" value="Not Called" />
  </form>
  </div></font></td>
  <td bgcolor="'.$tdcolor.'"><div align="center"><font color="'.$fontcol.'">'.$reason.'</font></div></td>
  </tr>';
   }
}
}  // <-- what is this the termination of? 
//

[Jramz]

daveyc wrote:

Hi Guys,

Is it possible to insert an "if" statement inside a "while" loop?

Thanks a bunch 🙂

Dave

If i understand your intent correctly then perhaps this code would work better for you:

$sql = "SELECT * from callbacks"; 
$result = mysql_query($sql); 
while ($row = mysql_fetch_array($result)) { // This bracket Opens the While Statement
   $idno = $row['id']; 
   $name = $row['name']; 
   $number = $row['number']; 
   $service = $row['service']; 
   $timecall = $row['calltime']; 
   $reason = $row['reason']; 
   $status = $row['status']; 
   if ($status == ""){ // This bracket opens the nested IF statement
      $tdcolor = "#FFFFFF"; 
      $fontcol = "#FF0000"; 
   }else{ // these brackes close the nest if and open the nested elseif
      $tdcolor = "#FF0000"; 
      $fontcol = "#FFFFFF"; 

  echo '   <tr> 
  <td height="40" bgcolor="'.$tdcolor.'"><div align="center">'.$name.'</div></td> 
  <td bgcolor="'.$tdcolor.'"><div align="center"><font color="'.$fontcol.'">'.$number.'</div></td> 
  <td bgcolor="'.$tdcolor.'"><div align="center"><font color="'.$fontcol.'">'.$service.'</div></td> 
  <td bgcolor="'.$tdcolor.'"><div align="center"><font color="'.$fontcol.'">'.$timecall.'</div></td> 
  <td valign="middle" bgcolor="'.$tdcolor.'"><font color="'.$fontcol.'"> 
  <div align="center"> 
  <form id="form1" name="form1" method="GET" action="process.php" enctype="application/x-www-form-urlencoded"><input name="id" type="hidden" value="'.$idno.'"/> 
  <input name="called" type="submit" id="called" value="Called" /> 
  <input name="Notcalled" type="submit" id="Notcalled" value="Not Called" /> 
  </form> 
  </div></font></td> 
  <td bgcolor="'.$tdcolor.'"><div align="center"><font color="'.$fontcol.'">'.$reason.'</font></div></td> 
  </tr>'; 
   } // this closes the nested elseif
}  // this closes the while
// }  This bracket does not do anything so *remove this bracket*

[salmanshafiq]

There is no porblem using the If in while even you can use if in while as many as you can

In your code this is problem of you closed 3 "}" in your code but you have started only to one for if and one for while and other for else part and the third one is no means just remove that and see it's prefect

Thanks,
Salman Shafiq

Jramz wrote:

If i understand your intent correctly then perhaps this code would work better for you:

$sql = "SELECT * from callbacks"; 
$result = mysql_query($sql); 
while ($row = mysql_fetch_array($result)) { // This bracket Opens the While Statement
   $idno = $row['id']; 
   $name = $row['name']; 
   $number = $row['number']; 
   $service = $row['service']; 
   $timecall = $row['calltime']; 
   $reason = $row['reason']; 
   $status = $row['status']; 
   if ($status == ""){ // This bracket opens the nested IF statement
      $tdcolor = "#FFFFFF"; 
      $fontcol = "#FF0000"; 
   }else{ // these brackes close the nest if and open the nested elseif
      $tdcolor = "#FF0000"; 
      $fontcol = "#FFFFFF"; 

  echo '   <tr> 
  <td height="40" bgcolor="'.$tdcolor.'"><div align="center">'.$name.'</div></td> 
  <td bgcolor="'.$tdcolor.'"><div align="center"><font color="'.$fontcol.'">'.$number.'</div></td> 
  <td bgcolor="'.$tdcolor.'"><div align="center"><font color="'.$fontcol.'">'.$service.'</div></td> 
  <td bgcolor="'.$tdcolor.'"><div align="center"><font color="'.$fontcol.'">'.$timecall.'</div></td> 
  <td valign="middle" bgcolor="'.$tdcolor.'"><font color="'.$fontcol.'"> 
  <div align="center"> 
  <form id="form1" name="form1" method="GET" action="process.php" enctype="application/x-www-form-urlencoded"><input name="id" type="hidden" value="'.$idno.'"/> 
  <input name="called" type="submit" id="called" value="Called" /> 
  <input name="Notcalled" type="submit" id="Notcalled" value="Not Called" /> 
  </form> 
  </div></font></td> 
  <td bgcolor="'.$tdcolor.'"><div align="center"><font color="'.$fontcol.'">'.$reason.'</font></div></td> 
  </tr>'; 
   } // this closes the nested elseif
}  // this closes the while
// }  This bracket does not do anything so *remove this bracket*