BETA test my thumbnail script

[Catharsis]

Hi all,

Wasn't sure where to put this but I had a flash of inspiration the other day when I saw a dreadfully bad implementation of a thumbnail program and decided to write one myself. Code is sitting on my dev box at home, you can grab a copy at the following url

Download here

If its down then my box has gone pop or ADSL has gone pop. Heres what I want to know, is it easy to understand? Well documented? Does it work 'out the box'? Do the instructions make sense? Is the code well formed? Can you find anything screwy?

All comments welcome, Im sure this has already been done a million times by a million other people but this ones mine 🙂

[bradgrafelman]

Quickly looking at the code, there's one suggestion I can make:

Instead of code such as

if (!$_SESSION['user']) {

, you should be using something like:

if (!empty($_SESSION['user'])) {

or

if (!isset($_SESSION['user']))

Examples include lines 32, 38, 41, et al of thumbnail.php.

It's not a big deal, but in your config.php... you apparently parse this file using the parse_ini_file() function, so you might consider delimiting your comment lines with a semicolon instead of the double forward slash, as the comments that have equal signs in them are being parsed as key=value pairs. Again, not that big of a deal, but... shrug.