uploading multi images

slimjim

I been trying to figure out how to make a multi upload image script where it stores each image name in the database and I can not figure it out.

Can anyone help me get started please.

stolzyboy

have you gotten one image to upload?

if so, it's just a matter of having more browse boxes and duplicating the upload code from the first.

slimjim

Here is what I have so far.
My biggest problem lies in getting each image name into the database and error checking.
I need help

<?
   require "configfile/conf.php";

if(isset($_POST['submit'])){

foreach ($_FILES["pictures"]["error"] as $key => $error) {
    if ($error == UPLOAD_ERR_OK) {
        $tmp_name = $_FILES["pictures"]["tmp_name"][$key];
        $name = $_FILES["pictures"]["name"][$key];
        move_uploaded_file($tmp_name, "upload2/$name");
    }
}

} else {
?>
<form action="uploadtest.php" method="post" enctype="multipart/form-data">
<p>Pictures:
<input type="file" name="pictures[]" />
<input type="file" name="pictures[]" />
<input type="file" name="pictures[]" />
<input type="submit" name="submit" value="Send" />
</p>
</form>
<?}?>

bpat1434

Try doing:

foreach($_FILES['pictures'] as $pic)
{
  if($pic['error'] == UPLOAD_ERR_OK)
  {
    $tmpName = $pic['tmp_name'];
    $name = $pic['name'];
    move_uploaded_file($tmpName, 'upload2/'.$name);
  }
}

If you had printed out the $FILES array, you'd realize that it's structure like:

$_FILES = array(
    'pictures' => array(
        0 => array(
            'name' => 'some name',
            'tmp_name' => '/path/to/tmp/some_name.jpg',
            'error' => 0,
            'size' => 123456789
        ),
        1 => array(
            ...
        )
    )
);

Hope that helps.

slimjim

Ok but how do I insert into one row all three image names ?

slimjim

Not actually sure how to get all three images names and where to to put insert statement so that all three names go into one row instead of 3

slimjim

OK doing it different and still no luck....

Not doing something right and I think it has to do with the I am using for inserting the image name and where I am placing the insert
Please help if you can...

$numoffile = 3; 
$file_dir = "upload2/"; 

if(isset($_POST['submit'])){

for ($i=0;$i<$numoffile;$i++) { 
if (trim($_FILES['myfiles']['name'][$i])!="") { 
$newfile = $file_dir.$_FILES['myfiles']['name'][$i]; 
move_uploaded_file($_FILES['myfiles']['tmp_name'][$i], $newfile);

//tried the insert into table here and it adds three rows instead of putting all three image names in one row
                $insertpic = "INSERT INTO imageuploads (image1, image2, image3) 
                             VALUES ('$newfile', '$newfile', '$newfile')";                            

                            $result = mysql_query($insertpic)                              

                            or die ("Query failed: ".mysql_error()); 

$j++; 
} 
} 
if (isset($j)&&$j>0) print "Your $j file(s) has been uploaded.<br>";
echo "<a href='uploadtest.php'>Go Back</a>"; 
}else{
print "<form method='post' enctype='multipart/form-data'>"; 
for($i=0;$i<$numoffile;$i++) { 
print "<input type='file' name='myfiles[]' size='30'><br>"; 
} 
print "<input type='submit' name='submit' value='Upload'>"; 
print "</form>"; 
}

bradgrafelman

Going back to bpat's version, I would suggest this:

$pic_names = array();
foreach($_FILES['pictures'] as $pic) 
{ 
  if($pic['error'] == UPLOAD_ERR_OK) 
  { 
    $tmpName = $pic['tmp_name']; 
    $pic_names[] = $name = $pic['name']; 
    move_uploaded_file($tmpName, 'upload2/'.$name); 
  } 
}

That way, $pic_names is an array ofimage names that you can use in a query later... most likely one that's not inside of a loop (as in your latest coding snippet).

Also, in case you're confused about the syntax, this:

$pic_names[] = $name = $pic['name'];

is similar to:

$name = $pic['name'];
$pic_names[] = $name

slimjim


//And would I use it like this for adding names into the DB:
$pic_names[0] 
$pic_names[1] 
$pic_names[2

bradgrafelman

slimjim wrote:
//And would I use it like this for adding names into the DB:

That's the gist of it... why? Have you not tried it yet?

slimjim

Not sure where to put the insert statement for inserting into the DB

Everytime I did this, it put it in multi tmes

slimjim

Here is what I have and does not work..

if(isset($_POST['submit'])){ 

$pic_names = array(); 
foreach($_FILES['pictures'] as $pic) 
{ 
  if($pic['error'] == UPLOAD_ERR_OK) 
  { 
    $tmpName = $pic['tmp_name']; 
    $pic_names[] = $name = $pic['name']; 
    move_uploaded_file($tmpName, 'upload/'.$name); 
  } 
} 

            $insertpic = "INSERT INTO imageuploads (image1, image2, image3) VALUES ('$pic_names[0]', '$pic_names[1]', '$pic_names[2]')";                             
            $result = mysql_query($insertpic) or die ("Query failed: ".mysql_error()); 
} else { 
?> 
<form action="imageuploadtest.php" method="post" enctype="multipart/form-data"> 
<p>Pictures: 
<input type="file" name="pictures[]" /> 
<input type="file" name="pictures[]" /> 
<input type="file" name="pictures[]" /> 
<input type="submit" name="submit" value="Send" /> 
</p> 
</form> 
<?}?>

bpat1434

And the mySQL error that is returned is ... ?

slimjim

no error, it inserts, just doesnt insert image names at all

bradgrafelman

What does a print_r($pic_names); look like?

What if you add this to the loop (after the move_uploaded_file() line):

echo 'File: ' . $name . '<br>';

Does it show the file names?

slimjim

Just notice it doesnt even move image to dir

slimjim

File:
File:
File:
File:
File:

Thats what I get with that echo

bradgrafelman

Interesting... can you do a print_r() on $_FILES['pictures'] and show us what that looks like?

slimjim

I added this below the echo:
print_r ($_FILES['pictures']);

And got this

Array ( [name] => Array ( [0] => bubbabanner.gif [1] => [2] => ) [type] => Array ( [0] => image/gif [1] => [2] => ) [tmp_name] => Array ( [0] => /tmp/phpwh7Atx [1] => [2] => ) [error] => Array ( [0] => 0 [1] => 4 [2] => 4 ) [size] => Array ( [0] => 4388 [1] => 0 [2] => 0 ) ) File: 
Array ( [name] => Array ( [0] => bubbabanner.gif [1] => [2] => ) [type] => Array ( [0] => image/gif [1] => [2] => ) [tmp_name] => Array ( [0] => /tmp/phpwh7Atx [1] => [2] => ) [error] => Array ( [0] => 0 [1] => 4 [2] => 4 ) [size] => Array ( [0] => 4388 [1] => 0 [2] => 0 ) ) File: 
Array ( [name] => Array ( [0] => bubbabanner.gif [1] => [2] => ) [type] => Array ( [0] => image/gif [1] => [2] => ) [tmp_name] => Array ( [0] => /tmp/phpwh7Atx [1] => [2] => ) [error] => Array ( [0] => 0 [1] => 4 [2] => 4 ) [size] => Array ( [0] => 4388 [1] => 0 [2] => 0 ) ) File: 
Array ( [name] => Array ( [0] => bubbabanner.gif [1] => [2] => ) [type] => Array ( [0] => image/gif [1] => [2] => ) [tmp_name] => Array ( [0] => /tmp/phpwh7Atx [1] => [2] => ) [error] => Array ( [0] => 0 [1] => 4 [2] => 4 ) [size] => Array ( [0] => 4388 [1] => 0 [2] => 0 ) ) File: 
Array ( [name] => Array ( [0] => bubbabanner.gif [1] => [2] => ) [type] => Array ( [0] => image/gif [1] => [2] => ) [tmp_name] => Array ( [0] => /tmp/phpwh7Atx [1] => [2] => ) [error] => Array ( [0] => 0 [1] => 4 [2] => 4 ) [size] => Array ( [0] => 4388 [1] => 0 [2] => 0 ) )

bradgrafelman

I had wondered if bpat wasn't wrong in his array structure... it's been so long since I've messed with multi-file uploads that he had me convinced! :p

Try this (going back to your previous format):

$pic_names = array();
foreach ($_FILES["pictures"]["error"] as $key => $error) { 
    if ($error == UPLOAD_ERR_OK) { 
        $tmp_name = $_FILES["pictures"]["tmp_name"][$key]; 
        $pic_names[] = $name = $_FILES["pictures"]["name"][$key]; 
        move_uploaded_file($tmp_name, "upload2/$name");
    } 
}

Then do your SQL query after that loop.