NEWBIE AT PHP- Register scrpit not working?

[VFkat]

Hello!

I'm Zazzycat. I'm extremely new at PHP, but I am not a complete n00b. I do understand mostly how it works and how to write simple things.

I am currently trying to get a register script for a virtual pet site to work. I copied the structure from a tutorial book and changed the fields to my needs. It is supposedly a single-page registration script, where once you click the register button it changes the page content, telling you either if you forgot something or if the registration worked.

The script isn't causing any errors but it's just not doing what I want. Instead of displaying results it just takes you back to the blank form when you click the register button.

Please note I am aware that the script is not doing anything with the server yet. I want to get the general frame working before I make it actually do something useful. For some reason either I or someone else popped the DBconnect include in there(can't quite remember), but I don't think it's supposed to do anything yet.

Here's the script:

<?

include 'dbconn.php' ;

if ($_POST) {

   //empty error variable
   $error = "" ;

   //check for data in required fields
   if (($username == "") ||
       ($email == "") ||
       ($password == "")) {
      $error = "Please fill in all of the required fields." ;
   }

   // validate $email
   if ((strpos($email, "@") === FALSE) ||
       (strpos($email, ".") === FALSE) ||
       (strpos($email, " ") != FALSE) ||
       (strpos($email, "@") > strrpos($email, "."))) {
      $error .= "Please enter a valid email address." ;
      }

   if  ($error != "") {
       echo "$error <p>Please click the back button and try again." ;
   } else {
       echo "<p><b>Username:</b> #username<br>" ;
       echo "<b>Email:</b> #email<br>" ;
       echo "<p><b>Password:</b> #password<br>" ;

   }

} else {

?>

<form method="POST" action="<? echo $_SERVER['PHP_SELF'] ?>">

<table border="0" cellpadding="3" cellspacing="0">

 <tr>

  <td>Username:<br></td>
  <td><input type="text" name"username" size="20" maxlength="12"></td>

 </tr>

 <tr>

  <td>Email:</td>
  <td><input type="text" name"email" size="20" maxlength="50"></td>

 </tr>

 <tr>

  <td>Password:</td>
  <td><input type="password" name"password" size="20" maxlength="20"></td>

 </tr>

 <tr>

  <td colspan="2">
   <center><input type="SUBMIT" value="Register"></center>
  </td>

 </tr>

</table>

</form>

<?

}

?>

...and here's the output on the page:

It's probably something simple but like I said I am new at this.

If anyone could help me I would be extremely grateful!

~Zazzy

[cgraz]

I'd recommend using standard php tags vs. the short tags

<?php vs. just <?

Secondly, change

if ($_POST) { 

to

if( isset( $_POST['submit'] ) ) {

and change your submit button to this

<input type="submit" name="submit" value="Register">

To print your variables, try this:

print '<p><b>Username:</b> ' . $_POST['username'] . '<br />';
print '<b>Email:</b> ' . $_POST['email'] . '<br />';
print '<b>Password:</b> ' . $_POST['password'] . '<br />';

[meigwil]

You're not getting anything from the $_POST array. All your variables are null, axcept for the $error.

Try:

if ($_POST) { 

$username =  $_POST['username'];
$email = $_POST['email'];
$password = $_POST['password'];

and then the rest of your script.

Mei

PS and try using divs with CSS, instead of tables...

[bpat1434]

I'd just like to chime in and point out an error in your email validation statement. If I use an email address like:
[e-mail]
which is a valid email address (according to the RFC) then your email validator would kick it back. I'd suggest you use ereg (or eregi) to validate an email address.

Here's a quick function I made:

function validateEmail($email=null)
{
    /*
     *  Pattern obtained from usernotes at php.net
     *  Original Author(s): bobocop and manuel
    */
    if($email===null)
        return false;

$atom = '[-a-z0-9!#$%&\'*+/=?^_`{|}~]';
$domain = '([a-z0-9]([-a-z0-9]*[a-z0-9]+)?)';

$pattern = '^' . $atom . '+(\.' . $atom . '+)*@(' . $domain . '{1,63}\.)+' . $domain . '{2,63}$';

if(function_exists('eregi'))
    $func = 'eregi';
else
{
    $func = 'ereg';
    $email = strtolower($email);
}

if($func($pattern, $email))
    return true;

return false;
}

[VFkat]

Thank you so much everyone! I'll try those things.

You should expect me to be around alot- I'm working on a big project with PHP and I want to be able to code it myself for the most part!