Syntax problem...

Oni

Hello-

To my great suprise Ive somehow managed to create a syntax error in a long update which looks flawless to my eyes...

$result = mysql_query("UPDATE liste SET deg='$yuzde', on='$onc', son='$son', tab='$tab', tav='$tav', a='$a', b='$b', c='$c', ca='$ca', cb='$cb' WHERE hisse='$h'")
or die(mysql_error());

All variables are decimal numbers (some are negative) $h is a word.

Error:
You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near 'on='6.05', son='7.00', tab='6.15', tav='7.55', a='0.55', b='0.95', c='-0.1', ca=' at line 1

Im using varchar for $h and int for all other variables...
ca = c/a = -0.18 by the way

Any ideas? :queasy:

bradgrafelman

"ON" is a reserved word in MySQL.

To solve this, try surrounding your column names with backticks:

UPDATE `myTABLE` SET `foo`

bradgrafelman

"ON" is a reserved word in MySQL.

To solve this, try surrounding your column names with backticks:

UPDATE `myTABLE` SET `foo` = 'bar'

Oni

ehe

I believe its the second time that my abbreviation for a turkish word happened to be a reserved word... Maybe I should use english from now on--

The tip worked great, however now commands that I run correctly do not effect the rows... :S

"UPDATE liste SET deg='15.70', onc='6.05', son='7.00', tab='6.15', tav='7.55', a='0.55', b='0.95', c='-0.1', ca='-0.18', cb='-0.11' WHERE hisse='AFMAS'"

Produces
0 0 0 0 0 0 0 0 0 0
In the "AFMAS" row.

Thanks!

bradgrafelman

In my above query, I used quotes around 'bar' because bar was a string. In your queries, you're storing numerical data, so you shouldn't use quotes.

Try removing the single quotes around the numerical values and see if that helps.

EDIT: If that doesn't work, can you show us the CREATE TABLE syntax for this table?

Oni

Nope--

It should be noted that not all of the rows are being updated. The ones that are and are not are filled with "0" in the columns...

bradgrafelman

Show us the CREATE TABLE syntax and I'll see if I can duplicate this.

Oni

Well I created the table in phpmyadmin.

Created the rows from a txt file...

I took screenshots...

SQL dump http://users.gridstar.net/~alperc/liste.sql

xblue

Hi Oni,

I think the first problem results from the linebreaks. In your sql dump, it reads

INSERT INTO `liste` VALUES ([COLOR="Red"]'AFMAS\r\n'[/COLOR], 0, 0, 0, 0, 0, 0, 0, 0, 0, 0);

while your update query uses 'AFMAS' only in the where clause, so no record will be matched.

Apart from that, are you aware that the data type of the numeric columns is integer while you seem to try to get decimals inserted?

Oni

It seems as though that phpmyadmin does not write new line phrases into its table output... :queasy:

As for the integer thing, it totally slipped my mind! :rolleyes:

Works fine now, thanks you two for your help--

bradgrafelman

Oni wrote:
It seems as though that phpmyadmin does not write new line phrases into its table output...

On the contrary, I'll bet if you viewed the HTML source of the page you would see the line breaks.

Don't forget to mark this thread resolved.