Turning Navigation menu into a function

pyoung412

Hello,

I'm working from the book Foundation: PHP for Dreamweaver 8. The work was originally designed for php 5.0. I have installed a test area on my machine using php 5.2 and have not had problems with the lessons until I tried to get the navigation menu into a function and I have a suspicion that the problem might be due to the upgrade from php 5.0 to 5.2 because I have run the author's correct code and get the same result as the code I created using his instructions. Three files are involved: contact.php, navmenu.php, and styles_rules_monthly.php. I have listed the code for each in the order stated in the previous sentence. The out put is producing a bulleted list instead of menu buttons (so it appears the style sheet is failing to import correctly).

contact.php

<?php
// set flag to indicate whether mail has been sent
$mailSent = false;
if (array_key_exists('ewComments', $_POST)) {
  // mail processing script
  // remove escape characters from POST array
if (get_magic_quotes_gpc()) {
  function stripslashes_deep($value) {
    $value = is_array($value) ? array_map('stripslashes_deep', $value) : stripslashes($value);
    return $value;
    }
  $_POST = array_map('stripslashes_deep', $_POST);
  }
  // validate the input, beginning with name
  $name = trim($_POST['name']);
  if (empty($name)) {
    $error['name'] = 'Please enter your name';
    }
  $email = $_POST['email'];
  // check for valid email address
  $pattern = '/^[^@]+@[^\s\r\n\'";,@%]+$/';
  if (!preg_match($pattern, trim($email))) {
    $error['email'] = 'Please enter a valid email address';
    }
  // check the content of the text area
  $messageBody = trim($_POST['message']);
  if (empty($messageBody)) {
    $error['message'] = 'Please enter your message';
    }
  // initialize variables
  $to = 'me@example.com'; // use your own email address
  $subject = 'Feedback from East-West Seasons';

  // build the message
  $message = 'On '.date('l, M j, Y').' at '.date('g:ia').', ';
  $message .= "$name ($email) wrote: \n\n";
  $message .= $messageBody;

  //build the additional headers
  $additionalHeaders = "From: E-W Seasons<feedback@example.com>\r\n";
  $additionalHeaders .= "Reply-To: $email";

  if (!isset($error)) {
    $mailSent = mail($to, $subject, $message, $additionalHeaders);
    // check that the mail was sent successfully
    if (!$mailSent) {
      $error['notSent'] = 'Sorry, there was a problem sending your mail. Please try later.';
      }
    }
  }
?>

<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Transitional//EN" "http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head>
<meta http-equiv="Content-Type" content="text/html; charset=iso-8859-1" />
<title>East-West Seasons</title>

<?php include('style_rules_monthly.php'); ?>
<?php include('navmenu.php'); ?>

 <?php insertMenu($pages, 'thispage'); ?>
    </div>
	<?php if (isset($error['notSent'])) { ?>
    <h1>Server error</h1>
    <p class="warning"><?php echo $error['notSent']; ?></p>
	<?php } elseif ($mailSent) { ?>
    <h1>Thank you for your comments</h1>
    <p>We appreciate your feedback, and will be in touch if necessary.</p>
	<?php } else { ?>
    <h1>Send us your comments</h1>
    <p>We hope you have enjoyed this site. If you have any comments, or would like further information, please use the following form. East-West Seasons will not use your email address for any other purpose than replying to you. </p>
	<?php } ?>
	<?php if (!$mailSent) { ?>
    <form action="<?php $_SERVER['PHP_SELF']; ?>" method="post" name="contactForm" id="contactForm" onsubmit="MM_validateForm('name','','R','email','','RisEmail','message','','R');return document.MM_returnValue">
      <p>
        <label for="name">Name:</label> <?php if (isset($error['name'])) { ?>
        <span class="warning"><?php echo $error['name']; ?></span>
        <?php } ?>
        <br />
        <input type="text" name="name" id="name"
		<?php if(isset($error)) {echo "value='$name'";} ?> />

</p>
<p>
<label for="email">Email:</label>

<?php if (isset($error['email'])) { ?>
        <span class="warning"><?php echo $error['email']; ?></span>
        <?php } ?>
        <br />
        <input type="text" name="email" id="email"
		<?php if(isset($error)) {echo "value='$email'";} ?> />

</p>
<p>
<label for="message">Message:</label> <?php if (isset($error['message'])) { ?>
<span class="warning">

<?php echo $error['message']; ?></span>
        <?php } ?>

<?php if(isset($error)) {echo $messageBody;} ?>

</textarea>
</p>
<p>
<input name="ewComments" type="submit" id="ewComments" value="Send comments" />
</p>
</form>

<?php } ?>
  </div>
  <div id="footer"><?php include('copyright.php'); ?>

</div>
</div>
</body>
</html>

navmenu.php

<?php
$pages = array('index.php'   => 'Home',
               'news.php'    => 'News',
               'blog.php'    => 'Blog',
               'gallery.php' => 'Gallery',
               'contact.php' => 'Contact');

function insertMenu($pages, $pageID) {
  echo "<ul>\n";
  foreach ($pages as $file => $listing) {
    echo '<li';
    // if the current filename and array key match, insert ID
    if (basename($_SERVER['SCRIPT_FILENAME']) == $file) {
      echo " id='$pageID'><a href='javascript:;'>";
      }
    else {
      echo "><a href='$file'>";
      }
    echo "$listing</a></li>\n";
    }
  echo "</ul>\n";
  }
?>

style_rules_monthly.php

<?php
// get current month as a number
$month = date('n');
// select theme for the month
switch($month) {
  case 10:
  case 11:
  case 12:
  case 8:
    $theme = 'maples';
    break;
  case 2:
  case 3:
  case 4:
    $theme = 'bluebells';
    break;
  default:
    $theme = 'tulips';
  }
?>

Thanks in advance,

Philip

NogDog

Could you help us out a bit by wrapping your code samples in [ php] . . . [php ] vb_code tags (without the spaces I used here)? That will maintain any indenting you used, plus provide syntax-based color highlighting, making it much easier to read and possible detect any syntax errors. Just click the "Edit" button at the lower right of your post to change it.

pyoung412

I have added the tags to make the php code stand out.