Why??

[chinclub]

This is a piece of script from a large script I bought. It is part of a store and as you will see in the code below it has 2 mysql_querys. For some reason it will only show either the first one or the second one but never both. I have looked over this script 100 times and I can not figure out what the problem is. I thought maybe it was because they were both named $sql so I tried naming the second one something different and that didn't work. Can anyone point out the error?

if($a == 'view') {
		$store = $_GET['store'];

	$sql = mysql_query("SELECT * FROM `stores` WHERE `user`=\"$store\" AND `open`='1' AND `site`=\"$Z\"");
	$Num = mysql_num_rows($sql);

	if($Num == 0) {
	 	print "This store is closed, sorry!";
	}
	else {
	while($row = mysql_fetch_array($sql)) {
		extract($row);

		print "<h2>$store_name</h2><p><table width=100%><tr><td>
		This store is run by <a href='profile.php?action=profile&username=$user'>$user</a></td><td align=right><a href='mainmall.php'>Return to the Mall</a></td></tr></table><p>";

		if($store_image) {
		 	print "<center><img src='images/storeimages/$store_image'></center>";
		}


		print "<br><br><center><b>$desc</b></center><hr><table border=0 cellpadding=3 cellspacing=0 width=100%>
		<tr>";

		$sql = mysql_query("SELECT * FROM `store_items` WHERE `available` = '1' AND `store_user`=\"$user\" AND `site`=\"$Z\" ORDER BY `item` ASC");
		while($row = mysql_fetch_array($sql)) {
		 	extract($row);

		 	$x=$x+1;

		 	if($type == "weapon") {
		 	 	$desc = "<b>$name</b><br>Cost: $cost<br>Damage: Up to $damage<p>";
		 	}
		 	else {
		 	 	$desc = "<b>$name</b><br>Cost: $cost<br>Points: $points<p>";
		 	}

		 	print "<td valign=top width=33%>
		 	 <table border=0 cellpadding=3 cellspacing=0 width=100%>
		 	  <tr>
		 	   <td valign=middle align=center><img src='/images/items/$item.gif'></td>
		 	   <td valign=top width=90% class=other>$desc
				<FORM>
				<INPUT TYPE=\"button\"
				VALUE=\"Purchase\"
				onClick=\"self.location='/userstores.php?action=buy&id=$id&type=item&store=$store'; this.disabled=true;return true;\">
				</FORM>	</td>
		 	  </tr>
		 	 </table></td>";

		 	if($x%3==0) {
		 	  	print "</tr><tr>";
		 	}
		}
		print "</table>";


print "<table border=0 cellpadding=3 cellspacing=0 width=100%>
<tr>";

		$x=0;
		$sql = mysql_query("SELECT * FROM `store_food` WHERE `available`='1' AND `store_user`=\"$user\" AND `site`=\"$Z\" ORDER BY `item` ASC");
		while($row = mysql_fetch_array($sql)) {
		 	extract($row);

		 	$x=$x+1;

		 	print "<td valign=top width=33%>
		 	 <table border=0 cellpadding=3 cellspacing=0 width=100%>
		 	  <tr>
		 	   <td valign=middle align=center><img src='/images/food/$item.gif'></td>
		 	   <td valign=top width=90% class=other><b>$name</b><br>Cost: $cost<br>Points: $points<p>
	<FORM>
	<INPUT TYPE=\"button\"
	VALUE=\"Purchase\"
	onClick=\"self.location='/userstores.php?action=buy&id=$id&type=food&store=$store'; this.disabled=true;return true;\">
	</FORM>	
	</td>
		 	  </tr>
		 	 </table></td>";

		 	if($x%3==0) {
		 	  	print "</tr><tr>";
		 	}
		}
		print "</table>";	
	} 
	}
}

[bradgrafelman]

Do either of the fail? To debug a SQL query, I normally write them like so:

$query = 'SQL query here.';
$exec = mysql_query($query) or die('MySQL error: ' . mysql_error() . '<hr>Query: ' . $query);

Also, user-supplied data should never be placed directly into a SQL query! Instead, sanitize it with a function such as [man]mysql_real_escape_string/man.

[FusionComputers]

In looking that over, it should output a table with weapons, and a table with food, from which a person playing this game can select. Although, it seems as though this script won't fire because of the WHERE clause in the SQL statement.

"SELECT * FROM `store_food` WHERE `available`='1' AND `[B]store_user`=\"$user\"[/B] AND `site`=\"$Z\" ORDER BY `item` ASC"

$user, which I'm pretty sure is propagated via the URL or POST data, needs to match the value in "store_food." If it doesn't then that query doesn't fire. If you open up the database this is attached to and look at that table, see if the right data is being sent to it by dropping an echo $user; before that SQL statement.

And.. you bought this set of scripts? May I ask how much they were?

[bradgrafelman]

FusionComputers wrote:

And.. you bought this set of scripts?

My thoughts precisely. Never ceases to amaze me the quality of scripts being sold...

[chinclub]

The store.php script is very long so I just included the view action part. The script is working but you can have weapons and food in your store inventory and when you view the store it will only show either all weapons or all food never both. I can use it like it is as people will just have to decide which type they sell. It just frustrates me that I can not figure out why it is doing that. Everything in the script looks right to me.

Oh, and don't even get me started about quality. I have pretty much had to rewrite almost the entire thing. Thankfully it was cheap and at least it gave me a head start. Most of the other errors I have been able to find and fix but I have played with this script for over a month and just can not figure it out so I thought a few more eyes could find the problem.

[chinclub]

Sorry I didn't see the question about how much I paid. This is part of the ipetscript which I think I paid $25 for. I didn't do much research into it before I got it and I found out later that the script has a very bad reputation. I'm not really that disappointed in it, though. I had to take a crash course in PHP to make it run but it has been a fun little project. I had to add some extra admin security and modify a few things but I was able to take the basic script and grow up from there. I have written so many add-ons and mods that I am pretty happy with it now. Its up and running at www.VirtualChinchillas.com. There are just a hand full of minor glitches like the one I am needing help with above that are just baffleing me. But if we can't figure it out I can live with it the way it is.

[bradgrafelman]

Okay, so from what I gather the problem is that it's only showing you one type of item or the other: either food or weapons. Is this correct?

Have you added the debug syntax I gave above to check if either query is failing? Can you echo both queries and paste them here for us?