Selecting Multiple rows in MySQL database

[john1704]

I have a table in a database that has a list of e-mail addresses (yes, this is a newsletter mailing list). I want to make a PHP script that will select those e-mail addresses, and with PHP's mail function, mail the newsletter body and subject to the list in the MySQL database. How would I do it?
This is the current script I have below, but it doesn't work.

<?php 
$subject = $_POST['subject'];
$email = $_POST['email'];
$message = $_POST['message'];
if ($submit)
{
$sql = "SELECT COUNT( * ) AS `Rows` , `address` FROM `newsletter` GROUP BY `address` ORDER BY `address` LIMIT 0, 30 ";
$result = mysql_query($sql);

while ($row=mysql_fetch_array($result))
{
$addresses=$row["address"];

}
mail("$addresses", "$subject", "$message \n \n If you want to unsubscribe from this newsletter, click on the following link: \n \n http://pwnedbyjohn.com/unsubscribe.php", 'From: "Newsletter" <$email>');
echo "Message sent";
}
?> 

[theelectricwiz]

Well here is a code that should work assuming that you are creating sql connection correctly and the $submit variable correctly. The first version will be more acceptable to the people you are sending it to as then no one else can see other peoples addresses, but the second is the nasty way of doing it.

<?php 
$subject = $_POST['subject'];
$email = $_POST['email'];
$message = $_POST['message'];
if ($submit)
{
$sql = "SELECT address FROM newsletter GROUP BY address";
$result = mysql_query($sql);

while ($row=mysql_fetch_array($result))
{
mail($row["address"], "$subject", "$message \n \n If you want to unsubscribe from this newsletter, click on the following link: \n \n http://pwnedbyjohn.com/unsubscribe.php", 'From: "Newsletter" <' . $email . '>');
echo "Message sent";
}
?>

<?php 
$subject = $_POST['subject'];
$email = $_POST['email'];
$message = $_POST['message'];
$addresses = array();
if ($submit)
{
$sql = "SELECT address FROM newsletter GROUP BY address";
$result = mysql_query($sql);

while ($row=mysql_fetch_array($result))
{
$addresses[] = $row["address"];
}

mail( implode(", ", $addresses), "$subject", "$message \n \n If you want to unsubscribe from this newsletter, click on the following link: \n \n http://pwnedbyjohn.com/unsubscribe.php", 'From: "Newsletter" <' . $email . '>');
echo "Message sent";
}
?>

[cgraz]

The logic in your code is flawed. Take this pseudo code

loop( monday through sunday as $dayofweek )
{
    $days = $dayofweek;
}

In the code, I'm looping through the days of the week, and creating a variable called $days in which I'm assigning it the current value in the loop.

1st Iteration: $days = Monday
2nd Iteration: $days = Tuesday
7th Iteration: $days = Sunday

Each iteration, you are assigning a new value to the same variable. By doing this, you're overwriting the previous value. Your ending value for $days after the loop is done will be the value of the last iteration of the loop, not a variable that holds every day of the week.

You would need to create an array to do that - a variable that can hold multiple values by doing this

while( something is true ... )
{
	$result[] = $value;
}

The [] indicates an array.

But an easier way of doing this would be to move your mail() statement inside of your while loop, and for the to address, use $row['address'] - that's all you need in your while loop. No need to define any variables.