Image upload and thumbnail

[David_P]

I'm using this form and upload script. But I'd like some help in modifying the upload script to make it better. One I'd like to be able to restrict the size of the image file being uploaded to 200000 bytes. I know I can put this in the form:

<input type="hidden" name="MAX_FILE_SIZE" value="200000">

but I don't know how to work it on the script.

Also, the thumbnail this script creates is really bad. It strictly conforms the image to 100px wide and high. This makes the thumbnail picture look terrible. How can I change it so that thumbnail image is proportionate in size while just restricting the maximum width and height to 120px. Either the height or width will have to adjust to remain proportionate. Is there also a way to set the thumbnail image quality to 85 or 90?

Thanks.
David

<form id="Upload" action="upload_processor.php" enctype="multipart/form-data" method="post"> 

<p> 
Picture to upload:<br> 
<input type="file" size="55" name="userfile"><br><br> 

Picture Title:<br> 
<input type="text" size="55" name="title"><br><br> 

Picture Description:<br> 
<textarea name="desc" rows="5" cols="55" wrap=virtual></textarea><br><br> 

Press to... <input type="submit" name="submit" value="Upload!"> 
</p> 

</form>  

<?php 
if ( $userfile !== '' ) { 

$add="upimg/$userfile_name"; // the path with the file name where the file will be stored, upload is the directory name.  

if(move_uploaded_file ($userfile, $add)){ 
echo " 
<p>Congratulations! Your picture upload was successful!</p> 
<p><a href='upload.form.php'>Upload another picture</a></p> 
<p><a href='index.php'>View Pictures</a></p> 
"; 
chmod("$add",0777); 

}else{echo "Failed to upload file Contact Site admin to fix the problem"; 
exit;} 


///////// Start the thumbnail generation////////////// 

$n_width=100;          // Fix the width of the thumb nail images 
$n_height=100;         // Fix the height of the thumb nail imaage 

$tsrc="thimg/$userfile_name";   // Path where thumb nail image will be stored 
echo $tsrc; 
if (!($userfile_type =="image/pjpeg" OR $userfile_type=="image/gif")){echo "Your uploaded file must be of JPG or GIF. Other file types are not allowed<BR>"; 
exit;} 

/////////////////////////////////////////////// Starting of GIF thumb nail creation/////////// 


if (@$userfile_type=="image/gif") 
{ 
$im=ImageCreateFromGIF($add); 
$width=ImageSx($im);              // Original picture width is stored 
$height=ImageSy($im);                  // Original picture height is stored 
$newimage=imagecreatetruecolor($n_width,$n_height); 
imageCopyResized($newimage,$im,0,0,0,0,$n_width,$n_height,$width,$height); 
if (function_exists("imagegif")) { 
Header("Content-type: image/gif"); 
ImageGIF($newimage,$tsrc); 
} 
elseif (function_exists("imagejpeg")) { 
Header("Content-type: image/jpeg"); 
ImageJPEG($newimage,$tsrc); 
} 
chmod("$tsrc",0777); 
} 

////////// end of gif file thumb nail creation////////// 


////////////// starting of JPG thumb nail creation////////// 

if($userfile_type=="image/pjpeg"){ 
$im=ImageCreateFromJPEG($add);  

$width=ImageSx($im);              // Original picture width is stored 
$height=ImageSy($im);             // Original picture height is stored 
$newimage=imagecreatetruecolor($n_width,$n_height);                  

imageCopyResized($newimage,$im,0,0,0,0,$n_width,$n_height,$width,$height); 
ImageJpeg($newimage,$tsrc); 
chmod("$tsrc",0777); 
} 

////////////////  End of JPG thumb nail creation ////////// 


$image_name = $userfile_name; 

include("includes/dbconnect.php"); 

$title = addslashes($_POST['title']); 
$desc = addslashes($_POST['desc']); 
$image_name = addslashes($image_name); 

$query = "INSERT INTO $table VALUES ('', '$title', '$desc', '$image_name')"; 
mysql_query($query); 

} 
mysql_close(); 
?>

[bpat1434]

I've done this exact thing for someone before, so I'll just post the code here again.

  // Get the temporary file name that php gives us.
  $tempname = $_FILES['photo']['tmp_name'];

  // Set the max upload file-size
  $maxSize = 1024 * 1024 * 5; 
  // 5 MB upload limit.  Done in Bytes (1024 bytes/Kb, 1024 Kb/Mb).
  // bytes * Kilobytes * Megabytes will give you the max alloted size.
  // This is of course limited by php.ini

  // Check to make sure it's uploaded
  if(is_uploaded_file($tempname))
	{
	  // Original dimensions
	  $orig_dimensions = getimagesize($tempname);

  // Check to make sure we get a valid image size
  if($orig_dimensions === FALSE || $orig_dimensions[2] != 2)
	{
	  die("Image upload failed!!");
	  // You can change this to a different message, or call your own
	  // error function if you wish.
	}

	// Define the original dimensions (width & height)
	$orig_width = $orig_dimensions[0];
	$orig_height = $orig_dimensions[1];

	// Create a new image from the temp to work off of
	$orig_image = imagecreatefromjpeg($tempname);

	// If it's tall, we need to do one more step
	$image_is_tall = ($orig_height>=$orig_width);

	// Define how large you want the new image
	$swidth = 250;

	// Define the proportionate height
	$sheight = ceil($orig_height/$swidth*$orig_width);

	// If the image is tall, not wide, well rotate the image dimensions
	// This is so that it stays proportionate if it's a tall image
	if($image_is_tall)
	{
		$t = $swidth;
		$swidth = $sheight;
		$sheight = $t;
	}

	// Create a new image based on the new widths & height
	$new_image = imagecreatetruecolor($swidth, $sheight);

	// Now we'll copy the old image, to the new image and it will be resized
	if(imagecopyresampled($new_image, $orig_image, 0, 0, 0, 0, $swidth, $sheight, $orig_width, $orig_height) === FALSE)
	{
		echo "Image creation Failed!!";
	}
	else{
		// Set up some variables to use
		$photo_dir="/hsphere/local/home/chulamik/granbylionsclub.com/uploads/";
		$photo_url="http://www.granbylionsclub.com/uploads/";
		$photo_name = $HTTP_POST_VARS['photosID'].'.jpg';

		$newer_image = $photo_dir.$photo_name;

		// Create a new jpeg (*.jpg) from the resized image with 100% quality
		if(@imagejpeg($new_image, $newer_image, 100) === FALSE)
		{
			echo "Creation of image failed!!";
		}
		else
		{
			// Define the photo url for the database insertion
			$photo_url = $photo_url.$photo_name;
			echo "Image Created Successfully!!<br>";

			// Display the newly created image if you like.
			echo '<img src="'.$photo_url.'" width="250" alt="The New Photo!!">'; // Remove this if you don't want it.
		}
	}
}

There are some code issues you'll have to fix (like HTTP_POST_VARS) but it should be pretty easy.

[David_P]

OK, I appreaciate you're helping me, but please understand that I have gone through several dozen image scripts over a period of 2 years. During that time I've only found one that worked and that isn't saying much because it stinks.

I am completely worn out on this and trying to figure out another image script will cause me to pull my hair out. So I'm begging you... just give me the answers and I'll go back and figure out how it works afterwards. I just need to get a decent script working to boost my sagging morale.

I need to get this working with what I have already. I already have a upload form and a database. I can change the image file name on the upload form if you'll tell me what image file name the script you gave me is set up for. Right now I'm using "image" -

<input type="file" size="55" name="image">

Also I need to set the below variables to put into my database. What do I put for them in regards to this script?

$thumb_w = ?????;
$thumb_h = ?????;
$image_name = addslashes($?????);

And I'm not sure what this is. Is photosID what I should put on my upload form for the image file name?

$HTTP_POST_VARS['photosID'].'.jpg';

Is

Would this (less the absent variables) work?

<?php
// Get the temporary file name that php gives us. 
  $tempname = $_FILES['photo']['tmp_name']; 

  // Set the max upload file-size 
  $maxSize = 1024 * 1024 * 5; 
  // 5 MB upload limit.  Done in Bytes (1024 bytes/Kb, 1024 Kb/Mb). 
  // bytes * Kilobytes * Megabytes will give you the max alloted size. 
  // This is of course limited by php.ini 

  // Check to make sure it's uploaded 
  if(is_uploaded_file($tempname)) 
    { 
      // Original dimensions 
      $orig_dimensions = getimagesize($tempname); 

  // Check to make sure we get a valid image size 
  if($orig_dimensions === FALSE || $orig_dimensions[2] != 2) 
    { 
      die("Image upload failed!!"); 
      // You can change this to a different message, or call your own 
      // error function if you wish. 
    } 

    // Define the original dimensions (width & height) 
    $orig_width = $orig_dimensions[0]; 
    $orig_height = $orig_dimensions[1]; 

    // Create a new image from the temp to work off of 
    $orig_image = imagecreatefromjpeg($tempname); 

    // If it's tall, we need to do one more step 
    $image_is_tall = ($orig_height>=$orig_width); 

    // Define how large you want the new image 
    $swidth = 125; 

    // Define the proportionate height 
    $sheight = ceil($orig_height/$swidth*$orig_width); 

    // If the image is tall, not wide, well rotate the image dimensions 
    // This is so that it stays proportionate if it's a tall image 
    if($image_is_tall) 
    { 
        $t = $swidth; 
        $swidth = $sheight; 
        $sheight = $t; 
    } 

    // Create a new image based on the new widths & height 
    $new_image = imagecreatetruecolor($swidth, $sheight); 

    // Now we'll copy the old image, to the new image and it will be resized 
    if(imagecopyresampled($new_image, $orig_image, 0, 0, 0, 0, $swidth, $sheight, $orig_width, $orig_height) === FALSE) 
    { 
        echo "Image creation Failed!!"; 
    } 
    else{ 
        // Set up some variables to use 
        $photo_dir="/hsphere/local/home/chulamik/granbylionsclub.com/uploads/"; 
        $photo_url="http://www.granbylionsclub.com/uploads/"; 
        $photo_name =  $HTTP_POST_VARS['photosID'].'.jpg';
        $newer_image = $photo_dir.$photo_name; 

        // Create a new jpeg (*.jpg) from the resized image with 100% quality 
        if(@imagejpeg($new_image, $newer_image, 100) === FALSE) 
        { 
            echo "Creation of image failed!!"; 
        } 
        else 
        { 
            // Define the photo url for the database insertion 
            $photo_url = $photo_url.$photo_name; 
            echo "Image Created Successfully!!<br>"; 

            // Display the newly created image if you like. 
            echo '<img src="'.$photo_url.'" width="125" alt="The New Photo!!">'; // Remove this if you don't want it. 
        } 
    } 
} 


include("includes/dbconnect.php");

$thumb_w = $image_width;
$thumb_h = $image_height;
$image_name = addslashes($image_name);

$title = addslashes($_POST['title']);
$desc = addslashes($_POST['desc']);

$query = "INSERT INTO $table VALUES ('', '$title', '$desc', '$image_name', '$thumb_w', '$thumb_h')";
mysql_query($query);


mysql_close();
?>

[bpat1434]

Okay, let me try and help you out here.

<?php

// Max allowed size of the image (in bytes):
$maxUploadSize = 200000;

// The paths to save the image(s):
$photo_dir = './image_uploads/';
$photo_url = 'image_uploads/';

// The max width, or height of the thumbnail:
$thumb['width'] = 250;
$thumb['height'] = 100;
$thumb['resolution'] = 85;

// Uploaded file's Temp Name:
$tempname = $_FILES['image']['tmp_name'];

// Define the image name:
$image_name = time().$_FILES['image']['name'].'.jpg';

// Is the file uploaded:
if(is_uploaded_file($tempname))
{
	// Get the orginal dimensions:
	$o_dims = getimagesize($tempname);

if($o_dims === false || $o_dims[2] != 2)
{
	exit('<h2 style="color: #f00;">Image Upload Failed!!</h2>');
}

// Put the original dimensions into something easier to work with:
$width = $o_dims[0];
$height = $o_dims[1];

// Create a new image based on the temp:
$orig_image = imagecreatefromjpeg($tempname);


// Get the proportionate thumbnail dimensions:
if($height >= $width)
{
	$t_width = ceil(($thumb['height']/$height)*$width);
	$t_height = $thumb['height'];
}
elseif($width > $height)
{
	$t_width = $thumb['width'];
	$t_height = ceil(($thumb['width']/$width)*$height);
}

// Create a new image with our thumb dimensions:
$new_image = imagecreatetruecolor($t_width, $t_height);

// Now, copy the old image to the new image magically resizing it:
if(imagecopyresampled($new_image, $orig_image, 0, 0, 0, 0, $t_width, $t_height, $width, $height) === false)
{
	exit('<h2 style="color: #f00;">Image Resizing Failed!!</h2>');
}

if(@imagejpeg($new_image, $photo_dir.'thumb_'.$image_name, $thumb['resolution']) === false)
{
	exit('<h2 style="color:#f00;">Creating Thumb Failed!!</h2>');
}

if(move_uploaded_file($tempname, $photo_dir.$image_name) === false)
{
	exit('<h2 style="color:#f00;">Unable to move uploaded file!!</h2>');
}

/*
 * Here is where you insert the information and all:
*/
$title = mysql_real_escape_string($_POST['title']);
$desc = mysql_real_escape_string($_POST['desc']);

$query = "INSERT INTO $table VALUES ('', '$title', '$desc', '$image_name', '$t_width', '$t_height')";
$result = mysql_query($query);

if(mysql_affected_rows() > 0)
{
	exit('<h2 style="color: #090;">Success!</h2>');
}
else
{
	exit('<h2 style="color:#f00;">Insertion into database failed!!</h2>');
}
}
else
{
	exit('<h2 style="color:#f00;">No file uploaded!!</h2>');
}
?>

If you just read through my comments, most of the customization is at the top. You can define how large you want your thumbnail to be. When the image is resized, it will determine which dimension (height or width) is the largest, and resize it proportionately to that. So if the image is taller, it will create an image with a height no larger than $thumb['height'], and vice-versa with the width.

If you look toward the bottom, you'll see I put the thumb and the regular image in the same directory (the thumbnail preceeded by a "thumb_"). You can modify this as needed.

Hope that helps. Any questions, just ask!!

[David_P]

Well, it's progress! Thanks.

But I'm getting this in the database - 1182055128adjusting_ropes.jpg.jpg - with 2 .jpg at the end of the script, and it's making 2 sets of each picture in the image_uploads folder.

[rowanparker]

Just a side note:

You shouldn't have register_globals turned on.
See this.

[bpat1434]

David:

On the line that say "$image_name = ...." just remove the ".jpg" from it.

If you don't want both pictures (thumb and original) in the uploads folder, remove this section of code:

if(move_uploaded_file($tempname, $photo_dir.$image_name) === false)
    {
        exit('<h2 style="color:#f00;">Unable to move uploaded file!!</h2>');
    } 

[David_P]

OK, I added this:

// The paths to save the image(s):
$thumb_dir = './thumb_uploads/';
$thumb_url = 'thumb_uploads/'; 
$photo_dir = './image_uploads/'; 
$photo_url = 'image_uploads/'; 

and changed this:

if(@imagejpeg($new_image, $photo_dir.'thumb_'.$image_name, $thumb['resolution']) === false)

to this:

    if(@imagejpeg($new_image, $thumb_dir.$image_name, $thumb['resolution']) === false)

Since the thumbnail will be placed in it's own folder I didn't feel that using 'thumb_ was necessary. But please check to see if my leaving out this '. is right or not.

Since I have defined dir's and url's for both the thumbs and original images I really don't need to remove this do I?

if(move_uploaded_file($tempname, $photo_dir.$image_name) === false) 
    { 
        exit('<h2 style="color:#f00;">Unable to move uploaded file!!</h2>'); 
    }

Also, what is the purpose of having numbers added to the front of the uploaded images? I'm guessing that it is to prevent having two images with the same name, is this correct? I'd rather not have 2 images that are the same instead of 2 images named the same.

If I'm guessing correctly and the reason for tacking on the numbers is to give each identical image it's own separate identity, I'd rather replace that with code that prevents an image from being added if the image name is already in use. Maybe check it with something similar to this:

// Make sure the image name isn't already in use.
$query = "SELECT * FROM $table WHERE image_name='$image_name '";
$result = mysql_query ($query) or trigger_error("Query: $query\n<br>MySQL Error: " . mysql_error());

if (mysql_num_rows($result) == 0) { // Available.

add it

} else {

echo "That image name is already in use";
}

Another thing I've noticed is that the images are placed on the server with user, group ownership belonging to httpd:httpd, which means that I cannot delete them via FTP. I uploaded some images using my FTP and dropped in one of those single page scripts that makes thumbnails of images already on the server and it httpd'd them and I couldn't delete them. I had to use this:

<?php 
// Delete the file 
unlink( "/home/user/www/folder/uploaded_files/thumbz/tb_1181766989-hospital.jpg" );
?> 

This is a php file that I had to upload to my root. I had to keep changing the file name and re-uploading the script and refreshing the page to delete each image individually. As you can image this was a very time consuming task. So is this just typical of anytime you add an image to the server or can you introduce code assigning user and group ownership?

Thanks for all your help thus far.

[bpat1434]

David P wrote:

Since the thumbnail will be placed in it's own folder I didn't feel that using 'thumb_ was necessary. But please check to see if my leaving out this '. is right or not.

What you have there is fine and should work.

David P wrote:

Also, what is the purpose of having numbers added to the front of the uploaded images? I'm guessing that it is to prevent having two images with the same name, is this correct? I'd rather not have 2 images that are the same instead of 2 images named the same.

If I'm guessing correctly and the reason for tacking on the numbers is to give each identical image it's own separate identity, I'd rather replace that with code that prevents an image from being added if the image name is already in use. Maybe check it with something similar to this:

Yes, the numbers were the timestamp of the upload. The point was to have it so that no files got over-written. But you can put a check in to see if it's been uploaded. You'd place that towards the top of the script (after you make sure the image is uploaded, before you do any manipulation) so that you can keep the server-load down if it is a duplicate; HOWEVER just because an image is named the same, does not mean it's the same image. You may want to take a hash of the image and compare those. Typically it's done with an [man]md5/man hash, but a [man]sha1/man hash will work as well.

David P wrote:

So is this just typical of anytime you add an image to the server or can you introduce code assigning user and group ownership?

Well, I'm guessing your server doesn't use su_exec or suPHP. What those do is run Apache as the specified user. But in your case, Apache is running as the user httpd. To counter-act the permissions, you can use [man]chmod/man on the files and change it to 755 or 777.

[David_P]

You'd place that towards the top of the script (after you make sure the image is uploaded, before you do any manipulation) so that you can keep the server-load down if it is a duplicate

Would I put it just under this?

// Define the image name: 
$image_name = time().$_FILES['image']['name'].'.jpg';

[bpat1434]

No, you'd do it just inside the main if statement:

// Is the file uploaded:
if(is_uploaded_file($tempname))
{ 

But it could go above it. Either way will work. Choose one and go with it 🙂

[David_P]

I thought maybe that's where it should go, but I wasn't sure.

Look, the page that is calling this page has some code that I would like for you to take a peek at and see if I did it right. Basically what it does is check the table $cat to see if there's anything in it. If there is, it displays a drop-down form field with the Categories listed in that table. It also displays a regular form text field and the user can either select a Category from the drop down to file their image under or create a new Category using the regular form text field.

Also, I added some code to the bottom of this page we've been working on to handle the information on the sending page to go into the database. The code above I'll call Code-1 and the one you've been helping me with I'll call Code-2.

Code-2 I'm getting errors. I'll show both pages and if you don't mind please take a peek at them and see if 1- I'm on point and 2- gross mistakes.

Code-1

<form action="image_process_c.php" enctype="multipart/form-data" method="post">

<p>
<?php

include("includes/dbconnect.php");
$query = "SELECT * FROM $cat";
$result = mysql_query($query) or die('Error, query failed');

if (mysql_num_rows($result) == 0) {

echo "
Add a new Category:<br>
<input type='text' size='55' name='cat_name'><br>
Category Description:<br>
<textarea name='cat_desc' rows='2' cols='55' wrap=virtual></textarea><br><br>
";

} else {

echo "
Select a Category for your Picture:<br>
<select name='file'>
<option value'' selected='selected'>Select a Category</option>
";

$query = "SELECT * FROM $cat";
$result = mysql_query($query) or die('Error, query failed');

while ($row = mysql_fetch_array($result, MYSQL_ASSOC)) {

$id = $row['id'];
$cat_name = $row['cat_name'];

echo "<option value='$id'>$cat_name</option>";

}
}

echo "
</select><br><br>

Or Add a new Category:<br>
<input type='text' size='55' name='cat_name'><br>
Category Description:<br>
<textarea name='cat_desc' rows='2' cols='55' wrap=virtual></textarea><br><br><br>
";
?>

-- the form fields goes here --

</form>

Code-2

     /* 
     * Here is where you insert the information and all: 
    */ 

include("includes/dbconnect.php");

$file = $_GET['file'];

// Check to see if Category exists with this id
// if so bypass adding it to the $cat table and put straight into $table
$query = "SELECT id FROM $cat WHERE id='$file'";
$result = mysql_query($query) or die('Error, query failed: ' . mysql_error());

if (mysql_num_rows($result) != 0) {

// Make the query
$cat_id = $file;
$title = mysql_real_escape_string($_POST['title']); 
$desc = mysql_real_escape_string($_POST['desc']);
$thumb_w = $t_width;
$thumb_h = $t_height;    

$query = "INSERT INTO $table VALUES ('', '$cat_id', '$title', '$desc', '$image_name', '$thumb_w', '$thumb_h')"; 
$result = mysql_query($query); 

if(mysql_affected_rows() > 0) {

    exit('<h2 style="color: #090">Success!</h2><br><a href="index_c.php">View Pics</a> &nbsp;&nbsp;&bull;&nbsp;&nbsp; <a href="image_upload_d.php">Add Another Pic</a>'); 

} else {

    exit('<h2 style="color:#f00">Insertion into database failed!!</h2>'); 

} else {

exit('<h2 style="color:#f00">No file uploaded!!</h2>');

}

} else {

// If Category doesn't exist add it to the $cat table
$query = "INSERT INTO $cat VALUES ('', '$cat_name', '$cat_desc')";
 mysql_query($query);

$cat_id = mysql_insert_id();

$title = mysql_real_escape_string($_POST['title']); 
$desc = mysql_real_escape_string($_POST['desc']);
$thumb_w = $t_width;
$thumb_h = $t_height;

$query = "INSERT INTO $table VALUES ('', '$cat_id', '$title', '$desc', '$image_name', '$thumb_w', '$thumb_h')"; 
$result = mysql_query($query); 

if(mysql_affected_rows() > 0) {

    exit('<h2 style="color: #090;">Success!</h2><br><a href="index_b.php">View Pics</a> &nbsp;&nbsp;&bull;&nbsp;&nbsp; <a href="image_process_b.php">Add Another Pic</a>'); 

} else {

    exit('<h2 style="color:#f00;">Insertion into database failed!!</h2>');

}

} else {

exit('<h2 style="color:#f00;">No file uploaded!!</h2>'); 
}

I have not successfully run this script, so I don't know if it'll work or not. The current error I get when I run this is this: parse error, unexpected T_ELSE in /local/home/user/www/gallery/image_process_c.php on line 119 and the line in question I've placed in bold below.

Here is the entire page that you and I have been woking on. I haven't included the "check to see if image_name exist" in yet, but I did change a couple of things, that maybe I shouldn't have - I don't know.

<?php 

// Max allowed size of the image (in bytes): 
$maxUploadSize = 200000; 

// The paths to save the image(s):
$thumb_dir = './thumb_uploads/';
$thumb_url = 'thumb_uploads/'; 
$photo_dir = './image_uploads/'; 
$photo_url = 'image_uploads/'; 

// The max width, or height of the thumbnail: 
$thumb['width'] = 120; 
$thumb['height'] = 100; 
$thumb['resolution'] = 80; 

// Uploaded file's Temp Name: 
$tempname = $_FILES['image']['tmp_name']; 

// Define the image name: 
$image_name = $_FILES['image']['name']; 

// Is the file uploaded: 
if(is_uploaded_file($tempname)) 
{ 
    // Get the orginal dimensions: 
    $o_dims = getimagesize($tempname); 

if($o_dims === false || $o_dims[2] != 2) 
{ 
    exit('<h2 style="color:#f00">Image Upload Failed!!</h2>'); 
} 

// Put the original dimensions into something easier to work with: 
$width = $o_dims[0]; 
$height = $o_dims[1]; 

// Create a new image based on the temp: 
$orig_image = imagecreatefromjpeg($tempname); 


// Get the proportionate thumbnail dimensions: 
if($height >= $width) 
{ 
    $t_width = ceil(($thumb['height']/$height)*$width); 
    $t_height = $thumb['height']; 
} 
elseif($width > $height) 
{ 
    $t_width = $thumb['width']; 
    $t_height = ceil(($thumb['width']/$width)*$height); 
} 

// Create a new image with our thumb dimensions: 
$new_image = imagecreatetruecolor($t_width, $t_height); 

// Now, copy the old image to the new image magically resizing it: 
if(imagecopyresampled($new_image, $orig_image, 0, 0, 0, 0, $t_width, $t_height, $width, $height) === false) 
{ 
    exit('<h2 style="color: #f00;">Image Resizing Failed!!</h2>'); 
} 

if(@imagejpeg($new_image, $thumb_dir.'thumb_'.$image_name, $thumb['resolution']) === false) 
{ 
    exit('<h2 style="color:#f00;">Creating Thumb Failed!!</h2>'); 
} 

if(move_uploaded_file($tempname, $photo_dir.$image_name) === false) 
{ 
exit('<h2 style="color:#f00;">Unable to move uploaded file!!</h2>'); 
} 

/* 
 * Here is where you insert the information and all: 
*/ 

include("includes/dbconnect.php");

$file = $_GET['file'];

// Check to see if Category exists with this id
$query = "SELECT id FROM $cat WHERE id='$file'";
$result = mysql_query($query) or die('Error, query failed: ' . mysql_error());

if (mysql_num_rows($result) != 0) {

// Make the query
$cat_id = $file;
$title = mysql_real_escape_string($_POST['title']); 
$desc = mysql_real_escape_string($_POST['desc']);
$thumb_w = $t_width;
$thumb_h = $t_height;    

$query = "INSERT INTO $table VALUES ('', '$cat_id', '$title', '$desc', '$image_name', '$thumb_w', '$thumb_h')"; 
$result = mysql_query($query); 

if(mysql_affected_rows() > 0) {

    exit('<h2 style="color: #090">Success!</h2><br><a href="index_c.php">View Pics</a> &nbsp;&nbsp;&bull;&nbsp;&nbsp; <a href="image_upload_d.php">Add Another Pic</a>'); 

} else {

    exit('<h2 style="color:#f00">Insertion into database failed!!</h2>'); 

[B]} else {[/B]

exit('<h2 style="color:#f00">No file uploaded!!</h2>');

}

} else {

$query = "INSERT INTO $cat VALUES ('', '$cat_name', '$cat_desc')";
 mysql_query($query);

$cat_id = mysql_insert_id();

$title = mysql_real_escape_string($_POST['title']); 
$desc = mysql_real_escape_string($_POST['desc']);
$thumb_w = $t_width;
$thumb_h = $t_height;

$query = "INSERT INTO $table VALUES ('', '$cat_id', '$title', '$desc', '$image_name', '$thumb_w', '$thumb_h')"; 
$result = mysql_query($query); 

if(mysql_affected_rows() > 0) {

    exit('<h2 style="color: #090;">Success!</h2><br><a href="index_b.php">View Pics</a> &nbsp;&nbsp;&bull;&nbsp;&nbsp; <a href="image_process_b.php">Add Another Pic</a>'); 

} else {

    exit('<h2 style="color:#f00;">Insertion into database failed!!</h2>');

}

} else {

exit('<h2 style="color:#f00;">No file uploaded!!</h2>'); 
} 
?> 

[bpat1434]

In Code-1, there's no reason to query your database twice for the same information. Run the query once, if there are results, loop through them for the categories.

As for the parse error, you need to make sure that every "else" has an "if" statement. If it does, then you need to make sure you have the correct number of curly braces "{}" so that the logic is correct.

[David_P]

OK, I took out the extra query in Code-1.

Code-2 is a mess. I've been working on this thing all day and and I just can't get it working for nothing. No matter what I change the error comes to rest on that one } else {.

The more I change in a desperate attempt to fix the damn thing the more I know I'm screwing it up.

I know it's important to get curly brackets right, but the trouble is that I don't know how far down the code to take the main big IF's brackets. I don't know where to cut them off in the code. Like this one for instance:

if (mysql_num_rows($result) == 0) {

I put on paper the open brackets and the closed brackets to make sure I have the same number of closed as I do open. I've had to add a couple here and there, but I don't know if they're right or not. I suspect the later since the damn thing keeps delivering errors.

[David_P]

Bill, you've been very helpful and I don't blame you for washing your hands of this. But maybe someone else can help me finish this thing so I can put it behind me. I've already invested too much time on it, 14 hours straight now.

Something somewhere is not right. I wish I could figure it out, but I can't.

<?php 

// Max allowed size of the image (in bytes): 
$maxUploadSize = 200000; 

// The paths to save the image(s):
$thumb_dir = './thumb_uploads/';
$thumb_url = 'thumb_uploads/'; 
$photo_dir = './image_uploads/'; 
$photo_url = 'image_uploads/'; 

// The max width, or height of the thumbnail: 
$thumb['width'] = 120; 
$thumb['height'] = 100; 
$thumb['resolution'] = 80; 

// Uploaded file's Temp Name: 
$tempname = $_FILES['image']['tmp_name']; 

// Define the image name: 
$image_name = $_FILES['image']['name']; 

// Is the file uploaded: 
if(is_uploaded_file($tempname)) 
{ 
    // Get the orginal dimensions: 
    $o_dims = getimagesize($tempname); 

if($o_dims === false || $o_dims[2] != 2) 
{ 
    exit('<h2 style="color:#f00">Image Upload Failed!!</h2>'); 
} 

// Put the original dimensions into something easier to work with: 
$width = $o_dims[0]; 
$height = $o_dims[1]; 

// Create a new image based on the temp: 
$orig_image = imagecreatefromjpeg($tempname); 


// Get the proportionate thumbnail dimensions: 
if($height >= $width) 
{ 
    $t_width = ceil(($thumb['height']/$height)*$width); 
    $t_height = $thumb['height']; 
} 
elseif($width > $height) 
{ 
    $t_width = $thumb['width']; 
    $t_height = ceil(($thumb['width']/$width)*$height); 
} 

// Create a new image with our thumb dimensions: 
$new_image = imagecreatetruecolor($t_width, $t_height); 

// Now, copy the old image to the new image magically resizing it: 
if(imagecopyresampled($new_image, $orig_image, 0, 0, 0, 0, $t_width, $t_height, $width, $height) === false) 
{ 
    exit('<h2 style="color: #f00;">Image Resizing Failed!!</h2>'); 
} 

if(@imagejpeg($new_image, $thumb_dir.'thumb_'.$image_name, $thumb['resolution']) === false) 
{ 
    exit('<h2 style="color:#f00;">Creating Thumb Failed!!</h2>'); 
} 

if(move_uploaded_file($tempname, $photo_dir.$image_name) === false) 
{ 
exit('<h2 style="color:#f00;">Unable to move uploaded file!!</h2>'); 
} 
}

/* 
 * Here is where you insert the information and all: 
*/ 

include("includes/dbconnect.php");

$file = $_GET['file'];

// Check to see if Category exists with this id
$query = "SELECT id FROM $cat WHERE id='$file'";
$result = mysql_query($query) or die('Error, query failed: ' . mysql_error());

$id = $file;

if (mysql_num_rows($result) == 0) {

$query = "INSERT INTO $cat VALUES ('', '$cat_name', '$cat_desc')";
 mysql_query($query);

$cat_id = mysql_insert_id();

$title = mysql_real_escape_string($_POST['title']); 
$desc = mysql_real_escape_string($_POST['desc']);
$thumb_w = $t_width;
$thumb_h = $t_height;

$query = "INSERT INTO $table VALUES ('', '$cat_id', '$title', '$desc', '$image_name', '$thumb_w', '$thumb_h')"; 
$result = mysql_query($query);


if(mysql_affected_rows() > 0) {

    exit('<h2 style="color: #090">Success!</h2><br><a href="index_b.php">View Pics</a><br><br><a href="image_process_b.php">Add Another Pic</a>'); 

} elseif {

    exit('<h2 style="color:#f00">Insertion into database failed!!</h2>');

   }

   } else {

exit('<h2 style="color:#f00">No file uploaded!!</h2>'); 






} else {




// Make the query
$cat_id = $file;
$title = mysql_real_escape_string($_POST['title']); 
$desc = mysql_real_escape_string($_POST['desc']);
$thumb_w = $t_width;
$thumb_h = $t_height;    

$query = "INSERT INTO $table VALUES ('', '$cat_id', '$title', '$desc', '$image_name', '$thumb_w', '$thumb_h')"; 
$result = mysql_query($query); 

if(mysql_affected_rows() > 0) {

    exit('<h2 style="color: #090">Success!</h2><br><a href="index_c.php">View Pics</a> &nbsp;&nbsp;&bull;&nbsp;&nbsp; <a href="image_upload_d.php">Add Another Pic</a>'); 

} elseif {

    exit('<h2 style="color:#f00">Insertion into database failed!!</h2>'); 

   } 

   } else {

exit('<h2 style="color:#f00">No file uploaded!!</h2>');

}


?> 

[bpat1434]

Nonsense!! I didn't give up on you, I just had to go to bed 😉

So I went through the code, and found that your problem was a couple things:

1. You didn't specify any conditional statements for the elseif() sections.

2. The else's were really for the if() statement 2 back, not the most recent one.

So I changed your code, and put it in the way I think you were trying to. It should not error. It's syntactically okay (checked using php4, php5).

<?php

// Max allowed size of the image (in bytes):
$maxUploadSize = 200000;

// The paths to save the image(s):
$thumb_dir = './thumb_uploads/';
$thumb_url = 'thumb_uploads/';
$photo_dir = './image_uploads/';
$photo_url = 'image_uploads/';

// The max width, or height of the thumbnail:
$thumb['width'] = 120;
$thumb['height'] = 100;
$thumb['resolution'] = 80;

// Uploaded file's Temp Name:
$tempname = $_FILES['image']['tmp_name'];

// Define the image name:
$image_name = $_FILES['image']['name'];

// Is the file uploaded:
if(is_uploaded_file($tempname))
{
    // Get the orginal dimensions:
    $o_dims = getimagesize($tempname);

if($o_dims === false || $o_dims[2] != 2)
{
    exit('<h2 style="color:#f00">Image Upload Failed!!</h2>');
}

// Put the original dimensions into something easier to work with:
$width = $o_dims[0];
$height = $o_dims[1];

// Create a new image based on the temp:
$orig_image = imagecreatefromjpeg($tempname);


// Get the proportionate thumbnail dimensions:
if($height >= $width)
{
    $t_width = ceil(($thumb['height']/$height)*$width);
    $t_height = $thumb['height'];
}
elseif($width > $height)
{
    $t_width = $thumb['width'];
    $t_height = ceil(($thumb['width']/$width)*$height);
}

// Create a new image with our thumb dimensions:
$new_image = imagecreatetruecolor($t_width, $t_height);

// Now, copy the old image to the new image magically resizing it:
if(imagecopyresampled($new_image, $orig_image, 0, 0, 0, 0, $t_width, $t_height, $width, $height) === false)
{
    exit('<h2 style="color: #f00;">Image Resizing Failed!!</h2>');
}

if(@imagejpeg($new_image, $thumb_dir.'thumb_'.$image_name, $thumb['resolution']) === false)
{
    exit('<h2 style="color:#f00;">Creating Thumb Failed!!</h2>');
}

if(move_uploaded_file($tempname, $photo_dir.$image_name) === false)
{
	exit('<h2 style="color:#f00;">Unable to move uploaded file!!</h2>');
}

/*
 * Here is where you insert the information and all:
*/

include("includes/dbconnect.php");

$file = $_GET['file'];

// Check to see if Category exists with this id
$query = "SELECT id FROM $cat WHERE id='$file'";
$result = mysql_query($query) or die('Error, query failed: ' . mysql_error());

$id = $file;

if (mysql_num_rows($result) == 0) 
{

	$query = "INSERT INTO $cat VALUES ('', '$cat_name', '$cat_desc')";
	mysql_query($query);

	$cat_id = mysql_insert_id();

	$title = mysql_real_escape_string($_POST['title']);
	$desc = mysql_real_escape_string($_POST['desc']);
	$thumb_w = $t_width;
	$thumb_h = $t_height;

	$query = "INSERT INTO $table VALUES ('', '$cat_id', '$title', '$desc', '$image_name', '$thumb_w', '$thumb_h')";
	$result = mysql_query($query);


	if(mysql_affected_rows() > 0) 
	{
		exit('<h2 style="color: #090">Success!</h2><br><a href="index_b.php">View Pics</a><br><br><a href="image_process_b.php">Add Another Pic</a>');

	} 
	else 
	{
		exit('<h2 style="color:#f00">Insertion into database failed!!</h2>');
	} 
}
else 
{
	// Make the query
	$cat_id = $file;
	$title = mysql_real_escape_string($_POST['title']);
	$desc = mysql_real_escape_string($_POST['desc']);
	$thumb_w = $t_width;
	$thumb_h = $t_height;    

	$query = "INSERT INTO $table VALUES ('', '$cat_id', '$title', '$desc', '$image_name', '$thumb_w', '$thumb_h')";
	$result = mysql_query($query);

	if(mysql_affected_rows() > 0) 
	{

		exit('<h2 style="color: #090">Success!</h2><br><a href="index_c.php">View Pics</a> &nbsp;&nbsp;&bull;&nbsp;&nbsp; <a href="image_upload_d.php">Add Another Pic</a>');

	} 
	else
	{
		exit('<h2 style="color:#f00">Insertion into database failed!!</h2>');

	}
}
}
else
{
	exit('<h2 style="color:#f00;">No File Uploaded!!</h2>');
}

?> 

[David_P]

I haven't tried your script above yet, but I will. I've worked on this script for about 20 hours a day for the last 3 days. I've got to get it done so I can move on to other things. I hate not finishing something or accepting the fact that something can't be done and having to scrap it.

I have changed this script so much trying to find something that will work I'm nearly screen blind. I did have some success in that I was finally able to create a new Category and put a picture in it. But I'm not able to put more than one picture in each category.

I had the trouble of whenever the category table was queried to see if it already contained a name that was entered in the upload form, it would advance it one. Nothing was entered since the name was already in there but it created a blank row. I had the id set for auto-increment and figuring this was the problem I dropped it. Now the category table only has cat_name and cat_desc, which is probably all it needs anyway. However, the problem persisted.

Of course this was after I kept on having a parse error message on that else line. Once I got rid of the else lines the script would go forward, although it wouldn't do anything.

So I've had some progress but it's not enough.

Here is my form and processing code as it stands for the next 20 minutes.

I don't think these are right in the processing script.

if ($file != '' AND $file_new == '')

// image_upload.php

<?php
echo "
<fieldset>
<legend><strong>Set the Category for Picture</strong></legend><br>
";

include("includes/dbconnect.php");
$query = "SELECT * FROM $cat";
$result = mysql_query($query) or die('Error, query failed');

echo "
<strong>Select a Category for your Picture:</strong><br>
<select name='file'>
<option selected='selected'>Select a Category</option>
";

while($row = mysql_fetch_array($result, MYSQL_ASSOC))

{

$cat_name = stripslashes($row['cat_name']);

echo "
<option value='$cat_name'>$cat_name</option>
";

}

echo "
</select><br><br>

<h1>-- OR --</h1>

<strong>Create a new Category:</strong><br>
<input type='text' size='55' name='file_new'><br>
Enter a description for your category:<br>
<textarea name='cat_desc' rows='2' cols='55' wrap=virtual></textarea>
<br><br>
</fieldset><br><br>
";
?>

--- picture info part of form here --

// image_processing.php

--- image manipluation here ---

/* 
 * Here is where you insert the information and all: 
*/ 


include("includes/dbconnect.php");

$file = mysql_real_escape_string($_POST['file']);
$file_new = mysql_real_escape_string($_POST['file_new']);

if ($file != '' AND $file_new == '')

{

$cat_name = $file;
$title = mysql_real_escape_string($_POST['title']); 
$desc = mysql_real_escape_string($_POST['desc']);
$thumb_w = $t_width;
$thumb_h = $t_height;
$width = $width;
$height = $height;   

$query = "INSERT INTO $table VALUES ('', '$cat_name', '$title', '$desc', '$image_name', '$thumb_w', '$thumb_h', '$width', '$height')"; 
$result = mysql_query($query); 

echo "<h2 style='color: #090'>Success! New Category and Picture Added</h2>
<br>
<a href='index_c.php'>View Pics</a>
<br><br>
<a href='image_upload_new.php'>Add Another Pic</a>
";

}

if ($file == '' AND $file_new != '')

{

$cat_name = $file_new;
$cat_desc = mysql_real_escape_string($_POST['cat_desc']);


$query = "INSERT INTO $cat VALUES ('$cat_name', '$cat_desc')";
 mysql_query($query);

$title = mysql_real_escape_string($_POST['title']); 
$desc = mysql_real_escape_string($_POST['desc']);
$thumb_w = $t_width;
$thumb_h = $t_height;
$width = $width;
$height = $height;

$query = "INSERT INTO $table VALUES ('', '$cat_name', '$title', '$desc', '$image_name', '$thumb_w', '$thumb_h', '$width', '$height')"; 
$result = mysql_query($query);

echo "<h2 style='color: #090'>Success! Picture Added</h2>
<br>
<a href='index_c.php'>View Pics</a>
<br><br>
<a href='image_upload_new.php'>Add Another Pic</a>
";

}

if ($file != '' AND $file_new != '')

{

echo "
      You cannot select an existing Category for your picture <strong>AND</strong> create a NEW Category for it as well.
      Please hit your back button and choose one or the other.
     ";

mysql_close();
}

[David_P]

I changed the

if ($file != '' AND $file_new == '')

Now I can put more pictures into existing categories, but I can no longer create new categories. I don't understand why this is so hard. It seems like it should be a very simple thing. There needs to be a more straight forward and easier scripting language than php. This is just rediculous.

// image_processing.php 

--- image manipluation here --- 

/* 
 * Here is where you insert the information and all: 
*/ 


include("includes/dbconnect.php"); 

$file = mysql_real_escape_string($_POST['file']); 
$file_new = mysql_real_escape_string($_POST['file_new']); 

if(isset($file)) 

{ 

$cat_name = $file; 
$title = mysql_real_escape_string($_POST['title']); 
$desc = mysql_real_escape_string($_POST['desc']); 
$thumb_w = $t_width; 
$thumb_h = $t_height; 
$width = $width; 
$height = $height;    

$query = "INSERT INTO $table VALUES ('', '$cat_name', '$title', '$desc', '$image_name', '$thumb_w', '$thumb_h', '$width', '$height')"; 
$result = mysql_query($query); 

echo "<h2 style='color: #090'>Success! New Category and Picture Added</h2> 
<br> 
<a href='index_c.php'>View Pics</a> 
<br><br> 
<a href='image_upload_new.php'>Add Another Pic</a> 
"; 

} 

elseif(isset($file_new)) 

{ 

$cat_name = $file_new; 
$cat_desc = mysql_real_escape_string($_POST['cat_desc']); 


$query = "INSERT INTO $cat VALUES ('$cat_name', '$cat_desc')"; 
 mysql_query($query); 

$title = mysql_real_escape_string($_POST['title']); 
$desc = mysql_real_escape_string($_POST['desc']); 
$thumb_w = $t_width; 
$thumb_h = $t_height; 
$width = $width; 
$height = $height; 

$query = "INSERT INTO $table VALUES ('', '$cat_name', '$title', '$desc', '$image_name', '$thumb_w', '$thumb_h', '$width', '$height')"; 
$result = mysql_query($query); 

echo "<h2 style='color: #090'>Success! Picture Added</h2> 
<br> 
<a href='index_c.php'>View Pics</a> 
<br><br> 
<a href='image_upload_new.php'>Add Another Pic</a> 
"; 

} 

else 

{ 

echo " 
      You cannot select an existing Category for your picture <strong>AND</strong> create a NEW Category for it as well. 
      Please hit your back button and choose one or the other. 
     "; 

mysql_close(); 
}

[bpat1434]

I took your code, and created my own database. I used these three files and got some pretty good results. Here are the codes i used:

index.php

<?php

include('includes/dbconnect.php');

$query = "SELECT c.id, c.name, c.description
FROM david_p__categories AS c
ORDER BY c.name ASC";
$result = mysql_query($query) or db_error($query, __FILE__, __LINE__);

echo '<div>
	<span style="font-weight: bold; font-size: large;">Categories:</span>';

if(mysql_num_rows($result) > 0)
{
	while($row = mysql_fetch_array($result))
	{
		echo '&nbsp;&nbsp;<a href="index.php?cid='.$row['id'].'">'.$row['name'].'</a>';
	}
}
else
{
	echo '<span style="color:#900;">No Categories Defined Yet</span>';
}
echo '
</div>';

mysql_free_result($result);

$query = "SELECT i.id, i.title, i.name, i.descrip, i.id_cat, c.name AS cat_name
FROM david_p__images AS i
INNER JOIN david_p__categories AS c
  ON i.id_cat=c.id
ORDER BY i.id, i.title ASC";

$result = mysql_query($query) or db_error($query, __FILE__, __LINE__);

echo '<h2>Images</h2>';

if(mysql_num_rows($result) < 1)
{
	echo '<div><p>Currently no images have been uploaded.</p></div>';
}
else
{
	while($row = mysql_fetch_array($result))
	{
		$images[$row['id_cat']][] = array('id'=>$row['id'], 'title'=>$row['title'], 'name'=>$row['name'], 'descrip'=>$row['descrip']);
		$cat[$row['id_cat']] = $row['cat_name'];
	}
	mysql_free_result($result);

foreach($cat as $id=>$c)
{
	echo '
<h3>'.$c.'</h3>
	<table>
		<tr>';

	$i=0;

	foreach($images[$id] as $img)
	{
		$i++;

		echo '
		<td>
			<a href="image_uploads/'.urlencode($img['name']).'" title="'.$img['descrip'].'"><img src="thumb_uploads/'.urlencode($img['name']).'" /></a>
		</td>';

		if($i%4==0)
		{
			echo '
	</tr>
	<tr>';
		}
	}

	echo '
	</tr>
</table>';
}
}

?>

image_upload.php

<?php

// Max allowed size of the image (in bytes):
$maxUploadSize = 200000;

// The paths to save the image(s):
$thumb_dir = './thumb_uploads/';
$thumb_url = 'thumb_uploads/';
$photo_dir = './image_uploads/';
$photo_url = 'image_uploads/';

// The max width, or height of the thumbnail:
$thumb['width'] = 120;
$thumb['height'] = 100;
$thumb['resolution'] = 80;

// Uploaded file's Temp Name:
$tempname = $_FILES['image']['tmp_name'];

// Define the image name:
$image_name = $_FILES['image']['name'];

// Is the file uploaded:
if(is_uploaded_file($tempname))
{
	// Get the orginal dimensions:
	$o_dims = getimagesize($tempname);

if($o_dims === false || $o_dims[2] != 2)
{
	exit('<h2 style="color: #f00;">Image Upload Failed!!</h2>');
}

// Put the original dimensions into something easier to work with:
$width = $o_dims[0];
$height = $o_dims[1];

// Create a new image based on the temp:
$orig_image = imagecreatefromjpeg($tempname);


// Get the proportionate thumbnail dimensions:
if($height >= $width)
{
	$t_width = ceil(($thumb['height']/$height)*$width);
	$t_height = $thumb['height'];
}
else
{
	$t_width = $thumb['width'];
	$t_height = ceil(($thumb['width']/$width)*$height);
}

// Create a new image with our thumb dimensions:
$new_image = imagecreatetruecolor($t_width, $t_height);

// Now, copy the old image to the new image magically resizing it:
if(imagecopyresampled($new_image, $orig_image, 0, 0, 0, 0, $t_width, $t_height, $width, $height) === false)
{
	exit('<h2 style="color: #f00;">Image Resizing Failed!!</h2>');
}

if(@imagejpeg($new_image, $thumb_dir.$image_name, $thumb['resolution']) === false)
{
	exit('<h2 style="color:#f00;">Creating Thumb Failed!!</h2>');
}

if(move_uploaded_file($tempname, $photo_dir.$image_name) === false)
{
	exit('<h2 style="color:#f00;">Unable to move uploaded file!!</h2>');
}

/*
 * Here is where you insert the information and all:
*/

include('includes/dbconnect.php');

$img_title = mysql_real_escape_string($_POST['img_title']);
$img_descrip = mysql_real_escape_string($_POST['img_descrip']);
$file = !isset($_POST['file']) ? 'create' : mysql_real_escape_string($_POST['file']);
$cat_name = mysql_real_escape_string($_POST['cat_name']);
$cat_descrip = mysql_real_escape_string($_POST['cat_descrip']);

if($file == 'create')
{
	$query = "SELECT id
FROM david_p__categories
WHERE name = '$cat_name'";
		$rslt = mysql_query($query) or db_error($query, __FILE__, __LINE__);
		if(mysql_num_rows($rslt) > 0)
		{
			$catID = mysql_result($rslt, 0, 'id');
		}
		else
		{
			$query = "INSERT INTO david_p__categories
	(`name`, `description`)
VALUES
	('$cat_name', '$cat_descrip')";
			$rslt = mysql_query($query) or db_error($query, __FILE__, __LINE__);

		$query = "SELECT id
FROM david_p__categories
WHERE name = '$cat_name'";
			$rslt = mysql_query($query) or db_error($query, __FILE__, __LINE__);
			$catID = mysql_result($rslt, 0, 'id');
		}
	}
	else
	{
		$catID = $file;
	}

$query = "INSERT INTO david_p__images 
(`title`, `descrip`, `thumb_width`, `thumb_height`, `width`, `height`, `id_cat`, `name`) 
VALUES 
	('$img_title', '$img_descrip', '$t_width', '$t_height', '$width', '$height', '$catID', '$image_name')";
	$result = mysql_query($query);

if(mysql_affected_rows() > 0)
{
	exit('<h2 style="color: #090;">Success!</h2>');
}
else
{
	exit('<h2 style="color:#f00;">Insertion into database failed!!</h2>'.mysql_error());
}
}
else
{
	exit('<h2 style="color:#f00;">No file uploaded!!</h2>');
}
?>

image_process.php

<?php

echo '<form action="image_process.php" method="post" enctype="multipart/form-data">
<fieldset>
	<legend><strong>Set the Category for the Picture</strong></legend><br />
	<label for="iCat"><strong>Select a Category for your Picture:</strong></label>';

include('includes/dbconnect.php');

$query = "SELECT c.id, c.name
FROM david_p__categories AS c
ORDER BY c.name ASC";
$result = mysql_query($query) or db_error($query, __FILE__, __LINE__);

if(mysql_num_rows($result) > 0)
{
	echo '
	<select name="file" id="iCat">
		<option value="null" selected="selected">Select a Category</option>';
	while($row = mysql_fetch_array($result))
	{
		echo '
		<option value="'.$row['id'].'">'.$row['name'].'</option>';
	}
	echo '
		<option value="create">Create a New Category</option>';
}
else
{
	echo '
	<select name="file" id="iCat" disabled="disabled">
		<option value="create" selected="selected">Create a Category Below ...</option>';
}

echo '
	</select><br /><br />

<h1>-- OR --</h1>

<label for="iCatName"><strong>Create a new Category:</strong></label>
<input type="text" name="cat_name" id="iCatName" /><br /><br />

<label for="iCatDescrip"><strong>Enter a Description for your Category:</label><br />
<textarea name="cat_descrip" id="iCatDescrip" rows="2" cols="55" wrap="virtual"></textarea>
</fieldset>

<fieldset>
	<legend><strong>Image to Upload</strong></legend><br /><br />

<label for="iImgTitle">Title for Your Image:</label>
<input type="text" name="img_title" id="iImgTitle" /><br /><br />

<label for="iImage">Browse for Image:</label>
<input type="file" name="image" id="iImage" /><br /><br />

<label for="iImgDescrip">Description of Your Image:</label>
<textarea name="img_descrip" id="iImgDescrip" rows="2" cols="55" wrap="virtual"></textarea>
</fieldset>

<input type="submit" name="submit" value="Submit" />
</form>';

?>

You'll have to change the database tables, and maybe some columns, but you can see (and try out) the scripts on my personal server here
You can upload files by changing the url to be image_upload.php instead of index.php.

[David_P]

I did finally get mine working. But I see in your script where you used much fancier code writing than what's in mine. I'm going to copy it to my computer and study it.

On a side note, have you heard of xampp? I installed it some time back on my computer but haven't used it in a while, but I would like to use it more when working on codes. Trouble is, I have forgotten how to get to it. I used to open a browser and type in local/... something and it would come up.

Oh well, I might be able to get that info from their site.

Thanks for all your help!

P.S. I ceated the db's and on the index.php I get an error saying "Call to undefined function: db_error()"

db_error($query, __FILE__, __LINE__);