[RESOLVED] foreach() assistance needed....

[mokinho]

I'm working with a multiple select list and for some reason my foreach() statement is entering the word "Array" in the mysql database instead of the selected items from the multiple select list..

I have the select section set as...

<select name="carlist[]" size="1" multiple="multiple">
            <option >Select a car</option>
            <?php
do {  

?>
            <option value="<?php echo $row_rscars['nick_name']?>"><?php echo $row_rscars['nick_name']?></option>
            <?php
} while ($row_rscars = mysql_fetch_assoc($rscars));
  $rows = mysql_num_rows($rscarss);
  if($rows > 0) {
      mysql_data_seek($rscars, 0);
	  $row_rscars = mysql_fetch_assoc($rscars);
  }
?>
        </select>

and here is my code for the foreach() statment...

foreach ($_POST['carlist'] as $value) {
					  $insertSQL = sprintf("INSERT INTO carservice (username, nick_name, service_provider, evaluation, lotnum, service_date, follow_up_date, total_cost, addnotes) VALUES ('{$_SESSION[loginUsername]}', %s, %s, %s, %s, %s, %s, %s, %s)",
                       GetSQLValueString($_POST['carlist'], "text"),
	       GetSQLValueString($_POST['service_provider'], "text"),
 	       GetSQLValueString($_POST['evaluation'], "text"),
                       GetSQLValueString($_POST['lotnum'], "text"),
                       GetSQLValueString($_POST['service_date'], "date"),
                       GetSQLValueString($_POST['follow_up_date'], "date"),
                       GetSQLValueString($_POST['total_cost'], "double"),
                       GetSQLValueString($_POST['addnotes'], "text"));

All help is appreciated!

[bradgrafelman]

Well, seeing as how you left out the rest of your sprintf() statement, there's not much we can do but guess as to what's wrong with it...

[mokinho]

I've updated with this requested missing information...

[bradgrafelman]

As I expected to see, you're using $_POST['carlist'] inside the loop. The point of the foreach() loop was to retrieve each value of this array individually, but you failed to use $value.

[nemonoman]

Read Brad's post below, and my new answer below that.

Original post:
$carlist is an array of arrays
You dereference $POST['carlist']:
foreach ($POST['carlist'] as $value){

each $value is an array that needs its own foreach statement.
I have no idea what in the hell your data looks like: the structure is mindnumbing.
BUT if you want to figure out your problem,
echo out the values in $_POST after submitting the form.

print_r($_POST);

will do the trick.

[bradgrafelman]

nemonoman wrote:

$carlist is an array of arrays
...
each $value is an array that needs its own foreach statement.

No, $_POST['carlist'] is an array of values (the selected OPTIONS' values in the SELECT element).

[nemonoman]

Brad is right but it still appears that that each $value is an array that needs to be referenced like $value[1] or $value['carlist'] or whatever. I can't make head or tail of things based on what you've posted as a question: what IS clear is that with your posted code, you are passing an ARRAY to the INSERT statement, rather than a number or a string.

[mokinho]

bradgrafelman: As I expected to see, you're using $_POST['carlist'] inside the loop. The point of the foreach() loop was to retrieve each value of this array individually, but you failed to use $value.

I'm not understanding your response can you break it down for me?

[Protato]

Read your foreach line outloud to yourself, Brad's post should make since.

foreach $_POST['carlist'] AS $value

Foreach X as Y; X is a collection of values where Y is a single value of X.

If this is still not making since run this code:

$array = array(0,1,2,3,4,5);

echo $array;   //this will print out "array"
foreach($array as $value){
   echo $value;   //echo one value from the array, and it's repeating untill no more values.
}

[bradgrafelman]

As Protato points out, you're using the wrong variable inside the loop - you should be using $value, because this is the variable that contains the single value during each iteration of the loop.

[mokinho]

thanks to you all I got it workin'

I had to change the following script to what you see below...

foreach ($_POST['carlist'] as $value) {
					  $insertSQL = sprintf("INSERT INTO carservice (username, nick_name, service_provider, evaluation, lotnum, service_date, follow_up_date, total_cost, addnotes) VALUES ('{$_SESSION[loginUsername]}', [COLOR="Red"]added '$value'[/COLOR], %s, %s, %s, %s, %s, %s, %s)",
              [COLOR="red"]removed GetSQLValueString($_POST['carlist'], "text"),[/COLOR]
                       GetSQLValueString($_POST['service_provider'], "text"),
 	       GetSQLValueString($_POST['evaluation'], "text"),
                       GetSQLValueString($_POST['lotnum'], "text"),
                       GetSQLValueString($_POST['service_date'], "date"),
                       GetSQLValueString($_POST['follow_up_date'], "date"),
                       GetSQLValueString($_POST['total_cost'], "double"),
                       GetSQLValueString($_POST['addnotes'], "text"));

Thanks a bunch for assisting. I hope I wasn't too obtuse. however, you all taught me rather than gave me. Thanks again.

[bradgrafelman]

Actually, you might want to use the same format you had before so that you can pass $value through GetSQLValueString(), otherwise you're opening yourself to SQL injection attacks.

[mokinho]

I tried the following and none of them worked. What my database recieved for this field was 'null'

GetSQLValueString($_POST['$value], "text"),

GetSQLValueString($_POST['value'], "text"),

[bradgrafelman]

Well the variable you're using is simply $value, so it should be:

GetSQLValueString($value, "text"),

[mokinho]

Thad be it...

I changed to...

GetSQLValueString($value, "text"),

and it worked like a charm! (but you already knew that, I know)

I thank you for your knowledge, over and over again!😃

another item checked off the to do list!

[nemonoman]

oopss...