[RESOLVED] Multiple CheckBox Problem

maskme

Dear All

I've 15 records displaying in a page. Each record has a field called "Sports" which stores values separated by semicolon ";" "Football;Cricket;Basketball"

When I'm retrieving the values, i use explode and assign each values of check box. Works perfect with No Problem.

I'm storing the Record ID as a hidden field.

I'm the admin and I uncheck "Football" or "Basketball" in couple of records and click on Submit and give the following code

if ($action == "submit")
 {
   for ($j=0; $j < count($recordid); $j++)  

   {
     if (count($sports[$j]) == 0) $sportslist = "None";
      else 
       {
         for ($i=0; $i < count($sports[$j]); $i++) 
         {
           $sportslist .= $sports[$i].";";
         }						
      }				

   $utpquery = "UPDATE user_sports SET sports='$sportslist' where urecord = $recordid[$j]";
   $utpresult = mysql_query($utpquery) or die("Query failed 1");
  } 

header("Location: verifyrecord.php");
exit;
 }

Once I execute the above, I check the Database and find the ones which I had Unchecked have become in Multiples
For e.g.
"Basketball;Basketball;Basketball;Basketball;Basketball;"

I don't know what am I doing wrong here.

Could anyone give me a Hint???

Thanks

Piranha

First thing is that you really should normalize your tables. Look in this article to get to know more about it.

Second thing is that you should make sure that all variables you use in database queries (both insert/update/select/delete and other queries) are safe from SQL injection. You can read this, this and this articles to get to know more.

Other than the above points (both VERY important) I can't find any obvious error in your code. But then, when you have solved the above problems the code will look a little different, so no need to put a lot of effort into it now.

maskme

Thanks I would consider this, but still I need to solve the problem which is at Hand.

It is like:
there are Main Category and Sub Category (Which have values stored in Check Box) that Needs to be Updated

+Fruits
- Apple [CHECKBOX]
- Banana [CHECKBOX]
- Mango [CHECKBOX]

+Vegetable
- Cauliflower [CHECKBOX]
- Lady Finger [CHECKBOX]
- Potato [CHECKBOX]

Either of these are checked or not checked

I'm having a hidden field called catid which stores the Category ID

So how should I update multiple check box values. The first post is exactly what I mean and the code which i've written does not work

Help

maskme

Here is the section that works with no hitch gives me all the selection as per the user had done while filling up the form initially

<form name="frm1" method="post" action="sports.php?page=update">
<table cellspacing="0" cellpadding="0" border="0">
<?
$squery = "select * from user_sports";
$sresult = mysql_query($squery) or die ("Query Failed");
while( $row = mysql_fetch_array( $sresult ) )
{
$sports = explode(";",$row['sports']);			
?>
        <tr> 
          <td>
            <input name="recordid[]" type="hidden" value="<? echo $row['urecord'] ?>">
          <input name="sports[]" type="checkbox" id="sports[]" value="Football" <? if (is_array($sports) == TRUE) { if (in_array("Football", $sports)) echo "CHECKED"; } ?>>
              Football<br> <input name="sports[]" type="checkbox" id="sports[]" value="Cricket" <? if (is_array($sports) == TRUE) { if (in_array("Cricket", $sports)) echo "CHECKED"; } ?>>
              Cricket <br> <input name="sports[]" type="checkbox" id="sports[]" value="Basketball" <? if (is_array($sports) == TRUE) { if (in_array("Basketball", $sports)) echo "CHECKED"; } ?>>
              Basketball 
              </td>
        </tr>
<?
 }
?>
</table>
</form>

Here is the section which does not work, for which i need to be able to update.

<?
if ($page == "update")
 {
   for ($j=0; $j < count($recordid); $j++)  

   {
     if (count($sports[$j]) == 0) $sportslist = "None";
      else
       {
         for ($i=0; $i < count($sports[$j]); $i++)
         {
           $sportslist .= $sports[$i].";";
         }                        

      }                

	echo $recordid[$j];
	echo "<br>";
	echo $sportslist;
	echo "<br>";

//$utpquery = "UPDATE user_sports SET sports='$sportslist' where urecord = $recordid[$j]";
//$utpresult = mysql_query($utpquery) or die("Query failed 1");
} 
//header("Location: sports.php");
//exit;
 }
?>

maskme

The solution for the above post is as follows for those who need it in future and face the same problem

<form name="frm1" method="post" action="sports.php?page=update">
<table cellspacing="0" cellpadding="0" border="0">
<?
$squery = "select * from user_sports";
$sresult = mysql_query($squery) or die ("Query Failed");
$number = 0;
while( $row = mysql_fetch_array( $sresult ) )
{
$sports = explode(";",$row['sports']);			
?>
        <tr> 
          <td>
            <input name="recordid[$number]" type="hidden" value="<? echo $row['urecord'] ?>">
          <input name="sports[$number][]" type="checkbox" id="sports[]" value="Football" <? if (is_array($sports) == TRUE) { if (in_array("Football", $sports)) echo "CHECKED"; } ?>>
              Football<br> <input name="sports[$number][]" type="checkbox" id="sports[]" value="Cricket" <? if (is_array($sports) == TRUE) { if (in_array("Cricket", $sports)) echo "CHECKED"; } ?>>
              Cricket <br> <input name="sports[$number][]" type="checkbox" id="sports[]" value="Basketball" <? if (is_array($sports) == TRUE) { if (in_array("Basketball", $sports)) echo "CHECKED"; } ?>>
              Basketball 
              </td>
        </tr>
<?
 $number++;}
?>
</table>
</form>

<?
if ($page == "update")
 {
   for ($j=0; $j < count($recordid); $j++)  

   {
     if (count($sports[$j]) == 0) $sportslist = "None";
      else $sportslist = implode(';', $sports[$j]);


	echo $recordid[$j];
	echo "<br>";
	echo $sportslist;
	echo "<br>";

$utpquery = "UPDATE user_sports SET sports='$sportslist' where urecord = $recordid[$j]";
$utpresult = mysql_query($utpquery) or die("Query failed 1");
 } 
header("Location: sports.php");
exit;
 }
?>

bradgrafelman

Don't forget to mark this thread resolved.