checkbox delete script

badzv

hi guys...really need a help on my problem with my delete script. the script below is my form script wc contains also the delete script. works fine with php 4.3.3 but it wont work on 4.3.9...any ideas?

<form name="form1" method="post" action="">
                  <tr>
                    <td height="30" align="left" valign="top"><table width="100%" height="28"  border="0" cellpadding="0" cellspacing="0" class="heading">
                      <tr>
                        <td align="left" valign="middle">Property</td>
                          <td width="90" align="left" valign="middle">Status</td>
                          <td width="90" align="left" valign="middle">Location:</td>
                          <td width="90" align="left" valign="middle">District:</td>
                          <td width="90" align="left" valign="middle">Postcode:</td>
                          <td width="55" align="left" valign="middle">Checkbox:</td>
                        </tr>
                      </table>			        </td>
                  </tr>
                  <tr>
                    <?php if ($totalRows_rsProperties > 0) {?>
                      <td align="right" valign="top">
					 <?php do { ?>
                          <table width="100%" height="40"  border="0" cellpadding="0" cellspacing="0" class="itemMain">
                            <tr>
                              <td align="left" valign="middle"><a href="properties_detail.php?id=<?php echo $row_rsProperties['id']; ?>"><?php echo $row_rsProperties['numF']; ?> <?php echo $row_rsProperties['streetF']; ?></a></td>
                              <td width="90" align="left" valign="middle"><?php echo $row_rsProperties['statF']; ?></td>
                              <td width="90" align="left" valign="middle"><?php echo $row_rsProperties['locF']; ?></td>
                              <td width="90" align="left" valign="middle"><?php echo $row_rsProperties['disF']; ?></td>
                              <td width="90" align="left" valign="middle"><?php echo $row_rsProperties['postF']; ?></td>
                              <td width="55" align="left" valign="middle"><input type="checkbox" name="checkbox[]" id="checkbox[]" value="<?php echo $row_rsProperties['id']; ?>"></td>
                            </tr>
                          </table>
                          <?php } while ($row_rsProperties = mysql_fetch_assoc($rsProperties)); ?><br>
                        <input name="delete" type="submit" id="delete" value="Delete">
						</td>
                      <?php } else { ?>
                    <td class="itemMain">
                      No Data.                  </td>
					  <?php }?>
                  </tr>
				  <?php

				if($delete){


					for($i=0;$i<$totalRows_rsProperties;$i++){
						$delID = $checkbox[$i];

						$sql = "DELETE FROM property WHERE id='$delID'";
						$result = mysql_query($sql);
					}

					if($result){
						$deleteGoTo = "properties.php";
						if (isset($_SERVER['QUERY_STRING'])) {
						   $deleteGoTo .= (strpos($deleteGoTo, '?')) ? "&" : "?";
						   $deleteGoTo .= $_SERVER['QUERY_STRING'];
						 }
					 header(sprintf("Location: %s", $deleteGoTo));
					}
				}
				mysql_close();
?>

            </form>

hope someone could give me an insight on this to why it works in an older version of php 4.3.3 and not on 4.3.9

thanks! much appreciated to those who will help!

gardnc

Assuming this is on the same server, just new php ver (since other things could be at fault other that php if new server) then some debugging. If the record is not getting deleted add a temp echo $sql;exit; after:

                        $sql = "DELETE FROM property WHERE id='$delID'";

to see what the query looks like. IF correct then perhaps it's not PHP - try the query in a command line to wee what is wrong), if wrong then look back to see where you set $delID. Add additional echos to see what the data contains and find the issue. Just a little legwork will get you to the basic problem - which may yet not be PHP codeing specific.

badzv

i tried placing a echo "you"; right after the line :

<?php
if ($delete) {

but unfortunately the string "you" didnt appear. when i placed the echo "you" like this :

<?php
echo "you";
if ($delete) {

the string "you" appears. its obvious that the condition if ($delete) { didnt make it to TRUE, but why? i cant see any problem on it. the condition should be TRUE once i click the Delete button.

anyone?

badzv

anyone, please????????????

gardnc

Why is the php code in the form? It should be operated upon after the form data is submitted. There is no action in the form so I guess you don't submit.

Remember the php is server based and you must submit back to the server for it to be able to react to what the browser collects in the form.

$delete never has anything in it so is skipped in the decision. You proved that with your debug.

cahva

This probably is the good old register_globals issue. You had register_globals set to on in the previous version and now its off(which is good).

You have to use $POST['delete'] instead of $delete. So $POST for post variables, $_GET for get variables and so on.. Read about predefined variables in the manual.

And yes.. Put the form processing to the beginning of the script.