File Upload dir error?

[crawfd]

It's 'trying' to upload a file ...but when I go to check in my proposals folder ain't a nothin' there! My hosting provider contacted me and said my path was
d:\hosting\sayitdigital (so I'm assuming my full path to my proposals directory is d:\hosting\sayitdigital\test\proposals\?). Since this site is on a windows server that supports php do I use '/' or '\' in my path name?? If I'm supposed to use '\' how should that look in my move_uploaded file line? Me confused. Thanks

<?			
if (($_FILES['fileToUpload']) && ($_POST['submit'])) {

if (($_FILES["fileToUpload"]["type"] == "application/msword") || 
($_FILES["fileToUpload"]["name"] == "")
  && ($_FILES["fileToUpload"]["size"] < 10000))
  {
  move_uploaded_file($_FILES["fileToUpload"]["tmp_name"],
    $_SERVER['DOCUMENT_ROOT']."/test/proposals/" . $_FILES["fileToUpload"]["name"]);


// some mail delivery code here


$message = "<table width=\"100%\" border=\"0\" cellspacing=\"0\" cellpadding=\"5\">
<tr><td class=\"body1\"><font color=\"red\"><b>Thank You $name for contacting us! We will be contacting you shortly.</b></font></td></tr></table><br>";	

} else {
  $error = "<table width=\"100%\" border=\"0\" cellspacing=\"0\" cellpadding=\"5\">
<tr><td class=\"body1\"><font color=\"red\"><b>Files must be in Word Format and less than 10,000Kb</b></font></td></tr></table><br>";
  }


}


?>

[bradgrafelman]

1. I normally use forward slashes, even on my Windows server at home. You might want to echo out $_SERVER['DOCUMENT_ROOT'], however, as mixing-and-matching forward slashes with backslashes is definitely not a good thing to do.

2. If it's failing to move the file, it should give you an error message. Is display_errors set to On and error_reporting set to E_ALL ?

[crawfd]

When I echo out $_SERVER['DOCUMENT_ROOT'] I get:

d:\hosting\sayitdigital

so at the moment my script is using a mix and match of forward and backward slashes. How do I overcome this or shouldn't it matter?.

[crawfd]

I think I may have run into a possible issue. When moving files does the folder you're moving the file into need permissions set to 777? Currently the chmod is 554 for both my test and proposals directory. Of course it's not letting my change the chmod settings in ftp ..I'll probably have to contact my hosting provider.

This is what I have now which logically should work?

  move_uploaded_file($_FILES["fileToUpload"]["tmp_name"],
    $_SERVER['DOCUMENT_ROOT']."\test\proposals" . \$_FILES["fileToUpload"]["name"]);

[bradgrafelman]

crawfd wrote:

This is what I have now which logically should work?

Nope, there's a problem: a backslash in a double-quoted string has a special meaning - it's an escape character.

Though "\p" isn't a special sequence, "\t" will insert a tab (which obviously doesn't work well in a file path). If you're going to use backslashes, you need to double them up. The first backslash escapes the second one (cancelling out the special backslash sequence).

Now, if you plan on making your script portable, you might consider doing something like:

$root = str_replace('\\', '/', $_SERVER['DOCUMENT_ROOT']);
move_uploaded_file($_FILES["fileToUpload"]["tmp_name"], 
    $root."/test/proposals" . $_FILES["fileToUpload"]["name"]);

[crawfd]

Still not working .........do i have to change the permission of my proposals directory to 777? I just contacted my hosting provider and they won't allow me to change permissinos on directories! What do I do now?

if (($_FILES['fileToUpload']) && ($_POST['submit'])) {

if (($_FILES["fileToUpload"]["type"] == "application/msword") || 
($_FILES["fileToUpload"]["name"] == "")
  && ($_FILES["fileToUpload"]["size"] < 10000))
  {

  $root = str_replace('\\', '/', $_SERVER['DOCUMENT_ROOT']); 
move_uploaded_file($_FILES["fileToUpload"]["tmp_name"], 
    $root."/test/proposals/" . $_FILES["fileToUpload"]["name"]); 

$message = "<table width=\"100%\" border=\"0\" cellspacing=\"0\" cellpadding=\"5\">
<tr><td class=\"body1\"><font color=\"red\"><b>Thank You $name for contacting us! We will be contacting you shortly.</b></font></td></tr></table><br>";	

} else {
  $error = "<table width=\"100%\" border=\"0\" cellspacing=\"0\" cellpadding=\"5\">
<tr><td class=\"body1\"><font color=\"red\"><b>File upload must be in Word Format and less than 10,000Kb</b></font></td></tr></table><br>";
  }


}

[bradgrafelman]

crawfd wrote:

they won't allow me to change permissinos on directories! What do I do now?

Look around for a competent host.