[RESOLVED] php problems, im a newb

[jerrylouise]

<?php
// Database connect //
include("../include/database.php");
// do stuff //
$usrname = $_GET['usrname'];
if (isset($_GET['id']) and is_numeric($_GET['id'])) {
$id = $_GET['id'];
} else {
     exit ('invalid id');
}
$sql = mysql_query("SELECT * FROM site_comments WHERE artical_id = $id ORDER BY id DESC");
if (!$sql) {
     exit ('Error retrieving comments..');
}
$numofrows = mysql_num_rows($sql); 

//Start Loop //
while ($row = mysql_fetch_array ($sql)) {
print '<table width="100%" border="0" cellpadding="4" cellspacing="0" >';
//start colour changing loop//
			for($i = 0; $i < $numofrows; $i++)	{
				$row = @mysql_fetch_array($sql);
				// the ifelse //

				if($i % 2) 
					{ 
						print '<TR class="pink">';
					} 
			else 
						{ 
							print '<TR class="wight">';
						}
//the output//
	printf("<td>%s</td><td>%s</td>", $row["3"], $row["2"]);
//end colour changing loop//
													}

														}
print "</table>";
//end //?>


<table width="100%" border="0" cellspacing="0" cellpadding="4">
	<tr>
	    <td class="addcomment"><a href="javascript:ajaxpage('includes-functions/site_comment_add.php?id=<? print $id ?>&usrname=<? print $usrname ?>', 'comadd');">Add a comment</a></td>
	</tr>
  		<tr>
</table>
<div id="comadd">
</div>

Ok the above code is for my sites comments system, however it always misses out the latest entry. So if there are 5 comments it will only print out the 4 oldest. I know the problem is someware in the loop but i cant work it out :mad:

[NogDog]

Every time you call mysql_fetch_array(), you "move" the query result row pointer to the next row. Since you call mysql_fetch_array() right after your "// start loop" comment, but then have a separate for loop inside of that loop where you call mysql_fetch_array() to actually output data, that internal loop will start with the second result row. A better structure would be

if(mysql_num_rows($sql)) // we got some results
{
   print '<table width="100%" border="0" cellpadding="4" cellspacing="0" >';
   $i = 0;
   while($row = mysql_fetch_array($sql))
   {
      if($i++ % 2)
      {
         print '<tr class="pink">';
      }
      else
      {
        print '<tr class="wight">';
      }
      //the output//
      printf("<td>%s</td><td>%s</td></tr>", $row["3"], $row["2"]);
   }
   print '</table>';
}
else
{
   print '<p class="error">Sorry, no data was found.</p>';
}

[jerrylouise]

thanks

[bradgrafelman]

Don't forget to mark this thread resolved.