Pagination script not doing what it should

[boombanguk]

Hi,

I'm currently trying to get this script to work, heres the link to the online test version

http://www.flashculture.com/pagetestV4.php

This is the script

<?php 

   require_once('connect.php');

$limit          = 25;                
$query_count    = "SELECT count(*) FROM news";     
$result_count   = mysql_query($query_count);     
$totalrows      = mysql_num_rows($result_count);  

if(empty($page)){ 
    $page = 1; 
} 


$limitvalue = $page * $limit - ($limit);  
$query  = "SELECT * FROM news ORDER BY date DESC LIMIT $limitvalue, $limit";         
$result = mysql_query($query) or die("Error: " . mysql_error());  

if(mysql_num_rows($result) == 0){ 
    echo("Nothing to Display!"); 
} 

$bgcolor = "#E0E0E0"; // light gray 

echo("<table>"); 

while($row = mysql_fetch_array($result)){ 
    if ($bgcolor == "#E0E0E0"){ 
        $bgcolor = "#FFFFFF"; 
    }else{ 
        $bgcolor = "#E0E0E0"; 
    } 

echo("<tr bgcolor=".$bgcolor.">n<td>"); 
echo($row["title"]); 
echo("</td>n<td>"); 
echo($row["description"]); 
echo("</td>n</tr>"); 
} 

echo("</table>"); 

if($page != 1){  
    $pageprev = $page--; 

    echo("<a href=\"$PHP_SELF&page=$pageprev\">PREV".$limit."</a> ");  
}else{ 
    echo("PREV".$limit." "); 
} 

$numofpages = $totalrows / $limit;  

for($i = 1; $i <= $numofpages; $i++){ 
    if($i == $page){ 
        echo($i." "); 
    }else{ 
        echo("<a href=\"$PHP_SELF?page=$i\">$i</a> "); 
    } 
} 


if(($totalrows % $limit) != 0){ 
    if($i == $page){ 
        echo($i." "); 
    }else{ 
        echo("<a href=\"$PHP_SELF?page=$i\">$i</a> "); 
    } 
} 

if(($totalrows - ($limit * $page)) > 0){ 
    $pagenext = $page++; 

    echo("<a href=\"$PHP_SELF?page=$pagenext\">NEXT".$limit."</a>");  
}else{ 
    echo("NEXT".$limit);  
} 

mysql_free_result($result); 

?> 

It displays "n"'s for some odd reason at the top of the page, and the page links don't work at the bottom, any ideas?

[etully]

I haven't examined the whole page but I notice one particular problem that would be a good place to start.

$page-- doesn't mean "one less than $page". It means make $page one less.
Likewise, $page++ doesn't mean one higher. It means make $page one higher.

So when you say $prevpage = $page--;
you are actually changing the value of $page. Then later when you say,
$nextpage = $page++;
you are adding one back to $page... so you are setting it's value back to what it was before. So $nextpage actually equals the current page!! (and that's not what you want).

Therefore, you should really say:
$prevpage = $page-1;
and
$nextpage = $page+1;

That's a good place to start anyway.

[ClarkF1]

If the n is supposed to be a newline character, you're missing the \ before in each case.

echo("<tr bgcolor=".$bgcolor.">n<td>");
    echo($row["title"]);
    echo("</td>n<td>");
    echo($row["description"]);
    echo("</td>n</tr>");

should be

echo("<tr bgcolor=".$bgcolor.">\n<td>");
    echo($row["title"]);
    echo("</td>\n<td>");
    echo($row["description"]);
    echo("</td>\n</tr>");