"Convert "hours:minutes" to "total_minutes" and back"

sebjlan

I found the following script on this website but I cannot get it to work!

http://www.phpbuilder.com/snippet/detail.php?type=snippet&id=189

How come this won't work:

<html>
<head>
</head>
<body>
<?php
# Transform hours like "1:45" into the total number of minutes, "105".
function hoursToMinutes($hours)
{
	if (strstr($hours, ':'))
	{
		# Split hours and minutes.
		$separatedData = split(':', $hours);

	$minutesInHours    = $separatedData[0] * 60;
	$minutesInDecimals = $separatedData[1];

	$totalMinutes = $minutesInHours + $minutesInDecimals;
}
else
{
	$totalMinutes = $hours * 60;
}

return $totalMinutes;
}

# Transform minutes like "105" into hours like "1:45".
function minutesToHours($minutes)
{
	$hours          = floor($minutes / 60);
	$decimalMinutes = $minutes - floor($minutes/60) * 60;

# Put it together.
$hoursMinutes = sprintf("%d:%02.0f", $hours, $decimalMinutes);
return $hoursMinutes;
}

hoursToMinutes("1:45");

?>
</body>
</html>

gardnc

The script doesn't do anything with the output of the function. Adding

echo hoursToMinutes("1:45");

in the last php code line will show you the function is working.

laserlight

gardnc is right about the output. The functions return a value rather than print it.

That said, I would say that they could be improved. For example, [man]strstr/man could be replaced by [man]strpos/man, and [man]split/man by [man]explode/man. floor($minutes / 60) is calculated twice, and can be replaced by a cast to int in the first place. I might write them as:

// Transform hours like "1:45" into the total number of minutes, "105".
function hoursToMinutes($hours)
{
    $minutes = 0;
    if (strpos($hours, ':') !== false)
    {
        // Split hours and minutes.
        list($hours, $minutes) = explode(':', $hours);
    }
    return $hours * 60 + $minutes;
}

// Transform minutes like "105" into hours like "1:45".
function minutesToHours($minutes)
{
    $hours = (int)($minutes / 60);
    $minutes -= $hours * 60;
    return sprintf("%d:%02.0f", $hours, $minutes);
}