PHP and mysql help please

deepika

I have tried to write a code in php for an online booking form which should validate the data input and should send the data into the database. Please find the attached document where i have pasted my code. but i dont know why the code isn't working. When i press submit, its not validating the data and not even sending the values to my database. Could anyone please help me in doing this.

thank u in advance

MOD EDIT: Attachment removed. Code as follows:

<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Transitional//EN" "http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head>
<meta http-equiv="Content-Type" content="text/html; charset=iso-8859-1" />
<title>Todaton Service Garage </title>
<style type="text/css">
<!--
.style1 {
	color: #FF0000;
	font-weight: bold;
}
-->
</style>
</head>

<body bgcolor="#FFFFFF">
<?php
$hostname = "localhost";
$username = "user";
$password = "password";

$dbh = mysql_connect($hostname,$username,$password) or die("Could not connect: ".mysql_error());
echo "connection established!!";

mysql_select_db(deepika_todaton,$dbh);
$result= "create table customer( cutomerid int(10) NOT NULL AUTO_INCREMENT, name varchar(20) NOT NULL, address varchar(20) NOT NULL, postcode varchar(10) NOT NULL, telenumber varchar(20) NOT NULL, email varchar(30) NOT NULL, registration_number varchar(20) NOT NULL, model varchar(10) NOT NULL, date varchar(10) NOT NULL, time varchar(10) NOT NULL, primary key(customerid), unique id(customerid))";
mysql_query($result);
mysql_close($dbh);
?>


<img src="Mazda RX8 Yellow - 1024x768.jpg" alt="todaton" width="368" height="254" align="left" /><br/>
<h1><p><font face="arial,tahoma,verdana,verdana,geneva,arial,helvetica,sens-serif" color="#FF0000"> TODATON </font></p></h1><br/>

<p> Welcome to todaton online booking system for MOT testing</p>
<p> We are a leading motor service and repairing garage in north london</p>
<p> Please fill in the form below</p>
<?php

$hostname = "localhost";
$username = "user";
$password = "password";

$dbh = mysql_connect($hostname,$username,$password) or die("Could not connect: ".mysql_error());
echo "connection established!!";

mysql_select_db("deepika_todaton",$dbh);

//variables from the booking form
$name = $_POST["name"];
$address = $_POST["address"];
$postcode = $_POST["postcode"];
$telenumber = $_POST["telenumber"];
$email = $_POST["email"];
$model = $_POST["model"];
$day = $_POST["day"];
$month = $_POST["month"];
$year = $_POST["year"];
$time = $_POST["time"];
$date = "$year"."-"."$month"."-"."$day";

if(isset($_POST["submit"])){
	$error_msg='';
	//$t_result = mysql_query($t_query) or die(mysql_error());

if(trim($name)==''){
	$error_msg.="Please enter your name.<br>";
}
if(trim($postcode)==''){
	$error_msg.="Please enter your Postcode.<br>";
}
if((trim($email)=='') || (!ereg("[0-9a-z]([-_.]?[0-9a-z])*@[0-9a-z]([-.]?[0-9a-z])*\\.[a-z]", $email))){
	$error_msg.="Please enter a valid e-mail address.<br>";
	$email = '';
}
if((trim($telephone)=='') || (!is_numeric($telephone))){
	$error_msg.="Please enter a valid telephone number.<br>";
	$telephone = '';
}
//if(!count($t_row) >1){
	//$error_msg.="Sorry time already booked. Choose another time slot";
//}
else{

	//$c_insert = mysql_query($c_query) or die (mysql_error());
	//$b_insert = mysql_query($b_query) or die (mysql_error());
	$error_msg.="Thank for you booking. We'll see you soon.<br>";
	echo count($t_row);
	while($t_row = mysql_fetch_array($t_result)){
		echo $t_row['Time']."<br/>";
	}

}
}



$query= "insert into customer VALUES (' ', '$name', '$address', '$postcode', '$telenumber', '$email', 
'$model', '$date', '$time')";

mysql_query($query);
mysql_close($dbh);
?>


<form action="todaton.php" method="post">
<fieldset><legend> Enter your information in the form below: </legend>
<p><span class="style1">*</span><b>Name:</b>
<input type="text" name="name" size="20" maxlength="40" value="<?php echo $name?>"/></p>
<p><b>Address:</b><input type="text" name="address" size="40" maxlength="60" value="<?php echo $address>"/></p>
<p><span class="style1">*</span><b>Postcode:</b>
<input type="text" name="postcode" size="20" maxlength="40" value="<?php echo $postcode;?>"/></p>
<p><span class="style1">*</span><b>Telenumber:</b><input type="text" name="telenumber" size="20" maxlength="40" value="<?php echo $telenumber?>"/></p>
<p><span class="style1">*</span><b>Email:</b><input type="text" name="email" size="40" maxlength="60" value="<?php echo $email?>" /></p>
<p><span class="style1">*</span><b>Vehicle Registration Number:</b><input type="text" name="vehicle registration number" size="20" maxlength="40"/></p>
<p><b>Vehicle Model:</b>
<select name="cars">
<option value="please select">--Please select--</option>
<option value="Volvo">Volvo</option>
<option value="Saab">Saab</option>
<option value="Fiat">Fiat</option>
<option value="Audi">Audi</option>
</select></p>
<p><span class="style1">*</span><b>Booking Date</b>
<select name="day" >
<option value="day" selected="selected">Day</option>
                <option value="1">1</option>
                <option value="2">2</option>
                <option value="3">3</option>
                <option value="4">4</option>
                <option value="5">5</option>
                <option value="6">6</option>
                <option value="7">7</option>
                <option value="8">8</option>
                <option value="9">9</option>
                <option value="10">10</option>
                <option value="11">11</option>
                <option value="12">12</option>
                <option value="13">13</option>
                <option value="14">14</option>
                <option value="15">15</option>
                <option value="16">16</option>
                <option value="17">17</option>
                <option value="18">18</option>
                <option value="19">19</option>
                <option value="20">20</option>
                <option value="21">21</option>
                <option value="22">22</option>
                <option value="23">23</option>
                <option value="24">24</option>
                <option value="25">25</option>
                <option value="26">26</option>
                <option value="27">27</option>
                <option value="28">28</option>
                <option value="29">29</option>
                <option value="30">30</option>
                <option value="31">31</option>
  </select>

        <select name="month">
		<option value="month" selected="selected">Month</option>
            <option value="01">Jan</option>
            <option value="02">Feb</option>
            <option value="03">Mar</option>
            <option value="04">Apr</option>
            <option value="05">May</option>
            <option value="06">Jun</option>
            <option value="07">Jul</option>
            <option value="08">Aug</option>
            <option value="09">Sep</option>
            <option value="10">Oct</option>
            <option value="11">Nov</option>
            <option value="12">Dec</option>
  </select>
            <select name="year">
              <option value="year" selected="selected">Year</option>
              <option value="2007">2007</option>
              <option value="2008">2008</option>
            </select>

<p><span class="style1">*</span><b>Booking Time</b>
<select name="Booking time">
<option value="please select">--Please select--</option>
<option value="8:30AM">8:30AM</option>
<option value="9:15AM">9:15AM</option>
<option value="10:00AM">10:00AM</option>
<option value="10:45AM">10:45AM</option>
<option value="11:30AM">11:30AM</option>
<option value="12:15PM">12:15PM</option>
<option value="01:00PM">01:00PM</option>
<option value="01:45PM">01:45PM</option>
<option value="02:30PM">02:30PM</option>
<option value="03:15PM">03:15PM</option>
<option value="04:00PM">04:00PM</option>
<option value="04:45PM">04:45PM</option>
<option value="05:30PM">05:30PM</option>
</select>
</p>
<p><span class="style1">*</span> are mandatory fields</p>
</fieldset>
<div align="center"><input type="submit" name="submit" value="submit information"/></div>
</form>
</body>
</html>

johanafm

Not everyone is using a machine from which they can view word documents. You're probably more likely to get help if you include the code here. Copy-paste the code you have problems with and enclose it in either [ php ] [ /php] tags, withouth the whitespaces beteen '[' and "php" and ']' or enclose it in [ code ] [ /code ] tags if it's not php code.

bradgrafelman

I agree with johanafm, so I removed your attachment and placed the code in the body of your post.

In addition, I don't think it's wise to post your SQL login credentials for the world to see, so I have removed them.

johanafm

There seems to be an error in this part:

$query= "insert into customer VALUES (' ', '$name', '$address', '$postcode', '$telenumber', '$email',
'$model', '$date', '$time')";

the first VALUES entry contains: ' '
which is not the same as null. The whitespace ought to be either considered as a string or be converted to integer which ought to evaluate to 0.
If it evaluates to 0 it should allow for one single entry into the database. The second time around you should get a duplicate entry for your primary key.

Instead, go with

$query= "insert into customer VALUES (null, '$name', '$address', '$postcode', '$telenumber', '$email',
'$model', '$date', '$time')";

bradgrafelman

Actually, I think you should be explicity naming the columns in the INSERT statement, that way you don't even have to name the autoinc column at all.

deepika

thank u bradgrafelman for placing the code in the body of my post. Could u plz tell me whether there r any errors in my code

thank u

TobyRT

At first glance it looks as though you've put some of your if() statements in the wrong place - you're telling it to error check, then say everything is OK before you run the query.
You should error check, then if that's OK run the query, then if THAT'S ok you should say "thank you for posting", but I'll look more fully now

TobyRT

Ahhh...you're MISSING an if() statement.

You say on your page "fill in the form" - then you have all the php code, then the form. You're not telling the browser or the server what to do.

You start the page fine, but then you need to say what to do:
"is the form submitted"?
If no, then display it (as you have done) and you're OK,
If yes, then you need to run the php coding you've already placed
Something along these lines, and there are better ways of reporting erros using arrays, but I don't have my code to hand!

if (!isset($_POST['submit'])) //if the form is not submitted
{
<!--insert your form here-->
}
else
{
if ($error_msg =='')//i.e if there are no error messages
{
<!--perform the insert query--> //and confirm all is OK
}
else //i.e if there ARE error messages
{
echo $error_msg;
}
} //this ends the 'else if form IS submitted' statement