[RESOLVED] checking variables

182x

Hey guys,

I have created an upload file script for a form however if the user does not upload a file I do not want the file upload part of the script to be used. Is there a way to check if the file type on the form is empty?

Thanks.

dagon

empty()

182x

Thank I am using the following structure but no matter what I do now it calls the last else and does not upload even if a file has been selected. Have I used the empty function in the wrong way?

<?php
	session_start();

if(strlen($_POST['description']) > 4000)
{
	//error msg


}


else{

if (!empty($_FILES))
{
	//upload




}

else
	{

//don't upload
}
}
?>

dagon

session_start();

if(strlen($_POST['description']) > 4000)
{
	//error msg
}else{ //no error

if(!empty($_FILES['image']['name'])){ //better to check a specific key than for the exixtance of the array
{
	//upload
}else{
	//no upload
}
}

ref: http://nz.php.net/manual/en/features.file-upload.php

182x

Even with the code above it is still always using the last else and not uploading the file even if it has been selected. Any suggestions? Thanks.

NogDog

Silly question #1: have you changed 'image' in $_FILES['image']['name'] to whatever the actual name is of your <input type="file"> form element?

Silly question #2: Assuming that question #1 was just a silly question, if you do not put in the if/else check and submit the form with a file, does it work OK?

182x

Hey, thanks for the reply yeah question 1 I had taken care of on my script it is 'getFile' not 'image'.

As for question 2 it works fine without the if/else which is why its a bit annoying really.

NogDog

As far as I know, either of those methods should work. My best guess at this point is something else is going on in the code that we're not seeing. You might want to throw in a few echo statements and maybe a var_dump($_FILES) to see what's going on.

182x

It turns out I was mistaken my upload script is not working, can you see the problem?

<?php
	session_start();
	include ('db.php');
	$link_id = connect('');


	$fileLocation = "../upload/";

	$location = $fileLocation.$_FILES['getFile']['name'];


if(move_uploaded_file($_FILES['getFile']['tmp_name'], $location))
	{




$file="INSERT INTO upload VALUES('','location')";
mysql_query($file, $link_id) or die(mysql_error());


 }//end of if

 else
 	 {
//error
	}


?>

laserlight

How does it not work? Oh, and you might want to indent your code properly and use the php forum bbcode tags instead of the more generic code forum bbcode tags.

<?php
session_start();

include 'db.php';

$link_id = connect('');

$fileLocation = "../upload";

$location = $fileLocation . $_FILES['getFile']['name'];

if (move_uploaded_file($_FILES['getFile']['tmp_name'], $location))
{
    $file = "INSERT INTO upload VALUES('', 'location')";
    mysql_query($file, $link_id) or die(mysql_error());
}
else
{
    //error
}

?>

182x

Hi, it doesn't work as the last else is always called where an error is displayed.

laserlight

Do some debugging. One manual but usually workable way is to print out variables to check their contents. For example, you could print the value of $location to see whether it looks correct.

182x

Actually its not concatenating properly, but the syntax looks correct this is a weird problem.

NogDog

My guess is a permission problem on the target directory, but let's add some debugging to find out:

<?php
// turn on all error reporting for now (you can comment out later)
ini_set('display_errors', 1);
error_reporting(E_ALL);

// ... start of script, then ...

if (move_uploaded_file($_FILES['getFile']['tmp_name'], $location))
{
    $file = "INSERT INTO upload VALUES('', 'location')";
    mysql_query($file, $link_id) or die(mysql_error());
}
else
{
    user_error("move_uploaded_file() failed: " . $_FILES['getFile']['error']
}

182x

when I use that code it producdes te following errors:

Notice: Undefined index: getFile in C:\xampp\htdocs\a\test\process.php on line 12

Notice: Undefined index: getFile in C:\xampp\htdocs\a\test\process.php on line 26

Notice: Undefined index: getFile in C:\xampp\htdocs\a\test\process.php on line 59

Notice: move_uploaded_file() failed: in C:\xampp\htdocs\a\test\process.php on line 59

laserlight

Oh, looks like the file is not being uploaded at all. Is your form set to enctype="multipart/form-data"?

NogDog

Are you sure that the name of the file input element is 'getFile' (including the upper/lower case of the letters)?

Does your form tag specify the enctype="multipart/form-data" attibute? (See http://www.php.net/manual/en/features.file-upload.php for more info.)

182x

Hi, I did not have the enctype="multipart/form-data" attribute in the form. Can't believe it as something so simple!!

Thanks guys 🙂

182x

Is there a default max size limit to the uploads and would certain types of files be rejected or is everything excepted?

I tryed to upload a 20mb file for a test and it was rejected however all smaller files were fine.

laserlight

Read the PHP manual on handling file uploads. You will find that: "The MAX_FILE_SIZE item cannot specify a file size greater than the file size that has been set in the upload_max_filesize ini-setting. The default is 2 Megabytes."